From: "Laszlo Ersek" <lersek@redhat.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Sunil V L <sunilvl@ventanamicro.com>,
USER0FISH <libing1202@outlook.com>,
caiyuqing379 <caiyuqing_hz@outlook.com>,
dahogn <dahogn@hotmail.com>, meng-cz <mengcz1126@gmail.com>
Subject: [edk2-devel] [edk2-platforms PATCH v2 4/4] SG2042Pkg/Sec: clean up ProcessLibraryConstructorList() decl
Date: Tue, 5 Mar 2024 13:01:26 +0100 [thread overview]
Message-ID: <20240305120126.70259-5-lersek@redhat.com> (raw)
In-Reply-To: <20240305120126.70259-1-lersek@redhat.com>
<Library/PeimEntryPoint.h> declares a bogus
ProcessLibraryConstructorList() for the SG2042Pkg SEC module. Rely on
AutoGen for (properly) declaring ProcessLibraryConstructorList(). Remove
the correct, but superfluous, declaration as well.
Build-tested with:
build -a RISCV64 -b DEBUG -m Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf \
-p Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc -t GCC5
Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: USER0FISH <libing1202@outlook.com>
Cc: caiyuqing379 <caiyuqing_hz@outlook.com>
Cc: dahogn <dahogn@hotmail.com>
Cc: meng-cz <mengcz1126@gmail.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf | 2 +-
Silicon/Sophgo/SG2042Pkg/Sec/SecMain.h | 12 ------------
Silicon/Sophgo/SG2042Pkg/Sec/Memory.c | 1 -
3 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf b/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf
index a9f631193b8b..fd52dccfacac 100644
--- a/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf
+++ b/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf
@@ -9,7 +9,7 @@
##
[Defines]
- INF_VERSION = 0x0001001B
+ INF_VERSION = 1.30
BASE_NAME = SecMainRiscV64
FILE_GUID = 125E1236-9D4F-457B-BF7E-6311C88A1621
MODULE_TYPE = SEC
diff --git a/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.h b/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.h
index 8d2c4a4c25e0..daab7c78b409 100644
--- a/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.h
+++ b/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.h
@@ -49,18 +49,6 @@ SecStartup (
IN VOID *DeviceTreeAddress
);
-/**
- Auto-generated function that calls the library constructors for all of the module's
- dependent libraries. This function must be called by the SEC Core once a stack has
- been established.
-
-**/
-VOID
-EFIAPI
-ProcessLibraryConstructorList (
- VOID
- );
-
/**
Perform Platform PEIM initialization.
diff --git a/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c b/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c
index 51974cf2dc28..df49a17695d1 100644
--- a/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c
+++ b/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c
@@ -19,7 +19,6 @@ Module Name:
#include <Library/HobLib.h>
#include <Library/IoLib.h>
#include <Library/PcdLib.h>
-#include <Library/PeimEntryPoint.h>
#include <Library/ResourcePublicationLib.h>
#include <Register/RiscV64/RiscVEncoding.h>
#include <Library/PrePiLib.h>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116382): https://edk2.groups.io/g/devel/message/116382
Mute This Topic: https://groups.io/mt/104742763/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-05 12:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 12:01 [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 1/4] BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl Laszlo Ersek
2024-03-05 13:01 ` Ard Biesheuvel
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 2/4] SimicsOpenBoardPkg: auto-gen & fix " Laszlo Ersek
2024-03-06 21:10 ` Laszlo Ersek
2024-03-06 22:24 ` Michael D Kinney
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 3/4] LoongArchQemuPkg: " Laszlo Ersek
2024-03-05 13:05 ` Chao Li
2024-03-05 12:01 ` Laszlo Ersek [this message]
2024-03-05 14:07 ` [edk2-devel] [edk2-platforms PATCH v2 4/4] SG2042Pkg/Sec: clean up " Sunil V L
2024-03-08 9:20 ` [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305120126.70259-5-lersek@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox