From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DC617740057 for ; Thu, 7 Mar 2024 09:04:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2lSVdoZhPtAJaaj4irbqeVVyYRxQpOaL37ceQaa9TV8=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:User-Agent:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1709802278; v=1; b=tifAHcl3UgCEF1m2XfRSZyajGHXs4Q9hnxdXer4270RcAkvPKS7tdlT3yzanlVVYZ4cFGDWz SuMGrkB7qmiHwpe5EpoMMXX4bsRFg6GPTER47fWwfhUQdWp/eUjhVz5NE3ZP5bT65ykYd+/9Xvi +zuxeZTgLgA/GeGA71QCY+oYI9iowots2OVstBtqoUs0R205ej8hdG811daSoy7KWyH0rtKviie p5Nr9IwJ8zbXojnQG9FYzxNfRY3IcktszaR6l9TPdv7Hw6lgWw0a2ZXhIYcNv3mXHLr8iZL/ky0 tmccButiuM6eTUHoqKn5llVOaEhe1+leOSzTKhw9ADzMw== X-Received: by 127.0.0.2 with SMTP id CDEfYY7687511xjZvoYksFlR; Thu, 07 Mar 2024 01:04:38 -0800 X-Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by mx.groups.io with SMTP id smtpd.web10.19127.1709802277800051699 for ; Thu, 07 Mar 2024 01:04:38 -0800 X-Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a2f22bfb4e6so103736366b.0 for ; Thu, 07 Mar 2024 01:04:37 -0800 (PST) X-Gm-Message-State: MtE3PlLQaibHNCEUv9qISW7gx7686176AA= X-Google-Smtp-Source: AGHT+IGBQfiLD7lroi+HXdtiFeINX1mJyFEbIqEMqyJWbOliak3FPNLygMxHRMblqKdzkRZ10WHWHQ== X-Received: by 2002:a17:906:714f:b0:a42:615:1395 with SMTP id z15-20020a170906714f00b00a4206151395mr11669330ejj.11.1709802276059; Thu, 07 Mar 2024 01:04:36 -0800 (PST) X-Received: from linux-l9pv.suse ([124.11.22.254]) by smtp.gmail.com with ESMTPSA id vu2-20020a170907a64200b00a43bf7ef577sm7992664ejc.188.2024.03.07.01.04.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2024 01:04:35 -0800 (PST) Date: Thu, 07 Mar 2024 01:04:38 -0800 From: "joeyli via groups.io" To: Laszlo Ersek Cc: devel@edk2.groups.io, Liming , Michael D Kinney , joeyli.kernel@gmail.com, Gerd Hoffmann , Jiewen Yao , Jordan Justen , Pawel Polawski , Oliver Steffen , Ard Biesheuvel , ruifeng.gao@intel.com Subject: Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again Message-ID: <20240307090426.GB31128@linux-l9pv.suse> References: <20240204092914.29813-1-jlee@suse.com> <3662a1f0-b06a-f53c-25ce-91c95e8dec59@redhat.com> <20240207075549.GZ21608@linux-l9pv.suse> <17B185EB8F3EA51B.19081@groups.io> <20240304113752.GK31128@linux-l9pv.suse> <28fbbc44-cc80-e58d-f8bb-6976613dc48a@redhat.com> MIME-Version: 1.0 In-Reply-To: <28fbbc44-cc80-e58d-f8bb-6976613dc48a@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jlee@suse.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=tifAHcl3; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Laszlo, On Tue, Mar 05, 2024 at 09:53:33AM +0100, Laszlo Ersek wrote: > On 3/4/24 12:37, joeyli via groups.io wrote: > > Hi, > > > > On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrote: > >> On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote: > >>> Hi Laszlo, > >>> > >>> First, thanks for your review! > >>> > >>> On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote: > >>>> On 2/4/24 10:29, Lee, Chun-Yi wrote: > >>>>> In case PcdFirmwareReleaseDateString is not set use a valid date > >>>>> as fallback. But the default valid date can _NOT_ pass the Microsoft > >>>>> SVVP test "Check SMBIOS Table Specific Requirements". The test emitted > >>>>> the error message: > >>>>> > >>>>> BIOS Release Date string is unexpected length: 8. This string must be in > >>>>> MM/DD/YYYY format. No other format is allowed and no additional information > >>>>> may be included. See field description in the SMBIOS specification. > >>>>> > >>>>> Base on SMBIOS spec v3.7.0: > >>>>> > >>>>> 08h 2.0+ BIOS Release Date BYTE STRING > >>>>> String number of the BIOS release date. The date > >>>>> string, if supplied, is in either mm/dd/yy or > >>>>> mm/dd/yyyy format. If the year portion of the string > >>>>> is two digits, the year is assumed to be 19yy. > >>>>> NOTE: The mm/dd/yyyy format is required for SMBIOS > >>>>> version 2.3 and later. > >>>>> > >>>>> So, let's tweek the fallback release date again. > >>>>> > >>>>> Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327] > >>>>> Signed-off-by: "Lee, Chun-Yi" > >>>>> --- > >>>>> OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- > >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>>> > >>>>> diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > >>>>> index 0ca3776045..e929da6b81 100644 > >>>>> --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > >>>>> +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > >>>>> @@ -160,7 +160,7 @@ InstallAllStructures ( > >>>>> DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString); > >>>>> DateLen = StrLen (DateStr); > >>>>> if (DateLen < 3) { > >>>>> - DateStr = L"2/2/2022"; > >>>>> + DateStr = L"02/02/2022"; > >>>>> DateLen = StrLen (DateStr); > >>>>> } > >>>>> > >>>> > >>>> Are you proposing this as an important (but low risk) bugfix that might > >>>> qualify for the freeze(s)? If so, please loop in Liming and Mike. > >>>> > >>> > >>> hm... What does freeze mean? > >>> > >> > >> ah... You mean soft feature freeze for edk2-stable202402. > >> > >> Hi Liming, Michael, > >> > >> This change is important but low risk. Could you please consider to add it > >> to edk2-stable202402 release? > >> > >> Thanks a lot! > >> Joey Lee > > > > This patch is not in edk2-stable202402. Will it to be merged to next release? > > Thanks for the reminder, and sorry about the delay! > > Merged as commit 2a0d4a2641a7, via > . Thanks for your review and merge! > > For future contributions: please run PatchCheck.py on the patch series > before formatting and posting it (better yet, submit a personal CI build > PR). > For 'submit personal CI build PR', I was created a pull requests on github: https://github.com/tianocore/edk2/pull/5349 Is it the right approach for triggering a CI build PR? Thanks a lot! Joey Lee -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116478): https://edk2.groups.io/g/devel/message/116478 Mute This Topic: https://groups.io/mt/104153758/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-