From: "Oliver Smith-Denny" <osde@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Liming Gao <gaoliming@byosoft.com.cn>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <sami.mujawar@arm.com>,
Taylor Beebe <taylor.d.beebe@gmail.com>
Subject: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes
Date: Mon, 11 Mar 2024 14:29:21 -0700 [thread overview]
Message-ID: <20240311212924.11633-1-osde@linux.microsoft.com> (raw)
ImagePropertiesRecordLib is currently creating Image Records that
are not accurate. It is setting the CodeSegmentSize to be the size
of the raw data in the image file, however, when the image is
loaded into memory, the raw data size is aligned to the
section alignment. This caused the memory attributes table to
have incorrect entries for systems, like ARM64, where the section
alignment is not 4k for all modules.
In fixing this, I noticed that MemoryProtection.c is using its own
version of image record creation where this logic was actually
correct. ImagePropertiesRecordLib was created to consolidate the
logic around creating and managing image records, so this patchset
also updates MemoryProtection.c to use ImagePropertiesRecordsLib
after making a few small adjustments to ensure the same functionality
is present.
This patchset was tested on ArmVirtQemu to ensure that all image
records were the same before and after this, other than fixing
the CodeSegmentSize.
v2:
- Align VirtualSize instead of SizeOfRawData
Github PR: https://github.com/tianocore/edk2/pull/5402
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Taylor Beebe <taylor.d.beebe@gmail.com>
Oliver Smith-Denny (3):
MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for
CodeSize
MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage
MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesLib
MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 241 +++-----------------
MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.c | 86 +++++--
2 files changed, 94 insertions(+), 233 deletions(-)
--
2.40.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116657): https://edk2.groups.io/g/devel/message/116657
Mute This Topic: https://groups.io/mt/104873191/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next reply other threads:[~2024-03-11 21:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 21:29 Oliver Smith-Denny [this message]
2024-03-11 21:29 ` [edk2-devel] [PATCH v2 1/3] MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize Oliver Smith-Denny
2024-03-12 8:33 ` Ard Biesheuvel
2024-03-16 12:21 ` Marvin Häuser
2024-03-11 21:29 ` [edk2-devel] [PATCH v2 2/3] MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage Oliver Smith-Denny
2024-03-11 21:29 ` [edk2-devel] [PATCH v2 3/3] MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesLib Oliver Smith-Denny
[not found] <17BBD31426742776.6798@groups.io>
2024-03-13 17:33 ` [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes Oliver Smith-Denny
[not found] ` <17BC63588355F2EE.10267@groups.io>
2024-03-20 17:35 ` Oliver Smith-Denny
[not found] ` <17BE8986E5F1B75A.24580@groups.io>
2024-03-27 18:14 ` Oliver Smith-Denny
2024-03-29 8:03 ` Ard Biesheuvel
2024-03-29 17:12 ` Michael D Kinney
2024-03-29 17:13 ` Oliver Smith-Denny
2024-03-29 17:27 ` Michael D Kinney
2024-03-29 17:28 ` Oliver Smith-Denny
[not found] ` <17C14C5D0AA05940.7714@groups.io>
2024-03-29 20:22 ` Oliver Smith-Denny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311212924.11633-1-osde@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox