From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1B9A3AC13E1 for ; Tue, 12 Mar 2024 15:40:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=i+v6KCpxSoQQQPc6vDBfE5BhIyw/Q5BI8ITX0wD6vLw=; c=relaxed/simple; d=groups.io; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1710258012; v=1; b=zgDaIr3Ks+2gybGI/b6jHiCu6z3NAxgRjCYBUwY7Ri9vGSp90FmRNRYsJT+9qb6m4JHsKFxZ EGGr5mjKU06/kwYYMJVlXV44NchaOaHPXvjSb3EsrayJFQ8IbBG6C2nf73JsOyjiou8LAW30ZM3 GPU+du29nR6y3v4BzMM2UaWLJ74DIX1/3DooLlexFQf2RdH4SsQS9d9N5V0x8d8nvDm15W3ByjC tDzP7gGYOu3KPHRmgn29oXNsybeuLylphUGCpw5HLyAjOYwkCbAjjgkZ673Fbb5vwPR9Gm5tWl/ GAoM+FkaM4irNkScv/5YwirWtlGlNMMBCrq2jGHw5TvbA== X-Received: by 127.0.0.2 with SMTP id XGHqYY7687511xUkIyBLKvOI; Tue, 12 Mar 2024 08:40:12 -0700 X-Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by mx.groups.io with SMTP id smtpd.web10.12674.1710256640524038095 for ; Tue, 12 Mar 2024 08:17:20 -0700 X-Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-609fe434210so74024347b3.1 for ; Tue, 12 Mar 2024 08:17:20 -0700 (PDT) X-Gm-Message-State: MLJdURu0TJNC0JK8hetpv8Tzx7686176AA= X-Google-Smtp-Source: AGHT+IEIvvL8qg/unQL31XcVf0XxacrcHdZkjKS2tyLHuJWyQAyhdzfPYuG+dtjh+ocwkPrqlMwCPVDk X-Received: from palermo.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:118a]) (user=ardb job=sendgmr) by 2002:a05:6902:100d:b0:dcc:8be2:7cb0 with SMTP id w13-20020a056902100d00b00dcc8be27cb0mr524110ybt.0.1710256639629; Tue, 12 Mar 2024 08:17:19 -0700 (PDT) Date: Tue, 12 Mar 2024 16:17:16 +0100 Mime-Version: 1.0 Message-ID: <20240312151716.2154180-1-ardb+git@google.com> Subject: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed From: "Ard Biesheuvel via groups.io" To: devel@edk2.groups.io Cc: jeremy.linton@arm.com, quic_llindhol@quicinc.com, abner.chang@amd.com, Ard Biesheuvel Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 12 Mar 2024 08:40:05 -0700 Reply-To: devel@edk2.groups.io,ardb+git@google.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=zgDaIr3K; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Ard Biesheuvel NonCoherentIoMmuSetAttribute() does nothing except return EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI bus driver will fail a PCI I/O Map() operation if the SetAttributes fails. So return EFI_SUCCESS instead. Signed-off-by: Ard Biesheuvel --- This fixes a regression on Raspberry Pi4, which no longer boots. EmbeddedPkg/Drivers/NonCoherentIoMmuDxe/NonCoherentIoMmuDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EmbeddedPkg/Drivers/NonCoherentIoMmuDxe/NonCoherentIoMmuDxe.c b/EmbeddedPkg/Drivers/NonCoherentIoMmuDxe/NonCoherentIoMmuDxe.c index 4e7a5698c162..f02a76a62ea8 100644 --- a/EmbeddedPkg/Drivers/NonCoherentIoMmuDxe/NonCoherentIoMmuDxe.c +++ b/EmbeddedPkg/Drivers/NonCoherentIoMmuDxe/NonCoherentIoMmuDxe.c @@ -70,7 +70,7 @@ NonCoherentIoMmuSetAttribute ( IN UINT64 IoMmuAccess ) { - return EFI_UNSUPPORTED; + return EFI_SUCCESS; } /** -- 2.44.0.278.ge034bb2e1d-goog -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116688): https://edk2.groups.io/g/devel/message/116688 Mute This Topic: https://groups.io/mt/104886877/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-