* [edk2-devel] [PATCH v1 0/1] Cleanup ProcessLibraryConstructorList() @ 2024-03-15 9:20 brucex.wang 2024-03-15 9:20 ` [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: " brucex.wang 0 siblings, 1 reply; 3+ messages in thread From: brucex.wang @ 2024-03-15 9:20 UTC (permalink / raw) To: devel; +Cc: brucex.wang From: Bruce Wang <brucex.wang@intel.com> ProcessLibraryConstructorList() no needs to be called manually after INF version greater or equal to 1.30. Bruce Wang (1): UefiPayloadPkg: Cleanup ProcessLibraryConstructorList() UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c | 2 -- UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 2 -- UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 2 -- 3 files changed, 6 deletions(-) -- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116864): https://edk2.groups.io/g/devel/message/116864 Mute This Topic: https://groups.io/mt/105014770/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 3+ messages in thread
* [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Cleanup ProcessLibraryConstructorList() 2024-03-15 9:20 [edk2-devel] [PATCH v1 0/1] Cleanup ProcessLibraryConstructorList() brucex.wang @ 2024-03-15 9:20 ` brucex.wang 2024-03-15 9:28 ` Guo, Gua 0 siblings, 1 reply; 3+ messages in thread From: brucex.wang @ 2024-03-15 9:20 UTC (permalink / raw) To: devel; +Cc: brucex.wang, Guo Dong, Sean Rhodes, James Lu, Gua Guo From: Bruce Wang <brucex.wang@intel.com> ProcessLibraryConstructorList() no needs to be called manually after INF version greater or equal to 1.30. Cc: Guo Dong <guo.dong@intel.com> Cc: Sean Rhodes <sean@starlabs.systems> Cc: James Lu <james.lu@intel.com> Cc: Gua Guo <gua.guo@intel.com> Signed-off-by: BruceX Wang <brucex.wang@intel.com> --- UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c | 2 -- UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 2 -- UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 2 -- 3 files changed, 6 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c index eb0b325369..58a7e8190f 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c @@ -616,8 +616,6 @@ _ModuleEntryPoint ( mHobList = (VOID *)BootloaderParameter; DxeFv = NULL; - // Call constructor for all libraries - ProcessLibraryConstructorList (); DEBUG ((DEBUG_INFO, "Entering Universal Payload...\n")); DEBUG ((DEBUG_INFO, "sizeof(UINTN) = 0x%x\n", sizeof (UINTN))); diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c index 030a5baed9..7c65869563 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c @@ -434,8 +434,6 @@ _ModuleEntryPoint ( UniversalSerialPort->RegisterStride = (UINT8)SerialPortInfo.RegWidth; } - // The library constructors might depend on serial port, so call it after serial port hob - ProcessLibraryConstructorList (); DEBUG ((DEBUG_INFO, "sizeof(UINTN) = 0x%x\n", sizeof (UINTN))); // Build HOB based on information from Bootloader diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c index f37c00fad7..019b6b3d8b 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c @@ -462,8 +462,6 @@ _ModuleEntryPoint ( mHobList = (VOID *)BootloaderParameter; DxeFv = NULL; - // Call constructor for all libraries - ProcessLibraryConstructorList (); DEBUG ((DEBUG_INFO, "Entering Universal Payload...\n")); DEBUG ((DEBUG_INFO, "sizeof(UINTN) = 0x%x\n", sizeof (UINTN))); -- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116865): https://edk2.groups.io/g/devel/message/116865 Mute This Topic: https://groups.io/mt/105014773/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Cleanup ProcessLibraryConstructorList() 2024-03-15 9:20 ` [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: " brucex.wang @ 2024-03-15 9:28 ` Guo, Gua 0 siblings, 0 replies; 3+ messages in thread From: Guo, Gua @ 2024-03-15 9:28 UTC (permalink / raw) To: Wang, BruceX, devel@edk2.groups.io; +Cc: Dong, Guo, Rhodes, Sean, Lu, James Reviewed-by: Gua Guo <gua.guo@intel.com> -----Original Message----- From: Wang, BruceX <brucex.wang@intel.com> Sent: Friday, March 15, 2024 5:21 PM To: devel@edk2.groups.io Cc: Wang, BruceX <brucex.wang@intel.com>; Dong, Guo <guo.dong@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com> Subject: [PATCH v1 1/1] UefiPayloadPkg: Cleanup ProcessLibraryConstructorList() From: Bruce Wang <brucex.wang@intel.com> ProcessLibraryConstructorList() no needs to be called manually after INF version greater or equal to 1.30. Cc: Guo Dong <guo.dong@intel.com> Cc: Sean Rhodes <sean@starlabs.systems> Cc: James Lu <james.lu@intel.com> Cc: Gua Guo <gua.guo@intel.com> Signed-off-by: BruceX Wang <brucex.wang@intel.com> --- UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c | 2 -- UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 2 -- UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 2 -- 3 files changed, 6 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c index eb0b325369..58a7e8190f 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c @@ -616,8 +616,6 @@ _ModuleEntryPoint ( mHobList = (VOID *)BootloaderParameter; DxeFv = NULL;- // Call constructor for all libraries- ProcessLibraryConstructorList (); DEBUG ((DEBUG_INFO, "Entering Universal Payload...\n")); DEBUG ((DEBUG_INFO, "sizeof(UINTN) = 0x%x\n", sizeof (UINTN)));diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c index 030a5baed9..7c65869563 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c @@ -434,8 +434,6 @@ _ModuleEntryPoint ( UniversalSerialPort->RegisterStride = (UINT8)SerialPortInfo.RegWidth; } - // The library constructors might depend on serial port, so call it after serial port hob- ProcessLibraryConstructorList (); DEBUG ((DEBUG_INFO, "sizeof(UINTN) = 0x%x\n", sizeof (UINTN))); // Build HOB based on information from Bootloaderdiff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c index f37c00fad7..019b6b3d8b 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c @@ -462,8 +462,6 @@ _ModuleEntryPoint ( mHobList = (VOID *)BootloaderParameter; DxeFv = NULL;- // Call constructor for all libraries- ProcessLibraryConstructorList (); DEBUG ((DEBUG_INFO, "Entering Universal Payload...\n")); DEBUG ((DEBUG_INFO, "sizeof(UINTN) = 0x%x\n", sizeof (UINTN)));-- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116791): https://edk2.groups.io/g/devel/message/116791 Mute This Topic: https://groups.io/mt/104944095/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-18 23:18 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-03-15 9:20 [edk2-devel] [PATCH v1 0/1] Cleanup ProcessLibraryConstructorList() brucex.wang 2024-03-15 9:20 ` [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: " brucex.wang 2024-03-15 9:28 ` Guo, Gua
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox