From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 77767D80127 for ; Mon, 18 Mar 2024 02:20:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CsupIITIR8cKVZrgmERQznKFEYvrUnqZm5EV906zP6g=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1710728426; v=1; b=QSe6l3xg1J/0vbWoKsOKNP80LKiyM+puar91C0D8vr/h2LEOhJm6WB2CcT5+TE8rYRVfBh1A SGlYUJ89LA6IScTe0YfENITwgZCD/WlMSljKAx9v+vAB5jYk55fpyijsR71B//v2kSkUmwM4Ggk Wy6Im2rvOZeqDSvPSqNKEkRTxZ8xM2xKpL6syXlQJd1bnITx0xcdYBogVJJ20GFPvVBBnu14PYl AClvvwf/lmuQUugmlIdOPrjX8XruTmRbpOgh4zNbnjsEJWS+1GhLUJ6axNvoF/h+r0mpSw2K7A0 +FyYRAKW/Nrm1NNFLQv+trrLGqK6R2EBXQcyr0MsKC2yw== X-Received: by 127.0.0.2 with SMTP id iQqnYY7687511x7irDhBcJSL; Sun, 17 Mar 2024 19:20:26 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mx.groups.io with SMTP id smtpd.web11.34038.1710728416304381805 for ; Sun, 17 Mar 2024 19:20:25 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11016"; a="5363123" X-IronPort-AV: E=Sophos;i="6.07,133,1708416000"; d="scan'208";a="5363123" X-Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2024 19:20:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,133,1708416000"; d="scan'208";a="13356221" X-Received: from shwdesfp01.ccr.corp.intel.com ([10.239.158.151]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2024 19:20:23 -0700 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Zhiguang Liu , Liming Gao , Jiaxin Wu , Ray Ni , Laszlo Ersek , Ard Biesheuvel , Sami Mujawar Subject: [edk2-devel] [PATCH 4/6] Revert ae1079b386a597108a8070652bf7cdaa4ec3dda3 Date: Mon, 18 Mar 2024 10:19:54 +0800 Message-Id: <20240318021956.2787-5-zhiguang.liu@intel.com> In-Reply-To: <20240318021956.2787-1-zhiguang.liu@intel.com> References: <20240318021956.2787-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 17 Mar 2024 19:20:25 -0700 Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vNmoN1D4rmQh8lqZSsiUTeavx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=QSe6l3xg; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) This reverts "MdeModulePkg/SMM: Support to unregister SMI handler inside SMI handler" for better design later. Cc: Liming Gao Cc: Jiaxin Wu Cc: Ray Ni Cc: Laszlo Ersek Cc: Ray Ni Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Sami Mujawar Signed-off-by: Zhiguang Liu --- MdeModulePkg/Core/PiSmmCore/Smi.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/MdeModulePkg/Core/PiSmmCore/Smi.c b/MdeModulePkg/Core/PiSmmCore/Smi.c index 3489c130fd..2985f989c3 100644 --- a/MdeModulePkg/Core/PiSmmCore/Smi.c +++ b/MdeModulePkg/Core/PiSmmCore/Smi.c @@ -134,14 +134,8 @@ SmiManage ( Head = &SmiEntry->SmiHandlers; - for (Link = Head->ForwardLink; Link != Head;) { + for (Link = Head->ForwardLink; Link != Head; Link = Link->ForwardLink) { SmiHandler = CR (Link, SMI_HANDLER, Link, SMI_HANDLER_SIGNATURE); - // - // To support unregister SMI handler inside SMI handler itself, - // get next node before handler is executed, since LIST_ENTRY that - // Link points to may be freed if unregister SMI handler. - // - Link = Link->ForwardLink; Status = SmiHandler->Handler ( (EFI_HANDLE)SmiHandler, -- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116830): https://edk2.groups.io/g/devel/message/116830 Mute This Topic: https://groups.io/mt/104996184/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-