[edk2-devel] [PATCH v1 0/1] MdePkg/BaseLib: Fix AARCH64 compilation error

[edk2-devel] [PATCH v1 0/1] MdePkg/BaseLib: Fix AARCH64 compilation error

[Adam Liu]

MdePkg/BaseLib complains missing InternalAsserJumpBuffer error when built with -a AARCH64 option. Declare InternalAssertJumpBuffer to fix this issue. 

Command:
build -a AARCH64 -p MdePkg\MdePkg.dsc -m MdePkg\Library\BaseLib\BaseLib.inf

Output:
c:\projects\github\edk2\Build\Mde\DEBUG_VS2019\AARCH64\MdePkg\Library\BaseLib\BaseLib\OUTPUT\AArch64\SetJumpLongJump.iiii(51) : error A2023: undefined symbol: InternalAssertJumpBuffer
        bl      InternalAssertJumpBuffer
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.29.30133\bin\Hostx86\arm64\armasm64.exe"' : return code '0x1'
Stop.

Shun Cheng Liu (1):
  MdePkg/BaseLib: Fix AARCH64 compilation error

 MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
 1 file changed, 1 insertion(+)

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116833): https://edk2.groups.io/g/devel/message/116833
Mute This Topic: https://groups.io/mt/104997021/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v1 1/1] MdePkg/BaseLib: Fix AARCH64 compilation error

[Adam Liu]

Declare InternalAssertJumpBuffer as EXTERN

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Shun Cheng Liu <adam.liu@tw.synaptics.com>
---
 MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
index 6ec8f35f2c9f..fa161e25f517 100644
--- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
+++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
@@ -7,6 +7,7 @@
 
   EXPORT SetJump
   EXPORT InternalLongJump
+  EXTERN InternalAssertJumpBuffer
   AREA BaseLib_LowLevel, CODE, READONLY
 
 #define GPR_LAYOUT                          \
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116834): https://edk2.groups.io/g/devel/message/116834
Mute This Topic: https://groups.io/mt/104997022/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 1/1] MdePkg/BaseLib: Fix AARCH64 compilation error

[levi.yun]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

I think it would be nice if you add

diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
index 3e58119b25d2..505d3765c522 100644
--- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
+++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
@@ -9,6 +9,7 @@

GCC_ASM_EXPORT(SetJump)
GCC_ASM_EXPORT(InternalLongJump)
+GCC_ASM_IMPORT(InternalAssertJumpBuffer)

#define GPR_LAYOUT                         \
REG_PAIR (x19, x20,  0);           \

Thou, the gcc doesn't raise compile error
(in ASM_FLAG, there's no option set "-Werror-implicit-function-declaration")

Otherwise,

Reviewed-by: levi.yun <yeoreum.yun@arm.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116837): https://edk2.groups.io/g/devel/message/116837
Mute This Topic: https://groups.io/mt/104997022/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1816 bytes --]