[edk2-devel] [PATCH v2 0/1] MdePkg/BaseLib: Fix AARCH64 compilation error

[edk2-devel] [PATCH v2 0/1] MdePkg/BaseLib: Fix AARCH64 compilation error

[Adam Liu]

Declare InternalAssertJumpBuffer to fix build error. 

Shun Cheng Liu (1):
  MdePkg/BaseLib: Fix AARCH64 compilation error

 MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S   | 1 +
 MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
 2 files changed, 2 insertions(+)

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116910): https://edk2.groups.io/g/devel/message/116910
Mute This Topic: https://groups.io/mt/105038587/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix AARCH64 compilation error

[Adam Liu]

Declare InternalAssertJumpBuffer as EXTERN

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Shun Cheng Liu <adam.liu@tw.synaptics.com>
Reviewed-by: levi.yun <yeoreum.yun@arm.com>
---
 MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S   | 1 +
 MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
 2 files changed, 2 insertions(+)

diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
index 3e58119b25d2..505d3765c522 100644
--- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
+++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
@@ -9,6 +9,7 @@
 
 GCC_ASM_EXPORT(SetJump)
 GCC_ASM_EXPORT(InternalLongJump)
+GCC_ASM_IMPORT(InternalAssertJumpBuffer)
 
 #define GPR_LAYOUT                         \
         REG_PAIR (x19, x20,  0);           \
diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
index 6ec8f35f2c9f..fa161e25f517 100644
--- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
+++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
@@ -7,6 +7,7 @@
 
   EXPORT SetJump
   EXPORT InternalLongJump
+  EXTERN InternalAssertJumpBuffer
   AREA BaseLib_LowLevel, CODE, READONLY
 
 #define GPR_LAYOUT                          \
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116911): https://edk2.groups.io/g/devel/message/116911
Mute This Topic: https://groups.io/mt/105038588/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix AARCH64 compilation error

[Adam Liu]

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

Hello all,

The patch was reviewed and I submitted a pull request https://github.com/tianocore/edk2/pull/5482 for this patch. Is there any other requirement to let this patch merge into master?

Regards,
Adam


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117229): https://edk2.groups.io/g/devel/message/117229
Mute This Topic: https://groups.io/mt/105038588/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1112 bytes --]