* [edk2-devel] [PATCH 02/14] Platform/ARM: FVP,Juno: Move Power Mgmt Profile info to Arch Common
2024-03-21 16:08 [edk2-devel] [PATCH " PierreGondois
@ 2024-03-21 16:08 ` PierreGondois
0 siblings, 0 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 16:08 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
- FVP
for the following Arch Common object Id:
- EArchCommonObjPowerManagementProfileInfo
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
.../ConfigurationManager.c | 19 ++++++++++---------
.../ConfigurationManager.h | 2 +-
.../ConfigurationManager.c | 19 ++++++++++---------
.../ConfigurationManager.h | 2 +-
4 files changed, 22 insertions(+), 20 deletions(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 6cd1e6e1135b..c1af3bac2458 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -1648,6 +1648,16 @@ GetArchCommonNameSpaceObject (
PlatformRepo = This->PlatRepoInfo;
switch (GET_CM_OBJECT_ID (CmObjectId)) {
+ case EArchCommonObjPowerManagementProfileInfo:
+ Status = HandleCmObject (
+ CmObjectId,
+ &PlatformRepo->PmProfileInfo,
+ sizeof (PlatformRepo->PmProfileInfo),
+ 1,
+ CmObject
+ );
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -1707,15 +1717,6 @@ GetArmNameSpaceObject (
CmObject
);
break;
- case EArmObjPowerManagementProfileInfo:
- Status = HandleCmObject (
- CmObjectId,
- &PlatformRepo->PmProfileInfo,
- sizeof (PlatformRepo->PmProfileInfo),
- 1,
- CmObject
- );
- break;
case EArmObjGenericTimerInfo:
Status = HandleCmObject (
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index 78452295a180..034d945f18c5 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -227,7 +227,7 @@ typedef struct PlatformRepositoryInfo {
CM_ARM_BOOT_ARCH_INFO BootArchInfo;
/// Power management profile information
- CM_ARM_POWER_MANAGEMENT_PROFILE_INFO PmProfileInfo;
+ CM_ARCH_COMMON_POWER_MANAGEMENT_PROFILE_INFO PmProfileInfo;
/// GIC CPU interface information
CM_ARM_GICC_INFO GicCInfo[PLAT_CPU_COUNT];
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index f145205c4da0..dd7b068a335b 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -765,6 +765,16 @@ GetArchCommonNameSpaceObject (
PlatformRepo = This->PlatRepoInfo;
switch (GET_CM_OBJECT_ID (CmObjectId)) {
+ case EArchCommonObjPowerManagementProfileInfo:
+ Status = HandleCmObject (
+ CmObjectId,
+ &PlatformRepo->PmProfileInfo,
+ sizeof (PlatformRepo->PmProfileInfo),
+ 1,
+ CmObject
+ );
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -859,15 +869,6 @@ GetArmNameSpaceObject (
);
break;
#endif
- case EArmObjPowerManagementProfileInfo:
- Status = HandleCmObject (
- CmObjectId,
- &PlatformRepo->PmProfileInfo,
- sizeof (PlatformRepo->PmProfileInfo),
- 1,
- CmObject
- );
- break;
case EArmObjGenericTimerInfo:
Status = HandleCmObject (
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index be2b512911f8..f4d26242c27c 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -118,7 +118,7 @@ typedef struct PlatformRepositoryInfo {
#endif
/// Power management profile information
- CM_ARM_POWER_MANAGEMENT_PROFILE_INFO PmProfileInfo;
+ CM_ARCH_COMMON_POWER_MANAGEMENT_PROFILE_INFO PmProfileInfo;
/// GIC CPU interface information
CM_ARM_GICC_INFO GicCInfo[PLAT_CPU_COUNT];
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117000): https://edk2.groups.io/g/devel/message/117000
Mute This Topic: https://groups.io/mt/105068400/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common
@ 2024-03-21 17:18 PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 01/14] Platform/ARM: FVP,Juno: Add Arch Common objects handler PierreGondois
` (14 more replies)
0 siblings, 15 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 17:18 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Resend this patch since 'more than 40 messages in 30 minutes' have been
sent and the mailing list blocked/rejected some patches.
Following [1] and [2], other architectures than Arm aim to leverage
the DynamicTablesPkg. The package uses namespaces/domains to split
objects IDs. Currently most of the objects are part of the Arm
namespace. Some objects are generic enough to be re-used by other
architectures.
[3] and [4] moved the objects that could be re-used to an Arch Common
namespace. Update the following platforms which use the DynamicTablesPkg
framework/objects:
- Juno
- VExpress
The following platforms were not updated yet:
- Platform/ARM/N1Sdp
- Platform/ARM/Morello
- Platform/NXP/ConfigurationManagerPkg
A branch holding the whole patchset is available at:
- https://github.com/pierregondois/edk2-platforms/tree/pg/arch_common_obj_sent
[1] Branch to reorg Dynamic Tables & support other arch
https://edk2.groups.io/g/devel/topic/104054584#116308
[2] DynamicTablesPkg: Arch Common Namespace
https://edk2.groups.io/g/devel/message/116330
[3] https://edk2.groups.io/g/devel/message/116961 (first part)
[4] https://edk2.groups.io/g/devel/message/116978 (second part)
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Pierre Gondois (14):
Platform/ARM: FVP,Juno: Add Arch Common objects handler
Platform/ARM: FVP,Juno: Move Power Mgmt Profile info to Arch Common
Platform/ARM: FVP,Juno:: Move Serial Port info to Arch Common
Platform/ARM: FVP: Move Fixed Feat Flags info to Arch Common
Platform/ARM: Juno: Move CmRef info to Arch Common
Platform/ARM: FVP,Juno: Move Pci Config Space info to Arch Common
Platform/ARM: Juno: Move Pci Address Map info to Arch Common
Platform/ARM: Juno: Move Pci Interrupt Map info to Arch Common
Platform/ARM: Juno: Move Lpi info to Arch Common
Platform/ARM: Juno: Rename GicCToken
Platform/ARM: Juno: Move Proc Hierarchy info to Arch Common
Platform/ARM: Juno: Move Cache info to Arch Common
Platform/ARM: Juno: Move Cpc info to Arch Common
Platform/ARM: Juno: Move Psd info to Arch Common
.../ConfigurationManager.c | 363 ++++++++++--------
.../ConfigurationManager.h | 38 +-
.../ConfigurationManager.c | 169 +++++---
.../ConfigurationManager.h | 10 +-
4 files changed, 348 insertions(+), 232 deletions(-)
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117001): https://edk2.groups.io/g/devel/message/117001
Mute This Topic: https://groups.io/mt/105069934/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 18+ messages in thread
* [edk2-devel] [PATCH 01/14] Platform/ARM: FVP,Juno: Add Arch Common objects handler
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
@ 2024-03-21 17:18 ` PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 02/14] Platform/ARM: FVP,Juno: Move Power Mgmt Profile info to Arch Common PierreGondois
` (13 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 17:18 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Prepare the handling of these objects
in the ConfigurationManagers by adding a function handler for these
objects.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
- FVP
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
.../ConfigurationManager.c | 56 ++++++++++++++++++-
.../ConfigurationManager.c | 55 +++++++++++++++++-
2 files changed, 109 insertions(+), 2 deletions(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 26d9da25065a..6cd1e6e1135b 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -1,7 +1,7 @@
/** @file
Configuration Manager Dxe
- Copyright (c) 2017 - 2023, Arm Limited. All rights reserved.<BR>
+ Copyright (c) 2017 - 2024, Arm Limited. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -1612,6 +1612,57 @@ GetStandardNameSpaceObject (
return Status;
}
+
+/** Return an Arch Common namespace object.
+
+ @param [in] This Pointer to the Configuration Manager Protocol.
+ @param [in] CmObjectId The Configuration Manager Object ID.
+ @param [in] Token An optional token identifying the object. If
+ unused this must be CM_NULL_TOKEN.
+ @param [in, out] CmObject Pointer to the Configuration Manager Object
+ descriptor describing the requested Object.
+
+ @retval EFI_SUCCESS Success.
+ @retval EFI_INVALID_PARAMETER A parameter is invalid.
+ @retval EFI_NOT_FOUND The required object information is not found.
+**/
+EFI_STATUS
+EFIAPI
+GetArchCommonNameSpaceObject (
+ IN CONST EDKII_CONFIGURATION_MANAGER_PROTOCOL * CONST This,
+ IN CONST CM_OBJECT_ID CmObjectId,
+ IN CONST CM_OBJECT_TOKEN Token OPTIONAL,
+ IN OUT CM_OBJ_DESCRIPTOR * CONST CmObject
+ )
+{
+ EFI_STATUS Status;
+ EDKII_PLATFORM_REPOSITORY_INFO * PlatformRepo;
+
+ if ((This == NULL) || (CmObject == NULL)) {
+ ASSERT (This != NULL);
+ ASSERT (CmObject != NULL);
+ return EFI_INVALID_PARAMETER;
+ }
+
+ Status = EFI_NOT_FOUND;
+ PlatformRepo = This->PlatRepoInfo;
+
+ switch (GET_CM_OBJECT_ID (CmObjectId)) {
+ default: {
+ Status = EFI_NOT_FOUND;
+ DEBUG ((
+ DEBUG_INFO,
+ "INFO: Object 0x%x. Status = %r\n",
+ CmObjectId,
+ Status
+ ));
+ break;
+ }
+ } //switch
+
+ return Status;
+}
+
/** Return an ARM namespace object.
@param [in] This Pointer to the Configuration Manager Protocol.
@@ -1980,6 +2031,9 @@ ArmJunoPlatformGetObject (
case EObjNameSpaceStandard:
Status = GetStandardNameSpaceObject (This, CmObjectId, Token, CmObject);
break;
+ case EObjNameSpaceArchCommon:
+ Status = GetArchCommonNameSpaceObject (This, CmObjectId, Token, CmObject);
+ break;
case EObjNameSpaceArm:
Status = GetArmNameSpaceObject (This, CmObjectId, Token, CmObject);
break;
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 5b5d1f9d04c0..f145205c4da0 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -1,7 +1,7 @@
/** @file
Configuration Manager Dxe
- Copyright (c) 2017 - 2023, Arm Limited. All rights reserved.<BR>
+ Copyright (c) 2017 - 2024, Arm Limited. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -730,6 +730,56 @@ GetStandardNameSpaceObject (
return Status;
}
+/** Return an Arch Common namespace object.
+
+ @param [in] This Pointer to the Configuration Manager Protocol.
+ @param [in] CmObjectId The Configuration Manager Object ID.
+ @param [in] Token An optional token identifying the object. If
+ unused this must be CM_NULL_TOKEN.
+ @param [in, out] CmObject Pointer to the Configuration Manager Object
+ descriptor describing the requested Object.
+
+ @retval EFI_SUCCESS Success.
+ @retval EFI_INVALID_PARAMETER A parameter is invalid.
+ @retval EFI_NOT_FOUND The required object information is not found.
+**/
+EFI_STATUS
+EFIAPI
+GetArchCommonNameSpaceObject (
+ IN CONST EDKII_CONFIGURATION_MANAGER_PROTOCOL * CONST This,
+ IN CONST CM_OBJECT_ID CmObjectId,
+ IN CONST CM_OBJECT_TOKEN Token OPTIONAL,
+ IN OUT CM_OBJ_DESCRIPTOR * CONST CmObject
+ )
+{
+ EFI_STATUS Status;
+ EDKII_PLATFORM_REPOSITORY_INFO * PlatformRepo;
+
+ if ((This == NULL) || (CmObject == NULL)) {
+ ASSERT (This != NULL);
+ ASSERT (CmObject != NULL);
+ return EFI_INVALID_PARAMETER;
+ }
+
+ Status = EFI_NOT_FOUND;
+ PlatformRepo = This->PlatRepoInfo;
+
+ switch (GET_CM_OBJECT_ID (CmObjectId)) {
+ default: {
+ Status = EFI_NOT_FOUND;
+ DEBUG ((
+ DEBUG_INFO,
+ "INFO: Object 0x%x. Status = %r\n",
+ CmObjectId,
+ Status
+ ));
+ break;
+ }
+ } //switch
+
+ return Status;
+}
+
/** Return an ARM namespace object.
@param [in] This Pointer to the Configuration Manager Protocol.
@@ -1101,6 +1151,9 @@ ArmVExpressPlatformGetObject (
case EObjNameSpaceStandard:
Status = GetStandardNameSpaceObject (This, CmObjectId, Token, CmObject);
break;
+ case EObjNameSpaceArchCommon:
+ Status = GetArchCommonNameSpaceObject (This, CmObjectId, Token, CmObject);
+ break;
case EObjNameSpaceArm:
Status = GetArmNameSpaceObject (This, CmObjectId, Token, CmObject);
break;
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117002): https://edk2.groups.io/g/devel/message/117002
Mute This Topic: https://groups.io/mt/105069936/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-devel] [PATCH 02/14] Platform/ARM: FVP,Juno: Move Power Mgmt Profile info to Arch Common
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 01/14] Platform/ARM: FVP,Juno: Add Arch Common objects handler PierreGondois
@ 2024-03-21 17:18 ` PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 03/14] Platform/ARM: FVP,Juno:: Move Serial Port " PierreGondois
` (12 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 17:18 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
- FVP
for the following Arch Common object Id:
- EArchCommonObjPowerManagementProfileInfo
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
.../ConfigurationManager.c | 19 ++++++++++---------
.../ConfigurationManager.h | 2 +-
.../ConfigurationManager.c | 19 ++++++++++---------
.../ConfigurationManager.h | 2 +-
4 files changed, 22 insertions(+), 20 deletions(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 6cd1e6e1135b..c1af3bac2458 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -1648,6 +1648,16 @@ GetArchCommonNameSpaceObject (
PlatformRepo = This->PlatRepoInfo;
switch (GET_CM_OBJECT_ID (CmObjectId)) {
+ case EArchCommonObjPowerManagementProfileInfo:
+ Status = HandleCmObject (
+ CmObjectId,
+ &PlatformRepo->PmProfileInfo,
+ sizeof (PlatformRepo->PmProfileInfo),
+ 1,
+ CmObject
+ );
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -1707,15 +1717,6 @@ GetArmNameSpaceObject (
CmObject
);
break;
- case EArmObjPowerManagementProfileInfo:
- Status = HandleCmObject (
- CmObjectId,
- &PlatformRepo->PmProfileInfo,
- sizeof (PlatformRepo->PmProfileInfo),
- 1,
- CmObject
- );
- break;
case EArmObjGenericTimerInfo:
Status = HandleCmObject (
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index 78452295a180..034d945f18c5 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -227,7 +227,7 @@ typedef struct PlatformRepositoryInfo {
CM_ARM_BOOT_ARCH_INFO BootArchInfo;
/// Power management profile information
- CM_ARM_POWER_MANAGEMENT_PROFILE_INFO PmProfileInfo;
+ CM_ARCH_COMMON_POWER_MANAGEMENT_PROFILE_INFO PmProfileInfo;
/// GIC CPU interface information
CM_ARM_GICC_INFO GicCInfo[PLAT_CPU_COUNT];
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index f145205c4da0..dd7b068a335b 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -765,6 +765,16 @@ GetArchCommonNameSpaceObject (
PlatformRepo = This->PlatRepoInfo;
switch (GET_CM_OBJECT_ID (CmObjectId)) {
+ case EArchCommonObjPowerManagementProfileInfo:
+ Status = HandleCmObject (
+ CmObjectId,
+ &PlatformRepo->PmProfileInfo,
+ sizeof (PlatformRepo->PmProfileInfo),
+ 1,
+ CmObject
+ );
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -859,15 +869,6 @@ GetArmNameSpaceObject (
);
break;
#endif
- case EArmObjPowerManagementProfileInfo:
- Status = HandleCmObject (
- CmObjectId,
- &PlatformRepo->PmProfileInfo,
- sizeof (PlatformRepo->PmProfileInfo),
- 1,
- CmObject
- );
- break;
case EArmObjGenericTimerInfo:
Status = HandleCmObject (
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index be2b512911f8..f4d26242c27c 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -118,7 +118,7 @@ typedef struct PlatformRepositoryInfo {
#endif
/// Power management profile information
- CM_ARM_POWER_MANAGEMENT_PROFILE_INFO PmProfileInfo;
+ CM_ARCH_COMMON_POWER_MANAGEMENT_PROFILE_INFO PmProfileInfo;
/// GIC CPU interface information
CM_ARM_GICC_INFO GicCInfo[PLAT_CPU_COUNT];
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117003): https://edk2.groups.io/g/devel/message/117003
Mute This Topic: https://groups.io/mt/105069937/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-devel] [PATCH 03/14] Platform/ARM: FVP,Juno:: Move Serial Port info to Arch Common
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 01/14] Platform/ARM: FVP,Juno: Add Arch Common objects handler PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 02/14] Platform/ARM: FVP,Juno: Move Power Mgmt Profile info to Arch Common PierreGondois
@ 2024-03-21 17:18 ` PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 04/14] Platform/ARM: FVP: Move Fixed Feat Flags " PierreGondois
` (11 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 17:18 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
- FVP
for the following Arch Common object Id:
- EArchCommonObjConsolePortInfo
- EArchCommonObjSerialDebugPortInfo
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
.../ConfigurationManager.c | 38 +++++++++---------
.../ConfigurationManager.h | 4 +-
.../ConfigurationManager.c | 40 +++++++++----------
.../ConfigurationManager.h | 4 +-
4 files changed, 44 insertions(+), 42 deletions(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index c1af3bac2458..813e420a4740 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -1658,6 +1658,26 @@ GetArchCommonNameSpaceObject (
);
break;
+ case EArchCommonObjConsolePortInfo:
+ Status = HandleCmObject (
+ CmObjectId,
+ &PlatformRepo->SpcrSerialPort,
+ sizeof (PlatformRepo->SpcrSerialPort),
+ 1,
+ CmObject
+ );
+ break;
+
+ case EArchCommonObjSerialDebugPortInfo:
+ Status = HandleCmObject (
+ CmObjectId,
+ &PlatformRepo->DbgSerialPort,
+ sizeof (PlatformRepo->DbgSerialPort),
+ 1,
+ CmObject
+ );
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -1795,25 +1815,7 @@ GetArmNameSpaceObject (
CmObject
);
break;
- case EArmObjSerialConsolePortInfo:
- Status = HandleCmObject (
- CmObjectId,
- &PlatformRepo->SpcrSerialPort,
- sizeof (PlatformRepo->SpcrSerialPort),
- 1,
- CmObject
- );
- break;
- case EArmObjSerialDebugPortInfo:
- Status = HandleCmObject (
- CmObjectId,
- &PlatformRepo->DbgSerialPort,
- sizeof (PlatformRepo->DbgSerialPort),
- 1,
- CmObject
- );
- break;
case EArmObjGicMsiFrameInfo:
Status = HandleCmObject (
CmObjectId,
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index 034d945f18c5..72b035e1421f 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -250,10 +250,10 @@ typedef struct PlatformRepositoryInfo {
/** Serial port information for the
serial port console redirection port
*/
- CM_ARM_SERIAL_PORT_INFO SpcrSerialPort;
+ CM_ARCH_COMMON_SERIAL_PORT_INFO SpcrSerialPort;
/// Serial port information for the DBG2 UART port
- CM_ARM_SERIAL_PORT_INFO DbgSerialPort;
+ CM_ARCH_COMMON_SERIAL_PORT_INFO DbgSerialPort;
/// PCI configuration space information
CM_ARM_PCI_CONFIG_SPACE_INFO PciConfigInfo;
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index dd7b068a335b..397de8a365dc 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -775,6 +775,26 @@ GetArchCommonNameSpaceObject (
);
break;
+ case EArchCommonObjConsolePortInfo:
+ Status = HandleCmObject (
+ CmObjectId,
+ &PlatformRepo->SpcrSerialPort,
+ sizeof (PlatformRepo->SpcrSerialPort),
+ 1,
+ CmObject
+ );
+ break;
+
+ case EArchCommonObjSerialDebugPortInfo:
+ Status = HandleCmObject (
+ CmObjectId,
+ &PlatformRepo->DbgSerialPort,
+ sizeof (PlatformRepo->DbgSerialPort),
+ 1,
+ CmObject
+ );
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -943,26 +963,6 @@ GetArmNameSpaceObject (
);
break;
- case EArmObjSerialConsolePortInfo:
- Status = HandleCmObject (
- CmObjectId,
- &PlatformRepo->SpcrSerialPort,
- sizeof (PlatformRepo->SpcrSerialPort),
- 1,
- CmObject
- );
- break;
-
- case EArmObjSerialDebugPortInfo:
- Status = HandleCmObject (
- CmObjectId,
- &PlatformRepo->DbgSerialPort,
- sizeof (PlatformRepo->DbgSerialPort),
- 1,
- CmObject
- );
- break;
-
case EArmObjGicItsInfo:
Status = HandleCmObject (
CmObjectId,
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index f4d26242c27c..ae7df98824d9 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -144,10 +144,10 @@ typedef struct PlatformRepositoryInfo {
/** Serial port information for the
serial port console redirection port
*/
- CM_ARM_SERIAL_PORT_INFO SpcrSerialPort;
+ CM_ARCH_COMMON_SERIAL_PORT_INFO SpcrSerialPort;
/// Serial port information for the DBG2 UART port
- CM_ARM_SERIAL_PORT_INFO DbgSerialPort;
+ CM_ARCH_COMMON_SERIAL_PORT_INFO DbgSerialPort;
/// GIC ITS information
CM_ARM_GIC_ITS_INFO GicItsInfo;
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117004): https://edk2.groups.io/g/devel/message/117004
Mute This Topic: https://groups.io/mt/105069938/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-devel] [PATCH 04/14] Platform/ARM: FVP: Move Fixed Feat Flags info to Arch Common
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
` (2 preceding siblings ...)
2024-03-21 17:18 ` [edk2-devel] [PATCH 03/14] Platform/ARM: FVP,Juno:: Move Serial Port " PierreGondois
@ 2024-03-21 17:18 ` PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 05/14] Platform/ARM: Juno: Move CmRef " PierreGondois
` (10 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 17:18 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- FVP
for the following Arch Common object Id:
- EArchCommonObjFixedFeatureFlags
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
.../ConfigurationManager.c | 24 +++++++++----------
.../ConfigurationManager.h | 2 +-
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 397de8a365dc..0fb3e99d2ab1 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -795,6 +795,18 @@ GetArchCommonNameSpaceObject (
);
break;
+#ifdef HEADLESS_PLATFORM
+ case EArchCommonObjFixedFeatureFlags:
+ Status = HandleCmObject (
+ CmObjectId,
+ &PlatformRepo->FixedFeatureFlags,
+ sizeof (PlatformRepo->FixedFeatureFlags),
+ 1,
+ CmObject
+ );
+ break;
+#endif
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -878,18 +890,6 @@ GetArmNameSpaceObject (
);
break;
-#ifdef HEADLESS_PLATFORM
- case EArmObjFixedFeatureFlags:
- Status = HandleCmObject (
- CmObjectId,
- &PlatformRepo->FixedFeatureFlags,
- sizeof (PlatformRepo->FixedFeatureFlags),
- 1,
- CmObject
- );
- break;
-#endif
-
case EArmObjGenericTimerInfo:
Status = HandleCmObject (
CmObjectId,
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index ae7df98824d9..ad71e8ef5376 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -114,7 +114,7 @@ typedef struct PlatformRepositoryInfo {
#ifdef HEADLESS_PLATFORM
/// Fixed feature flag information
- CM_ARM_FIXED_FEATURE_FLAGS FixedFeatureFlags;
+ CM_ARCH_COMMON_FIXED_FEATURE_FLAGS FixedFeatureFlags;
#endif
/// Power management profile information
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117005): https://edk2.groups.io/g/devel/message/117005
Mute This Topic: https://groups.io/mt/105069939/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-devel] [PATCH 05/14] Platform/ARM: Juno: Move CmRef info to Arch Common
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
` (3 preceding siblings ...)
2024-03-21 17:18 ` [edk2-devel] [PATCH 04/14] Platform/ARM: FVP: Move Fixed Feat Flags " PierreGondois
@ 2024-03-21 17:18 ` PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 06/14] Platform/ARM: FVP,Juno: Move Pci Config Space " PierreGondois
` (9 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 17:18 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
- EArchCommonObjCmRef
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
.../ConfigurationManager.c | 22 +++++++++----------
.../ConfigurationManager.h | 16 +++++++-------
2 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 813e420a4740..65506f0514a8 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -1454,7 +1454,7 @@ GetCpcInfo (
@param [in] This Pointer to the Configuration Manager Protocol.
@param [in] CmObjectId The Object ID of the CM object requested
@param [in] SearchToken A unique token for identifying the requested
- CM_ARM_OBJ_REF list.
+ CM_ARCH_COMMON_OBJ_REF list.
@param [in, out] CmObject Pointer to the Configuration Manager Object
descriptor describing the requested Object.
@@ -1678,6 +1678,16 @@ GetArchCommonNameSpaceObject (
);
break;
+ case EArchCommonObjCmRef:
+ Status = HandleCmObjectSearchPlatformRepo (
+ This,
+ CmObjectId,
+ Token,
+ GetCmObjRefs,
+ CmObject
+ );
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -1846,16 +1856,6 @@ GetArmNameSpaceObject (
);
break;
- case EArmObjCmRef:
- Status = HandleCmObjectSearchPlatformRepo (
- This,
- CmObjectId,
- Token,
- GetCmObjRefs,
- CmObject
- );
- break;
-
case EArmObjPciConfigSpaceInfo:
if (PlatformRepo->JunoRevision != JUNO_REVISION_R0) {
Status = HandleCmObject (
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index 72b035e1421f..e3a50edcc0b3 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -259,13 +259,13 @@ typedef struct PlatformRepositoryInfo {
CM_ARM_PCI_CONFIG_SPACE_INFO PciConfigInfo;
// PCI address-range mapping references
- CM_ARM_OBJ_REF PciAddressMapRef[PCI_ADDRESS_MAP_COUNT];
+ CM_ARCH_COMMON_OBJ_REF PciAddressMapRef[PCI_ADDRESS_MAP_COUNT];
// PCI address-range mapping information
CM_ARM_PCI_ADDRESS_MAP_INFO PciAddressMapInfo[PCI_ADDRESS_MAP_COUNT];
// PCI device legacy interrupts mapping references
- CM_ARM_OBJ_REF PciInterruptMapRef[PCI_INTERRUPT_MAP_COUNT];
+ CM_ARCH_COMMON_OBJ_REF PciInterruptMapRef[PCI_INTERRUPT_MAP_COUNT];
// PCI device legacy interrupts mapping information
CM_ARM_PCI_INTERRUPT_MAP_INFO PciInterruptMapInfo[PCI_INTERRUPT_MAP_COUNT];
@@ -280,25 +280,25 @@ typedef struct PlatformRepositoryInfo {
CM_ARM_CACHE_INFO CacheInfo[PLAT_CACHE_COUNT];
// 'big' cluster private resources
- CM_ARM_OBJ_REF BigClusterResources[BIG_CLUSTER_RESOURCE_COUNT];
+ CM_ARCH_COMMON_OBJ_REF BigClusterResources[BIG_CLUSTER_RESOURCE_COUNT];
// 'big' core private resources
- CM_ARM_OBJ_REF BigCoreResources[BIG_CORE_RESOURCE_COUNT];
+ CM_ARCH_COMMON_OBJ_REF BigCoreResources[BIG_CORE_RESOURCE_COUNT];
// 'LITTLE' cluster private resources
- CM_ARM_OBJ_REF LittleClusterResources[LITTLE_CLUSTER_RESOURCE_COUNT];
+ CM_ARCH_COMMON_OBJ_REF LittleClusterResources[LITTLE_CLUSTER_RESOURCE_COUNT];
// 'LITTLE' core private resources
- CM_ARM_OBJ_REF LittleCoreResources[LITTLE_CORE_RESOURCE_COUNT];
+ CM_ARCH_COMMON_OBJ_REF LittleCoreResources[LITTLE_CORE_RESOURCE_COUNT];
// Low Power Idle state information (LPI) for all cores/clusters
CM_ARM_LPI_INFO LpiInfo[LPI_STATE_COUNT];
// Clusters Low Power Idle state references (LPI)
- CM_ARM_OBJ_REF ClustersLpiRef[CLUSTERS_LPI_STATE_COUNT];
+ CM_ARCH_COMMON_OBJ_REF ClustersLpiRef[CLUSTERS_LPI_STATE_COUNT];
// Cores Low Power Idle state references (LPI)
- CM_ARM_OBJ_REF CoresLpiRef[CORES_LPI_STATE_COUNT];
+ CM_ARCH_COMMON_OBJ_REF CoresLpiRef[CORES_LPI_STATE_COUNT];
// Power domains
CM_ARM_PSD_INFO PsdInfo[PSD_DOMAIN_COUNT];
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117006): https://edk2.groups.io/g/devel/message/117006
Mute This Topic: https://groups.io/mt/105069940/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-devel] [PATCH 06/14] Platform/ARM: FVP,Juno: Move Pci Config Space info to Arch Common
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
` (4 preceding siblings ...)
2024-03-21 17:18 ` [edk2-devel] [PATCH 05/14] Platform/ARM: Juno: Move CmRef " PierreGondois
@ 2024-03-21 17:18 ` PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 07/14] Platform/ARM: Juno: Move Pci Address Map " PierreGondois
` (8 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 17:18 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
- FVP
for the following Arch Common object Id:
- EArchCommonObjPciConfigSpaceInfo
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
.../ConfigurationManager.c | 30 +++++++++---------
.../ConfigurationManager.h | 2 +-
.../ConfigurationManager.c | 31 +++++++++++--------
.../ConfigurationManager.h | 2 +-
4 files changed, 35 insertions(+), 30 deletions(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 65506f0514a8..e33aa6578fd1 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -1688,6 +1688,21 @@ GetArchCommonNameSpaceObject (
);
break;
+ case EArchCommonObjPciConfigSpaceInfo:
+ if (PlatformRepo->JunoRevision != JUNO_REVISION_R0) {
+ Status = HandleCmObject (
+ CmObjectId,
+ &PlatformRepo->PciConfigInfo,
+ sizeof (PlatformRepo->PciConfigInfo),
+ 1,
+ CmObject
+ );
+ } else {
+ // No PCIe on Juno R0.
+ Status = EFI_NOT_FOUND;
+ }
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -1856,21 +1871,6 @@ GetArmNameSpaceObject (
);
break;
- case EArmObjPciConfigSpaceInfo:
- if (PlatformRepo->JunoRevision != JUNO_REVISION_R0) {
- Status = HandleCmObject (
- CmObjectId,
- &PlatformRepo->PciConfigInfo,
- sizeof (PlatformRepo->PciConfigInfo),
- 1,
- CmObject
- );
- } else {
- // No PCIe on Juno R0.
- Status = EFI_NOT_FOUND;
- }
- break;
-
case EArmObjLpiInfo:
Status = HandleCmObjectRefByToken (
This,
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index e3a50edcc0b3..8bd79ca387d4 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -256,7 +256,7 @@ typedef struct PlatformRepositoryInfo {
CM_ARCH_COMMON_SERIAL_PORT_INFO DbgSerialPort;
/// PCI configuration space information
- CM_ARM_PCI_CONFIG_SPACE_INFO PciConfigInfo;
+ CM_ARCH_COMMON_PCI_CONFIG_SPACE_INFO PciConfigInfo;
// PCI address-range mapping references
CM_ARCH_COMMON_OBJ_REF PciAddressMapRef[PCI_ADDRESS_MAP_COUNT];
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 0fb3e99d2ab1..fed1fdbd5a52 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -754,6 +754,7 @@ GetArchCommonNameSpaceObject (
{
EFI_STATUS Status;
EDKII_PLATFORM_REPOSITORY_INFO * PlatformRepo;
+ UINTN PciConfigSpaceCount;
if ((This == NULL) || (CmObject == NULL)) {
ASSERT (This != NULL);
@@ -764,6 +765,13 @@ GetArchCommonNameSpaceObject (
Status = EFI_NOT_FOUND;
PlatformRepo = This->PlatRepoInfo;
+ if ((PlatformRepo->SysId & ARM_FVP_SYS_ID_REV_MASK) ==
+ ARM_FVP_BASE_REVC_REV) {
+ PciConfigSpaceCount = 1;
+ } else {
+ PciConfigSpaceCount = 0;
+ }
+
switch (GET_CM_OBJECT_ID (CmObjectId)) {
case EArchCommonObjPowerManagementProfileInfo:
Status = HandleCmObject (
@@ -807,6 +815,16 @@ GetArchCommonNameSpaceObject (
break;
#endif
+ case EArchCommonObjPciConfigSpaceInfo:
+ Status = HandleCmObject (
+ CmObjectId,
+ &PlatformRepo->PciConfigInfo,
+ sizeof (PlatformRepo->PciConfigInfo),
+ PciConfigSpaceCount,
+ CmObject
+ );
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -851,7 +869,6 @@ GetArmNameSpaceObject (
UINTN ItsIdentifierArrayCount;
UINTN RootComplexCount;
UINTN DeviceIdMappingArrayCount;
- UINTN PciConfigSpaceCount;
if ((This == NULL) || (CmObject == NULL)) {
ASSERT (This != NULL);
@@ -869,14 +886,12 @@ GetArmNameSpaceObject (
ItsIdentifierArrayCount = ARRAY_SIZE (PlatformRepo->ItsIdentifierArray);
RootComplexCount = 1;
DeviceIdMappingArrayCount = ARRAY_SIZE (PlatformRepo->DeviceIdMapping);
- PciConfigSpaceCount = 1;
} else {
Smmuv3Count = 0;
ItsGroupCount = 0;
ItsIdentifierArrayCount = 0;
RootComplexCount = 0;
DeviceIdMappingArrayCount = 0;
- PciConfigSpaceCount = 0;
}
switch (GET_CM_OBJECT_ID (CmObjectId)) {
@@ -1029,16 +1044,6 @@ GetArmNameSpaceObject (
);
break;
- case EArmObjPciConfigSpaceInfo:
- Status = HandleCmObject (
- CmObjectId,
- &PlatformRepo->PciConfigInfo,
- sizeof (PlatformRepo->PciConfigInfo),
- PciConfigSpaceCount,
- CmObject
- );
- break;
-
case EArmObjEtInfo:
if (Token == (CM_OBJECT_TOKEN)&PlatformRepo->EtInfo) {
Status = HandleCmObject (
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index ad71e8ef5376..e251eed16425 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -169,7 +169,7 @@ typedef struct PlatformRepositoryInfo {
CM_ARM_ID_MAPPING DeviceIdMapping[2];
/// PCI configuration space information
- CM_ARM_PCI_CONFIG_SPACE_INFO PciConfigInfo;
+ CM_ARCH_COMMON_PCI_CONFIG_SPACE_INFO PciConfigInfo;
CM_ARM_ET_INFO EtInfo;
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117007): https://edk2.groups.io/g/devel/message/117007
Mute This Topic: https://groups.io/mt/105069941/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-devel] [PATCH 07/14] Platform/ARM: Juno: Move Pci Address Map info to Arch Common
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
` (5 preceding siblings ...)
2024-03-21 17:18 ` [edk2-devel] [PATCH 06/14] Platform/ARM: FVP,Juno: Move Pci Config Space " PierreGondois
@ 2024-03-21 17:18 ` PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 08/14] Platform/ARM: Juno: Move Pci Interrupt " PierreGondois
` (7 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 17:18 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
- EArchCommonObjPciAddressMapInfo
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
.../ConfigurationManager.c | 28 +++++++++----------
.../ConfigurationManager.h | 2 +-
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index e33aa6578fd1..8d3af29e9287 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -1257,7 +1257,7 @@ GetLpiInfo (
@param [in] This Pointer to the Configuration Manager Protocol.
@param [in] CmObjectId The Object ID of the CM object requested
@param [in] SearchToken A unique token for identifying the requested
- CM_ARM_PCI_ADDRESS_MAP_INFO object.
+ CM_ARCH_COMMON_PCI_ADDRESS_MAP_INFO object.
@param [in, out] CmObject Pointer to the Configuration Manager Object
descriptor describing the requested Object.
@@ -1703,6 +1703,19 @@ GetArchCommonNameSpaceObject (
}
break;
+ case EArchCommonObjPciAddressMapInfo:
+ Status = HandleCmObjectRefByToken (
+ This,
+ CmObjectId,
+ PlatformRepo->PciAddressMapInfo,
+ sizeof (PlatformRepo->PciAddressMapInfo),
+ ARRAY_SIZE (PlatformRepo->PciAddressMapInfo),
+ Token,
+ GetPciAddressMapInfo,
+ CmObject
+ );
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -1884,19 +1897,6 @@ GetArmNameSpaceObject (
);
break;
- case EArmObjPciAddressMapInfo:
- Status = HandleCmObjectRefByToken (
- This,
- CmObjectId,
- PlatformRepo->PciAddressMapInfo,
- sizeof (PlatformRepo->PciAddressMapInfo),
- ARRAY_SIZE (PlatformRepo->PciAddressMapInfo),
- Token,
- GetPciAddressMapInfo,
- CmObject
- );
- break;
-
case EArmObjPciInterruptMapInfo:
Status = HandleCmObjectRefByToken (
This,
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index 8bd79ca387d4..7a64095a235d 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -262,7 +262,7 @@ typedef struct PlatformRepositoryInfo {
CM_ARCH_COMMON_OBJ_REF PciAddressMapRef[PCI_ADDRESS_MAP_COUNT];
// PCI address-range mapping information
- CM_ARM_PCI_ADDRESS_MAP_INFO PciAddressMapInfo[PCI_ADDRESS_MAP_COUNT];
+ CM_ARCH_COMMON_PCI_ADDRESS_MAP_INFO PciAddressMapInfo[PCI_ADDRESS_MAP_COUNT];
// PCI device legacy interrupts mapping references
CM_ARCH_COMMON_OBJ_REF PciInterruptMapRef[PCI_INTERRUPT_MAP_COUNT];
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117008): https://edk2.groups.io/g/devel/message/117008
Mute This Topic: https://groups.io/mt/105069943/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-devel] [PATCH 08/14] Platform/ARM: Juno: Move Pci Interrupt Map info to Arch Common
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
` (6 preceding siblings ...)
2024-03-21 17:18 ` [edk2-devel] [PATCH 07/14] Platform/ARM: Juno: Move Pci Address Map " PierreGondois
@ 2024-03-21 17:18 ` PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 09/14] Platform/ARM: Juno: Move Lpi " PierreGondois
` (6 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 17:18 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
- EArchCommonObjPciInterruptMapInfo
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
.../ConfigurationManager.c | 28 +++++++++----------
.../ConfigurationManager.h | 2 +-
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 8d3af29e9287..f720d826813c 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -1306,7 +1306,7 @@ GetPciAddressMapInfo (
@param [in] This Pointer to the Configuration Manager Protocol.
@param [in] CmObjectId The Object ID of the CM object requested
@param [in] SearchToken A unique token for identifying the requested
- CM_ARM_PCI_INTERRUPT_MAP_INFO object.
+ CM_ARCH_COMMON_PCI_INTERRUPT_MAP_INFO object.
@param [in, out] CmObject Pointer to the Configuration Manager Object
descriptor describing the requested Object.
@@ -1716,6 +1716,19 @@ GetArchCommonNameSpaceObject (
);
break;
+ case EArchCommonObjPciInterruptMapInfo:
+ Status = HandleCmObjectRefByToken (
+ This,
+ CmObjectId,
+ PlatformRepo->PciInterruptMapInfo,
+ sizeof (PlatformRepo->PciInterruptMapInfo),
+ ARRAY_SIZE (PlatformRepo->PciInterruptMapInfo),
+ Token,
+ GetPciInterruptMapInfo,
+ CmObject
+ );
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -1897,19 +1910,6 @@ GetArmNameSpaceObject (
);
break;
- case EArmObjPciInterruptMapInfo:
- Status = HandleCmObjectRefByToken (
- This,
- CmObjectId,
- PlatformRepo->PciInterruptMapInfo,
- sizeof (PlatformRepo->PciInterruptMapInfo),
- ARRAY_SIZE (PlatformRepo->PciInterruptMapInfo),
- Token,
- GetPciInterruptMapInfo,
- CmObject
- );
- break;
-
case EArmObjPsdInfo:
Status = HandleCmObjectRefByToken (
This,
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index 7a64095a235d..c229c18209fe 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -268,7 +268,7 @@ typedef struct PlatformRepositoryInfo {
CM_ARCH_COMMON_OBJ_REF PciInterruptMapRef[PCI_INTERRUPT_MAP_COUNT];
// PCI device legacy interrupts mapping information
- CM_ARM_PCI_INTERRUPT_MAP_INFO PciInterruptMapInfo[PCI_INTERRUPT_MAP_COUNT];
+ CM_ARCH_COMMON_PCI_INTERRUPT_MAP_INFO PciInterruptMapInfo[PCI_INTERRUPT_MAP_COUNT];
/// GIC MSI Frame information
CM_ARM_GIC_MSI_FRAME_INFO GicMsiFrameInfo;
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117009): https://edk2.groups.io/g/devel/message/117009
Mute This Topic: https://groups.io/mt/105069944/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-devel] [PATCH 09/14] Platform/ARM: Juno: Move Lpi info to Arch Common
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
` (7 preceding siblings ...)
2024-03-21 17:18 ` [edk2-devel] [PATCH 08/14] Platform/ARM: Juno: Move Pci Interrupt " PierreGondois
@ 2024-03-21 17:18 ` PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 10/14] Platform/ARM: Juno: Rename GicCToken PierreGondois
` (5 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 17:18 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
- EArchCommonObjLpiInfo
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
.../ConfigurationManager.c | 28 +++++++++----------
.../ConfigurationManager.h | 2 +-
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index f720d826813c..a6ded5a38629 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -1207,7 +1207,7 @@ GetGicCInfo (
@param [in] This Pointer to the Configuration Manager Protocol.
@param [in] CmObjectId The Object ID of the CM object requested
@param [in] SearchToken A unique token for identifying the requested
- CM_ARM_LPI_INFO object.
+ CM_ARCH_COMMON_LPI_INFO object.
@param [in, out] CmObject Pointer to the Configuration Manager Object
descriptor describing the requested Object.
@@ -1729,6 +1729,19 @@ GetArchCommonNameSpaceObject (
);
break;
+ case EArchCommonObjLpiInfo:
+ Status = HandleCmObjectRefByToken (
+ This,
+ CmObjectId,
+ NULL,
+ 0,
+ 0,
+ Token,
+ GetLpiInfo,
+ CmObject
+ );
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -1897,19 +1910,6 @@ GetArmNameSpaceObject (
);
break;
- case EArmObjLpiInfo:
- Status = HandleCmObjectRefByToken (
- This,
- CmObjectId,
- NULL,
- 0,
- 0,
- Token,
- GetLpiInfo,
- CmObject
- );
- break;
-
case EArmObjPsdInfo:
Status = HandleCmObjectRefByToken (
This,
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index c229c18209fe..f34aa087aa31 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -292,7 +292,7 @@ typedef struct PlatformRepositoryInfo {
CM_ARCH_COMMON_OBJ_REF LittleCoreResources[LITTLE_CORE_RESOURCE_COUNT];
// Low Power Idle state information (LPI) for all cores/clusters
- CM_ARM_LPI_INFO LpiInfo[LPI_STATE_COUNT];
+ CM_ARCH_COMMON_LPI_INFO LpiInfo[LPI_STATE_COUNT];
// Clusters Low Power Idle state references (LPI)
CM_ARCH_COMMON_OBJ_REF ClustersLpiRef[CLUSTERS_LPI_STATE_COUNT];
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117010): https://edk2.groups.io/g/devel/message/117010
Mute This Topic: https://groups.io/mt/105069945/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-devel] [PATCH 10/14] Platform/ARM: Juno: Rename GicCToken
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
` (8 preceding siblings ...)
2024-03-21 17:18 ` [edk2-devel] [PATCH 09/14] Platform/ARM: Juno: Move Lpi " PierreGondois
@ 2024-03-21 17:18 ` PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 11/14] Platform/ARM: Juno: Move Proc Hierarchy info to Arch Common PierreGondois
` (4 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 17:18 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. The following field:
(struct CmArchCommonProcHierarchyInfo).GicCToken
was renamed to 'AcpiIdObjectToken'. Reflect this change in the
edk2-platforms repository.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
.../ConfigurationManager.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index a6ded5a38629..54c71c11e656 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -361,7 +361,7 @@ EDKII_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
),
// CM_OBJECT_TOKEN ParentToken
CM_NULL_TOKEN,
- // CM_OBJECT_TOKEN GicCToken
+ // CM_OBJECT_TOKEN AcpiIdObjectToken
CM_NULL_TOKEN,
// UINT32 NoOfPrivateResources
0,
@@ -384,7 +384,7 @@ EDKII_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
),
// CM_OBJECT_TOKEN ParentToken
REFERENCE_TOKEN (ProcHierarchyInfo[0]), // -> Package
- // CM_OBJECT_TOKEN GicCToken
+ // CM_OBJECT_TOKEN AcpiIdObjectToken
CM_NULL_TOKEN,
// UINT32 NoOfPrivateResources
BIG_CLUSTER_RESOURCE_COUNT,
@@ -407,7 +407,7 @@ EDKII_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
),
// CM_OBJECT_TOKEN ParentToken
REFERENCE_TOKEN (ProcHierarchyInfo[0]), // -> Package
- // CM_OBJECT_TOKEN GicCToken
+ // CM_OBJECT_TOKEN AcpiIdObjectToken
CM_NULL_TOKEN,
// UINT32 NoOfPrivateResources
LITTLE_CLUSTER_RESOURCE_COUNT,
@@ -430,7 +430,7 @@ EDKII_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
),
// CM_OBJECT_TOKEN ParentToken
REFERENCE_TOKEN (ProcHierarchyInfo[1]), // -> 'big' cluster
- // CM_OBJECT_TOKEN GicCToken
+ // CM_OBJECT_TOKEN AcpiIdObjectToken
REFERENCE_TOKEN (GicCInfo[0]),
// UINT32 NoOfPrivateResources
BIG_CORE_RESOURCE_COUNT,
@@ -452,7 +452,7 @@ EDKII_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
),
// CM_OBJECT_TOKEN ParentToken
REFERENCE_TOKEN (ProcHierarchyInfo[1]), // -> 'big' cluster
- // CM_OBJECT_TOKEN GicCToken
+ // CM_OBJECT_TOKEN AcpiIdObjectToken
REFERENCE_TOKEN (GicCInfo[1]),
// UINT32 NoOfPrivateResources
BIG_CORE_RESOURCE_COUNT,
@@ -475,7 +475,7 @@ EDKII_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
),
// CM_OBJECT_TOKEN ParentToken
REFERENCE_TOKEN (ProcHierarchyInfo[2]), // -> 'LITTLE' cluster
- // CM_OBJECT_TOKEN GicCToken
+ // CM_OBJECT_TOKEN AcpiIdObjectToken
REFERENCE_TOKEN (GicCInfo[2]),
// UINT32 NoOfPrivateResources
LITTLE_CORE_RESOURCE_COUNT,
@@ -497,7 +497,7 @@ EDKII_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
),
// CM_OBJECT_TOKEN ParentToken
REFERENCE_TOKEN (ProcHierarchyInfo[2]), // -> 'LITTLE' cluster
- // CM_OBJECT_TOKEN GicCToken
+ // CM_OBJECT_TOKEN AcpiIdObjectToken
REFERENCE_TOKEN (GicCInfo[3]),
// UINT32 NoOfPrivateResources
LITTLE_CORE_RESOURCE_COUNT,
@@ -519,7 +519,7 @@ EDKII_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
),
// CM_OBJECT_TOKEN ParentToken
REFERENCE_TOKEN (ProcHierarchyInfo[2]), // -> 'LITTLE' cluster
- // CM_OBJECT_TOKEN GicCToken
+ // CM_OBJECT_TOKEN AcpiIdObjectToken
REFERENCE_TOKEN (GicCInfo[4]),
// UINT32 NoOfPrivateResources
LITTLE_CORE_RESOURCE_COUNT,
@@ -541,7 +541,7 @@ EDKII_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
),
// CM_OBJECT_TOKEN ParentToken
REFERENCE_TOKEN (ProcHierarchyInfo[2]), // -> 'LITTLE' cluster
- // CM_OBJECT_TOKEN GicCToken
+ // CM_OBJECT_TOKEN AcpiIdObjectToken
REFERENCE_TOKEN (GicCInfo[5]),
// UINT32 NoOfPrivateResources
LITTLE_CORE_RESOURCE_COUNT,
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117011): https://edk2.groups.io/g/devel/message/117011
Mute This Topic: https://groups.io/mt/105069946/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-devel] [PATCH 11/14] Platform/ARM: Juno: Move Proc Hierarchy info to Arch Common
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
` (9 preceding siblings ...)
2024-03-21 17:18 ` [edk2-devel] [PATCH 10/14] Platform/ARM: Juno: Rename GicCToken PierreGondois
@ 2024-03-21 17:18 ` PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 12/14] Platform/ARM: Juno: Move Cache " PierreGondois
` (3 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 17:18 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
- EArchCommonObjProcHierarchyInfo
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
.../ConfigurationManager.c | 20 +++++++++----------
.../ConfigurationManager.h | 2 +-
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 54c71c11e656..fbcbe97bf02e 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -1742,6 +1742,16 @@ GetArchCommonNameSpaceObject (
);
break;
+ case EArchCommonObjProcHierarchyInfo:
+ Status = HandleCmObject (
+ CmObjectId,
+ PlatformRepo->ProcHierarchyInfo,
+ sizeof (PlatformRepo->ProcHierarchyInfo),
+ ARRAY_SIZE (PlatformRepo->ProcHierarchyInfo),
+ CmObject
+ );
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -1890,16 +1900,6 @@ GetArmNameSpaceObject (
);
break;
- case EArmObjProcHierarchyInfo:
- Status = HandleCmObject (
- CmObjectId,
- PlatformRepo->ProcHierarchyInfo,
- sizeof (PlatformRepo->ProcHierarchyInfo),
- ARRAY_SIZE (PlatformRepo->ProcHierarchyInfo),
- CmObject
- );
- break;
-
case EArmObjCacheInfo:
Status = HandleCmObject (
CmObjectId,
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index f34aa087aa31..8517eae3f8da 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -274,7 +274,7 @@ typedef struct PlatformRepositoryInfo {
CM_ARM_GIC_MSI_FRAME_INFO GicMsiFrameInfo;
// Processor topology information
- CM_ARM_PROC_HIERARCHY_INFO ProcHierarchyInfo[PLAT_PROC_HIERARCHY_NODE_COUNT];
+ CM_ARCH_COMMON_PROC_HIERARCHY_INFO ProcHierarchyInfo[PLAT_PROC_HIERARCHY_NODE_COUNT];
// Cache information
CM_ARM_CACHE_INFO CacheInfo[PLAT_CACHE_COUNT];
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117012): https://edk2.groups.io/g/devel/message/117012
Mute This Topic: https://groups.io/mt/105069947/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-devel] [PATCH 12/14] Platform/ARM: Juno: Move Cache info to Arch Common
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
` (10 preceding siblings ...)
2024-03-21 17:18 ` [edk2-devel] [PATCH 11/14] Platform/ARM: Juno: Move Proc Hierarchy info to Arch Common PierreGondois
@ 2024-03-21 17:18 ` PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 13/14] Platform/ARM: Juno: Move Cpc " PierreGondois
` (2 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 17:18 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
- EArchCommonObjCacheInfo
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
.../ConfigurationManager.c | 20 +++++++++----------
.../ConfigurationManager.h | 2 +-
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index fbcbe97bf02e..0ccd110eab71 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -1752,6 +1752,16 @@ GetArchCommonNameSpaceObject (
);
break;
+ case EArchCommonObjCacheInfo:
+ Status = HandleCmObject (
+ CmObjectId,
+ PlatformRepo->CacheInfo,
+ sizeof (PlatformRepo->CacheInfo),
+ ARRAY_SIZE (PlatformRepo->CacheInfo),
+ CmObject
+ );
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -1900,16 +1910,6 @@ GetArmNameSpaceObject (
);
break;
- case EArmObjCacheInfo:
- Status = HandleCmObject (
- CmObjectId,
- PlatformRepo->CacheInfo,
- sizeof (PlatformRepo->CacheInfo),
- ARRAY_SIZE (PlatformRepo->CacheInfo),
- CmObject
- );
- break;
-
case EArmObjPsdInfo:
Status = HandleCmObjectRefByToken (
This,
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index 8517eae3f8da..a3833809779d 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -277,7 +277,7 @@ typedef struct PlatformRepositoryInfo {
CM_ARCH_COMMON_PROC_HIERARCHY_INFO ProcHierarchyInfo[PLAT_PROC_HIERARCHY_NODE_COUNT];
// Cache information
- CM_ARM_CACHE_INFO CacheInfo[PLAT_CACHE_COUNT];
+ CM_ARCH_COMMON_CACHE_INFO CacheInfo[PLAT_CACHE_COUNT];
// 'big' cluster private resources
CM_ARCH_COMMON_OBJ_REF BigClusterResources[BIG_CLUSTER_RESOURCE_COUNT];
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117013): https://edk2.groups.io/g/devel/message/117013
Mute This Topic: https://groups.io/mt/105069948/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-devel] [PATCH 13/14] Platform/ARM: Juno: Move Cpc info to Arch Common
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
` (11 preceding siblings ...)
2024-03-21 17:18 ` [edk2-devel] [PATCH 12/14] Platform/ARM: Juno: Move Cache " PierreGondois
@ 2024-03-21 17:18 ` PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 14/14] Platform/ARM: Juno: Move Psd " PierreGondois
2024-06-07 14:06 ` [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj " Sami Mujawar
14 siblings, 0 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 17:18 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
- EArchCommonObjCpcInfo
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
.../ConfigurationManager.c | 28 +++++++++----------
.../ConfigurationManager.h | 2 +-
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 0ccd110eab71..c63b8bc68d3f 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -1404,7 +1404,7 @@ GetPsdInfo (
@param [in] This Pointer to the Configuration Manager Protocol.
@param [in] CmObjectId The Object ID of the CM object requested
@param [in] SearchToken A unique token for identifying the requested
- CM_ARM_PCI_INTERRUPT_MAP_INFO object.
+ CM_ARCH_COMMON_CPC_INFO object.
@param [in, out] CmObject Pointer to the Configuration Manager Object
descriptor describing the requested Object.
@@ -1762,6 +1762,19 @@ GetArchCommonNameSpaceObject (
);
break;
+ case EArchCommonObjCpcInfo:
+ Status = HandleCmObjectRefByToken (
+ This,
+ CmObjectId,
+ PlatformRepo->CpcInfo,
+ sizeof (PlatformRepo->CpcInfo),
+ ARRAY_SIZE (PlatformRepo->CpcInfo),
+ Token,
+ GetCpcInfo,
+ CmObject
+ );
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -1923,19 +1936,6 @@ GetArmNameSpaceObject (
);
break;
- case EArmObjCpcInfo:
- Status = HandleCmObjectRefByToken (
- This,
- CmObjectId,
- PlatformRepo->CpcInfo,
- sizeof (PlatformRepo->CpcInfo),
- ARRAY_SIZE (PlatformRepo->CpcInfo),
- Token,
- GetCpcInfo,
- CmObject
- );
- break;
-
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index a3833809779d..9a12a7807d1c 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -308,7 +308,7 @@ typedef struct PlatformRepositoryInfo {
//
// Cpc info (1 for each PSD domain)
- CM_ARM_CPC_INFO CpcInfo[PSD_DOMAIN_COUNT];
+ CM_ARCH_COMMON_CPC_INFO CpcInfo[PSD_DOMAIN_COUNT];
/// Juno Board Revision
UINT32 JunoRevision;
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117014): https://edk2.groups.io/g/devel/message/117014
Mute This Topic: https://groups.io/mt/105069949/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-devel] [PATCH 14/14] Platform/ARM: Juno: Move Psd info to Arch Common
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
` (12 preceding siblings ...)
2024-03-21 17:18 ` [edk2-devel] [PATCH 13/14] Platform/ARM: Juno: Move Cpc " PierreGondois
@ 2024-03-21 17:18 ` PierreGondois
2024-06-07 14:06 ` [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj " Sami Mujawar
14 siblings, 0 replies; 18+ messages in thread
From: PierreGondois @ 2024-03-21 17:18 UTC (permalink / raw)
To: devel
Cc: Pierre Gondois, Sami Mujawar, Pierre Gondois, Yeo Reum Yun,
Sunil V L, AbdulLateef Attar, Jeshua Smith, Jeff Brasen,
Girish Mahadevan, Leif Lindholm, Meenakshi Aggarwal
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
- EArchCommonObjPsdInfo
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
.../ConfigurationManager.c | 28 +++++++++----------
.../ConfigurationManager.h | 2 +-
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index c63b8bc68d3f..01b78b682ad0 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -1355,7 +1355,7 @@ GetPciInterruptMapInfo (
@param [in] This Pointer to the Configuration Manager Protocol.
@param [in] CmObjectId The Object ID of the CM object requested
@param [in] SearchToken A unique token for identifying the requested
- CM_ARM_PCI_INTERRUPT_MAP_INFO object.
+ CM_ARCH_COMMON_PSD_INFO object.
@param [in, out] CmObject Pointer to the Configuration Manager Object
descriptor describing the requested Object.
@@ -1775,6 +1775,19 @@ GetArchCommonNameSpaceObject (
);
break;
+ case EArchCommonObjPsdInfo:
+ Status = HandleCmObjectRefByToken (
+ This,
+ CmObjectId,
+ PlatformRepo->PsdInfo,
+ sizeof (PlatformRepo->PsdInfo),
+ ARRAY_SIZE (PlatformRepo->PsdInfo),
+ Token,
+ GetPsdInfo,
+ CmObject
+ );
+ break;
+
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
@@ -1923,19 +1936,6 @@ GetArmNameSpaceObject (
);
break;
- case EArmObjPsdInfo:
- Status = HandleCmObjectRefByToken (
- This,
- CmObjectId,
- PlatformRepo->PsdInfo,
- sizeof (PlatformRepo->PsdInfo),
- ARRAY_SIZE (PlatformRepo->PsdInfo),
- Token,
- GetPsdInfo,
- CmObject
- );
- break;
-
default: {
Status = EFI_NOT_FOUND;
DEBUG ((
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
index 9a12a7807d1c..e28e0f16b09a 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
@@ -301,7 +301,7 @@ typedef struct PlatformRepositoryInfo {
CM_ARCH_COMMON_OBJ_REF CoresLpiRef[CORES_LPI_STATE_COUNT];
// Power domains
- CM_ARM_PSD_INFO PsdInfo[PSD_DOMAIN_COUNT];
+ CM_ARCH_COMMON_PSD_INFO PsdInfo[PSD_DOMAIN_COUNT];
//
// Dynamically populated fields from here.
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117015): https://edk2.groups.io/g/devel/message/117015
Mute This Topic: https://groups.io/mt/105069951/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
` (13 preceding siblings ...)
2024-03-21 17:18 ` [edk2-devel] [PATCH 14/14] Platform/ARM: Juno: Move Psd " PierreGondois
@ 2024-06-07 14:06 ` Sami Mujawar
2024-06-07 14:21 ` Sami Mujawar
14 siblings, 1 reply; 18+ messages in thread
From: Sami Mujawar @ 2024-06-07 14:06 UTC (permalink / raw)
To: PierreGondois, devel
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
Hi Pierre,
Thank you for this patch series.
Just a note for the future. The patch subject line should follow the following format to clarify that these patches are for the devel-dynamictables-reorg branch.
[platforms/devel-dynamictables-reorg PATCH v<n> <x/y>]: Package/Module: Subject
Otherwise this patch series looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119514): https://edk2.groups.io/g/devel/message/119514
Mute This Topic: https://groups.io/mt/105069934/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 1283 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common
2024-06-07 14:06 ` [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj " Sami Mujawar
@ 2024-06-07 14:21 ` Sami Mujawar
0 siblings, 0 replies; 18+ messages in thread
From: Sami Mujawar @ 2024-06-07 14:21 UTC (permalink / raw)
To: devel@edk2.groups.io, Pierre Gondois, nd
[-- Attachment #1: Type: text/plain, Size: 1769 bytes --]
Hi All,
I have merged this series at https://github.com/tianocore/edk2-platforms/tree/devel-dynamictables-reorg.
The corresponding DynamicTablesPkg reorg changes are also merged at https://github.com/tianocore/edk2-staging/tree/dynamictables-reorg
Regards,
Sami Mujawar
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Sami Mujawar via groups.io <sami.mujawar=arm.com@groups.io>
Date: Friday, 7 June 2024 at 15:07
To: Pierre Gondois <Pierre.Gondois@arm.com>, devel@edk2.groups.io <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common
Hi Pierre,
Thank you for this patch series.
Just a note for the future. The patch subject line should follow the following format to clarify that these patches are for the devel-dynamictables-reorg branch.
[platforms/devel-dynamictables-reorg PATCH v<n> <x/y>]: Package/Module: Subject
Otherwise this patch series looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119516): https://edk2.groups.io/g/devel/message/119516
Mute This Topic: https://groups.io/mt/105069934/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 6425 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2024-06-07 14:22 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-21 17:18 [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 01/14] Platform/ARM: FVP,Juno: Add Arch Common objects handler PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 02/14] Platform/ARM: FVP,Juno: Move Power Mgmt Profile info to Arch Common PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 03/14] Platform/ARM: FVP,Juno:: Move Serial Port " PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 04/14] Platform/ARM: FVP: Move Fixed Feat Flags " PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 05/14] Platform/ARM: Juno: Move CmRef " PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 06/14] Platform/ARM: FVP,Juno: Move Pci Config Space " PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 07/14] Platform/ARM: Juno: Move Pci Address Map " PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 08/14] Platform/ARM: Juno: Move Pci Interrupt " PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 09/14] Platform/ARM: Juno: Move Lpi " PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 10/14] Platform/ARM: Juno: Rename GicCToken PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 11/14] Platform/ARM: Juno: Move Proc Hierarchy info to Arch Common PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 12/14] Platform/ARM: Juno: Move Cache " PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 13/14] Platform/ARM: Juno: Move Cpc " PierreGondois
2024-03-21 17:18 ` [edk2-devel] [PATCH 14/14] Platform/ARM: Juno: Move Psd " PierreGondois
2024-06-07 14:06 ` [edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj " Sami Mujawar
2024-06-07 14:21 ` Sami Mujawar
-- strict thread matches above, loose matches on Subject: below --
2024-03-21 16:08 [edk2-devel] [PATCH " PierreGondois
2024-03-21 16:08 ` [edk2-devel] [PATCH 02/14] Platform/ARM: FVP,Juno: Move Power Mgmt Profile info " PierreGondois
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox