From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id CF833D8024B for ; Fri, 22 Mar 2024 09:43:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=tdW5Th/obXl22j3EV+PZ+2BrHLZ51ZuZ3gynYaN9QrE=; c=relaxed/simple; d=groups.io; h=Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20240206; t=1711100629; v=1; b=MZdAb2ejqGLj+3erukqIr456kH3+h4zQeRDnmGM4n6LuyA23srX38xQz6HPZg06nW9JMQVOE tO8dq2gUwAxJ5oLIJp/U/wGM73woIPvaIO54u+lPnwS+tTCh38wHJYPjOuJpM5I8m6uLuxR0Pi2 o8WdMyQ7ZjMdzEOMCSrUC3Q0omFWRmI0NRxaISRdfws4f7F9QAcE5XQSJ8wA7g7Jy/uQCXnrhPN axm56/Cjl4Lg3fNhnJwcTNtiT23QvXMm+aBkReA59uILkifATOvcsEVn9R9i47xAfqw9C2OtNpg O+5puGj4KBWgY9AowZu/SmGp1kFHzakebyPtKbOwuYskQ== X-Received: by 127.0.0.2 with SMTP id 02zWYY7687511xEBMdil6CDf; Fri, 22 Mar 2024 02:43:49 -0700 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.64]) by mx.groups.io with SMTP id smtpd.web11.9142.1711100628949628853 for ; Fri, 22 Mar 2024 02:43:49 -0700 X-Received: from PH8PR07CA0006.namprd07.prod.outlook.com (2603:10b6:510:2cd::7) by DS7PR12MB8419.namprd12.prod.outlook.com (2603:10b6:8:e9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.24; Fri, 22 Mar 2024 09:43:46 +0000 X-Received: from CY4PEPF0000FCC1.namprd03.prod.outlook.com (2603:10b6:510:2cd:cafe::6c) by PH8PR07CA0006.outlook.office365.com (2603:10b6:510:2cd::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.13 via Frontend Transport; Fri, 22 Mar 2024 09:43:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000FCC1.mail.protection.outlook.com (10.167.242.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7409.10 via Frontend Transport; Fri, 22 Mar 2024 09:43:45 +0000 X-Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 22 Mar 2024 04:43:42 -0500 From: "Chang, Abner via groups.io" To: CC: Nickle Wang , Igor Kulchytskyy Subject: [edk2-devel] [PATCH 3/5] RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support Date: Fri, 22 Mar 2024 17:43:11 +0800 Message-ID: <20240322094313.79-4-abner.chang@amd.com> In-Reply-To: <20240322094313.79-1-abner.chang@amd.com> References: <20240322094313.79-1-abner.chang@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCC1:EE_|DS7PR12MB8419:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c582dce-292d-4f2f-40c6-08dc4a549191 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 5FJpgjG4HwT2z4Y5X+QCBrayxtlumNyA2ORDYJcY0lz3IFHu63rmo86OqSRl0juR2Wribya6rz/wAhHgM22x3a7iOUPid7lvKz6HHGSjmO32ltUscKfKzMlmFZfqk3gzNhooDyXlQtXAXEAqESM/+zQiGXMoN5t6uwOQEMkNK7uyB4QE2cQAAqB+sMkzo0ca4dM59B8UHQhkUqAaWdIvxva6pXPJQxDSWeESh1OAUkeCUAUSFdHFQO/6dL8JeZ4iJ4VBCx0YVghPhYB+uQ4SYA+mBmqqroetVIn9CPk/2597i+He+BwjjgFbTpyW97pjYLcMB5prOPLEgPqFWmJvr0i6E3MUUB4HO1chSF8uxK6MR9rZaq48r6Kp30yuqUwmv665QSDpWQ9LpmihU2371f/jN2G7XE577Ft+f/1UL1gGj6izJnFlqFN4x/7U6VPjID2iHn1x36x3Vxr0P5fqarLU9H3JJiDB50asMJTz9N8j+2PHvY3yMxMVk2pgMN+gkd94RW2IS44ypg1RF21hwmw/AizQ96V4wnfQ21wwfBZaJeBH/f5ZgYOtqHyTXn0bZEBPtvmpwVNlyWB+Ke4ZomYsOcDf528BNhHpF6zy7o6JvTq1LEg9u+Y/KhUWrD1ueK5iKfszJSp3fOGXlog3aBUeE6BhctV3CXGzfRlVFDPHn2sEJjDDYufpi9vwVO31Y+jvfj6PDfI7Qg7BC9DFIhCDrT94VEFo0GuCzOTSgjLVSaK9MLKzzPweBWs+57UN X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2024 09:43:45.8597 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5c582dce-292d-4f2f-40c6-08dc4a549191 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCC1.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8419 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 22 Mar 2024 02:43:49 -0700 Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: UaKQ8r5xuayWpDCTb35AVROpx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=MZdAb2ej; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io From: Abner Chang Add RedfishPlatformConfigDxe debug capability that aligns with edk2 Redfish debug mechanism. - PcdRedfishPlatformConfigDebugProperty, add PCD to control RedfishPlatformConfigDxe subordinate of Redfish debug capabilities. - PcdRedfishPlatformConfigFeatureProperty, add PCD to manage RedfishPlatformConfigDxe features. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy --- RedfishPkg/RedfishPkg.dec | 15 +++ .../RedfishPlatformConfigDxe.inf | 8 ++ .../RedfishPlatformConfigDxe.h | 46 +++++++- .../RedfishPlatformConfigImpl.h | 24 +++++ .../RedfishPlatformConfigCapability.c | 52 +++++++++ .../RedfishPlatformConfigDxe.c | 59 +++++++---- .../RedfishPlatformConfigImpl.c | 100 +++++++++++------- 7 files changed, 248 insertions(+), 56 deletions(-) create mode 100644 RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConf= igCapability.c diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index a9665ff68ef..c048e43f53b 100644 --- a/RedfishPkg/RedfishPkg.dec +++ b/RedfishPkg/RedfishPkg.dec @@ -193,3 +193,18 @@ # 0x0000000000000001 RedfishPlatformConfigDxe driver debug enabled. # gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDebugCategory|0|UINT64|0x00001012 + # + # Redfish RedfishPlatformConfigDxe Debug Properties + # 0x00000001 x-uefi-redfish string database message enabled + # 0x00000002 Debug Message for dumping formset + # 0x00000004 Debug Message for x-uefi-redfish searching result + # 0x00000008 Debug Message for x-uefi-redfish Regular Expression sear= ching result + # + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishPlatformConfigDebugProperty|0|UIN= T32|0x00001013 + # + # RedfishPlatformConfigDxe feature enablement + # 0x00000001 Enable building Redfish Attribute Registry menu path. + # 0x00000002 Allow supressed HII option to be exposed on Redfish. + # + # Redfish RedfishPlatformConfigDxe feature Properties + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishPlatformConfigFeatureProperty|0|U= INT32|0x00001014 diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.i= nf b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf index 5a249c8c3bc..2db47c2cffc 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf @@ -3,6 +3,7 @@ # # (C) Copyright 2021 Hewlett Packard Enterprise Development LP
# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserve= d. +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -23,6 +24,7 @@ RedfishPkg/RedfishPkg.dec =20 [Sources] + RedfishPlatformConfigCapability.c RedfishPlatformConfigDxe.h RedfishPlatformConfigDxe.c RedfishPlatformConfigImpl.h @@ -36,7 +38,9 @@ HiiLib HiiUtilityLib MemoryAllocationLib + PcdLib PrintLib + RedfishDebugLib UefiLib UefiBootServicesTableLib UefiRuntimeServicesTableLib @@ -51,5 +55,9 @@ [Guids] gEfiRegexSyntaxTypePerlGuid ## CONSUMED =20 +[FixedPcd] + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishPlatformConfigFeatureProperty + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishPlatformConfigDebugProperty + [Depex] TRUE diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.h= b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.h index 38adea04c5b..688f2067bff 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.h +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.h @@ -3,6 +3,7 @@ =20 (C) Copyright 2021 Hewlett Packard Enterprise Development LP
Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights res= erved. + Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -20,7 +21,9 @@ #include #include #include +#include #include +#include #include #include #include @@ -37,6 +40,41 @@ // #include =20 +// +// Debug message in DEBUG_REDFISH_COMPONENT_PLATFORM_CONFIG_DXE scope. +// To enable the debug message for this module, below PCDs must be set. +// +// 1. DEBUG_MANAGEABILITY must be set PcdDebugPrintErrorLevel. +// +// 2 RedfishPlatformConfigDxe debug enablement must be set in +// PcdRedfishDebugCategory (defined in RedfishPkg.dec) +// +// 3. The suborinate debug enablement for RedfishPlatformConfigDxe +// must be set in PcdRedfishPlatformConfigDebugPropert (defined +// in RedfishPkg.dec). +// +#define DEBUG_REDFISH_THIS_MODULE(DebugSubordinate, ...) \ + while (RedfishPlatformConfigDebugProp (DebugSubordinate)) { \ + DEBUG_REDFISH(DEBUG_REDFISH_COMPONENT_PLATFORM_CONFIG_DXE, ##__VA_ARGS= __); \ + break; \ + } + +#define DEBUG_REDFISH_THIS_MODULE_CODE_BEGIN(DebugSubordinate) \ + if (RedfishPlatformConfigDebugProp (DebugSubordinate)) { + +#define DEBUG_REDFISH_THIS_MODULE_CODE_END() } + +#define DEBUG_REDFISH_THIS_MODULE_CODE(DebugSubordinate, Expression) \ + DEBUG_REDFISH_THIS_MODULE_CODE_BEGIN(DebugSubordinate) \ + Expression \ + DEBUG_REDFISH_THIS_MODULE_CODE_END() + +// Subordinate debug property for DEBUG_REDFISH_PLATFORM_CONFIG_DXE +#define REDFISH_PLATFORM_CONFIG_DEBUG_STRING_DATABASE 0x00000001 +#define REDFISH_PLATFORM_CONFIG_DEBUG_DUMP_FORMSET 0x00000002 +#define REDFISH_PLATFORM_CONFIG_DEBUG_CONFIG_LANG_SEARCH 0x00000004 +#define REDFISH_PLATFORM_CONFIG_DEBUG_CONFIG_LANG_REGEX 0x00000008 + /// /// Definition of EDKII_REDFISH_PLATFORM_CONFIG_NOTIFY. /// @@ -75,8 +113,12 @@ typedef struct { #define REGULAR_EXPRESSION_INCLUDE_ALL L".*" #define CONFIGURE_LANGUAGE_PREFIX "x-uefi-redfish-" #define REDFISH_PLATFORM_CONFIG_VERSION 0x00010000 -#define REDFISH_PLATFORM_CONFIG_DEBUG DEBUG_MANAGEABILITY -#define REDFISH_MENU_PATH_SIZE 8 + +#define REDFISH_MENU_PATH_SIZE 8 + +// Definitions of Redfish platform config capbility +#define REDFISH_PLATFORM_CONFIG_BUILD_MENU_PATH 0x000000001 +#define REDFISH_PLATFORM_CONFIG_ALLOW_SUPPRESSED 0x000000002 =20 /** Convert input unicode string to ascii string. It's caller's diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.= h b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.h index 6e6c7fdb8a9..47c446acd4c 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.h +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.h @@ -418,4 +418,28 @@ HiiStrSize ( IN CONST CHAR16 *String ); =20 +/** + Check if the debug property is enabled or not. + + @retval TRUE, the debug property is enabled. + FALSE, the debug property is not enabled. + +**/ +BOOLEAN +RedfishPlatformConfigDebugProp ( + IN UINT16 DebugProp + ); + +/** + Check if the Platform Configure feature is enabled or not. + + @retval TRUE, the feature is enabled. + FALSE, the feature is not enabled. + +**/ +BOOLEAN +RedfishPlatformConfigFeatureProp ( + IN UINT16 FeatureProp + ); + #endif diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigCapab= ility.c b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigCapabili= ty.c new file mode 100644 index 00000000000..ae081d7e3ce --- /dev/null +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigCapability.c @@ -0,0 +1,52 @@ +/** @file + The implementation of EDKII Redfish Platform Config Capability. + Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
+ + SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#include "RedfishPlatformConfigDxe.h" +#include "RedfishPlatformConfigImpl.h" + +/** + Check if the debug property is enabled or not. + + @retval TRUE, the debug property is enabled. + FALSE, the debug property is not enabled. + +**/ +BOOLEAN +RedfishPlatformConfigDebugProp ( + IN UINT16 DebugType + ) +{ + UINT64 DebugProp =3D FixedPcdGet64 (PcdRedfishPlatformConfigDebugProper= ty); + + if ((DebugProp & DebugType) !=3D 0) { + return TRUE; + } + + return FALSE; +} + +/** + Check if the Platform Configure feature is enabled or not. + + @retval TRUE, the feature is enabled. + FALSE, the feature is not enabled. + +**/ +BOOLEAN +RedfishPlatformConfigFeatureProp ( + IN UINT16 FeatureType + ) +{ + UINT64 FeatureProp =3D FixedPcdGet64 (PcdRedfishPlatformConfigFeaturePr= operty); + + if ((FeatureProp & FeatureType) !=3D 0) { + return TRUE; + } + + return FALSE; +} diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c= b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index 664b48eb50e..8a02c839035 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c @@ -315,7 +315,7 @@ DumpHiiStatementPrompt ( =20 **/ CHAR8 * -BuildMenPath ( +BuildMenuPath ( IN REDFISH_PLATFORM_CONFIG_STATEMENT_PRIVATE *StatementPrivate ) { @@ -345,7 +345,7 @@ BuildMenPath ( } =20 do { - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "F(%d) <-", FormPrivate->Id)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "F(%d) <-", FormPrivate->Id)); FormPrivate =3D FindFormLinkToThis (FormPrivate); if (FormPrivate =3D=3D NULL) { break; @@ -387,7 +387,7 @@ BuildMenPath ( AsciiStrCatS (Buffer, OldBufferSize, "/"); AsciiStrCatS (Buffer, OldBufferSize, FormTitle); FreePool (FormTitle); - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, " %a\n", Buffer)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, " %a\n", Buffer)); } =20 FormPrivate =3D (REDFISH_PLATFORM_CONFIG_FORM_PRIVATE *)PopRedfishStac= k (FormStack); @@ -1061,12 +1061,12 @@ DumpOrderedListValue ( return; } =20 - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.Type=3D 0x%x\n", OrderedLi= stStatement->Value.Type)); - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.BufferValueType=3D 0x%x\n"= , OrderedListStatement->Value.BufferValueType)); - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.BufferLen=3D 0x%x\n", Orde= redListStatement->Value.BufferLen)); - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.Buffer=3D 0x%x\n", Ordered= ListStatement->Value.Buffer)); - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.MaxContainers=3D 0x%x\n", = OrderedListStatement->ExtraData.OrderListData.MaxContainers)); - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "StorageWidth=3D 0x%x\n", Ordered= ListStatement->StorageWidth)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "Value.Type=3D 0x%x\n", OrderedLi= stStatement->Value.Type)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "Value.BufferValueType=3D 0x%x\n"= , OrderedListStatement->Value.BufferValueType)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "Value.BufferLen=3D 0x%x\n", Orde= redListStatement->Value.BufferLen)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "Value.Buffer=3D 0x%x\n", Ordered= ListStatement->Value.Buffer)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "Value.MaxContainers=3D 0x%x\n", = OrderedListStatement->ExtraData.OrderListData.MaxContainers)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "StorageWidth=3D 0x%x\n", Ordered= ListStatement->StorageWidth)); =20 if (OrderedListStatement->Value.Buffer =3D=3D NULL) { return; @@ -1083,7 +1083,7 @@ DumpOrderedListValue ( Value8 =3D (UINT8 *)OrderedListStatement->Value.Buffer; Count =3D OrderedListStatement->StorageWidth / sizeof (UINT8); for (Index =3D 0; Index < Count; Index++) { - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value8[Index])); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%d ", Value8[Index])); } =20 break; @@ -1091,7 +1091,7 @@ DumpOrderedListValue ( Value16 =3D (UINT16 *)OrderedListStatement->Value.Buffer; Count =3D OrderedListStatement->StorageWidth / sizeof (UINT16); for (Index =3D 0; Index < Count; Index++) { - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value16[Index])); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%d ", Value16[Index])); } =20 break; @@ -1099,7 +1099,7 @@ DumpOrderedListValue ( Value32 =3D (UINT32 *)OrderedListStatement->Value.Buffer; Count =3D OrderedListStatement->StorageWidth / sizeof (UINT32); for (Index =3D 0; Index < Count; Index++) { - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value32[Index])); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%d ", Value32[Index])); } =20 break; @@ -1107,7 +1107,7 @@ DumpOrderedListValue ( Value64 =3D (UINT64 *)OrderedListStatement->Value.Buffer; Count =3D OrderedListStatement->StorageWidth / sizeof (UINT64); for (Index =3D 0; Index < Count; Index++) { - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value64[Index])); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%d ", Value64[Index])); } =20 break; @@ -1115,13 +1115,13 @@ DumpOrderedListValue ( Value8 =3D (UINT8 *)OrderedListStatement->Value.Buffer; Count =3D OrderedListStatement->StorageWidth / sizeof (UINT8); for (Index =3D 0; Index < Count; Index++) { - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value8[Index])); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%d ", Value8[Index])); } =20 break; } =20 - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "\n")); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "\n")); } =20 /** @@ -2013,6 +2013,8 @@ RedfishPlatformConfigProtocolGetConfigureLang ( UINTN Index; CHAR8 *FullSchema; =20 + DEBUG ((DEBUG_INFO, "%a: Harvest config language of %a_%a (Regex: %s).\n= ", __func__, Schema, Version, RegexPattern)); + if ((This =3D=3D NULL) || IS_EMPTY_STRING (Schema) || IS_EMPTY_STRING (V= ersion) || (Count =3D=3D NULL) || (ConfigureLangList =3D=3D NULL) || IS_EMP= TY_STRING (RegexPattern)) { return EFI_INVALID_PARAMETER; } @@ -2072,6 +2074,22 @@ RedfishPlatformConfigProtocolGetConfigureLang ( *Count =3D StatementList.Count; *ConfigureLangList =3D TmpConfigureLangList; =20 + DEBUG_REDFISH_THIS_MODULE ( + REDFISH_PLATFORM_CONFIG_DEBUG_CONFIG_LANG_REGEX, + "%a: Number of configure language strings harvested: %d\n", + __func__, + StatementList.Count + ); + + DEBUG_REDFISH_THIS_MODULE_CODE ( + REDFISH_PLATFORM_CONFIG_DEBUG_CONFIG_LANG_REGEX, + DEBUG_REDFISH (DEBUG_REDFISH_COMPONENT_PLATFORM_CONFIG_DXE, "%a: Numbe= r of configure language strings harvested: %d\n", __func__, StatementList.C= ount); + for (Index =3D 0; Index < *Count; Index++) { + DEBUG_REDFISH (DEBUG_REDFISH_COMPONENT_PLATFORM_CONFIG_DXE, " (%d) %= s\n", Index, TmpConfigureLangList[Index]); + } + + ); + RELEASE_RESOURCE: =20 if (FullSchema !=3D NULL) { @@ -2082,6 +2100,7 @@ RELEASE_RESOURCE: ReleaseStatementList (&StatementList); } =20 + DEBUG ((DEBUG_INFO, "%a: exit.\n", __func__)); return Status; } =20 @@ -2296,6 +2315,7 @@ RedfishPlatformConfigProtocolGetAttribute ( CHAR8 *FullSchema; CHAR8 *Buffer; =20 + DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__)); if ((This =3D=3D NULL) || IS_EMPTY_STRING (Schema) || IS_EMPTY_STRING (V= ersion) || IS_EMPTY_STRING (ConfigureLang) || (AttributeValue =3D=3D NULL))= { return EFI_INVALID_PARAMETER; } @@ -2337,9 +2357,11 @@ RedfishPlatformConfigProtocolGetAttribute ( // // Build up menu path // - AttributeValue->MenuPath =3D BuildMenPath (TargetStatement); - if (AttributeValue->MenuPath =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: failed to build menu path for \"%a\"\n", __f= unc__, AttributeValue->AttributeName)); + if (RedfishPlatformConfigFeatureProp (REDFISH_PLATFORM_CONFIG_BUILD_MENU= _PATH)) { + AttributeValue->MenuPath =3D BuildMenuPath (TargetStatement); + if (AttributeValue->MenuPath =3D=3D NULL) { + DEBUG ((DEBUG_ERROR, "%a: failed to build menu path for \"%a\"\n", _= _func__, AttributeValue->AttributeName)); + } } =20 // @@ -2370,6 +2392,7 @@ RELEASE_RESOURCE: FreePool (FullSchema); } =20 + DEBUG ((DEBUG_INFO, "%a: Exit\n", __func__)); return Status; } =20 diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.= c b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c index fec84fb7648..26a82820a6c 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c @@ -32,7 +32,7 @@ DumpHiiString ( EFI_STRING String; =20 if ((HiiHandle =3D=3D NULL) || (StringId =3D=3D 0)) { - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "???")); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "???")); return EFI_INVALID_PARAMETER; } =20 @@ -41,7 +41,7 @@ DumpHiiString ( return EFI_NOT_FOUND; } =20 - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%s", String)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%s", String)); FreePool (String); =20 return EFI_SUCCESS; @@ -79,18 +79,18 @@ DumpFormset ( HiiFormPrivate =3D REDFISH_PLATFORM_CONFIG_FORM_FROM_LINK (HiiFormLin= k); HiiNextFormLink =3D GetNextNode (&FormsetPrivate->HiiFormList, HiiForm= Link); =20 - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, " [%d] form: %d title: ", ++In= dex, HiiFormPrivate->Id)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, " [%d] form: %d title: ", ++In= dex, HiiFormPrivate->Id)); DumpHiiString (FormsetPrivate->HiiHandle, HiiFormPrivate->Title); - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "\n")); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "\n")); =20 HiiStatementLink =3D GetFirstNode (&HiiFormPrivate->StatementList); while (!IsNull (&HiiFormPrivate->StatementList, HiiStatementLink)) { HiiStatementPrivate =3D REDFISH_PLATFORM_CONFIG_STATEMENT_FROM_LINK= (HiiStatementLink); HiiNextStatementLink =3D GetNextNode (&HiiFormPrivate->StatementList= , HiiStatementLink); =20 - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, " QID: 0x%x Prompt: ", Hii= StatementPrivate->QuestionId)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, " QID: 0x%x Prompt: ", Hii= StatementPrivate->QuestionId)); DumpHiiString (FormsetPrivate->HiiHandle, HiiStatementPrivate->Descr= iption); - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "\n")); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "\n")); =20 HiiStatementLink =3D HiiNextStatementLink; } @@ -125,7 +125,7 @@ DumpFormsetList ( } =20 if (IsListEmpty (FormsetList)) { - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%a: Empty formset list\n", __f= unc__)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: Empty formset list\n", __f= unc__)); return EFI_SUCCESS; } =20 @@ -135,7 +135,7 @@ DumpFormsetList ( HiiFormsetNextLink =3D GetNextNode (FormsetList, HiiFormsetLink); HiiFormsetPrivate =3D REDFISH_PLATFORM_CONFIG_FORMSET_FROM_LINK (HiiF= ormsetLink); =20 - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "[%d] HII Handle: 0x%x formset:= %g at %s\n", ++Index, HiiFormsetPrivate->HiiHandle, &HiiFormsetPrivate->Gu= id, HiiFormsetPrivate->DevicePathStr)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "[%d] HII Handle: 0x%x formset:= %g at %s\n", ++Index, HiiFormsetPrivate->HiiHandle, &HiiFormsetPrivate->Gu= id, HiiFormsetPrivate->DevicePathStr)); DumpFormset (HiiFormsetPrivate); =20 HiiFormsetLink =3D HiiFormsetNextLink; @@ -622,7 +622,9 @@ GetStatementPrivateByConfigureLangRegex ( HiiNextStatementLink =3D GetNextNode (&HiiFormPrivate->StatementLi= st, HiiStatementLink); HiiStatementPrivate =3D REDFISH_PLATFORM_CONFIG_STATEMENT_FROM_LI= NK (HiiStatementLink); =20 - if ((HiiStatementPrivate->Description !=3D 0) && !HiiStatementPriv= ate->Suppressed) { + if ((HiiStatementPrivate->Description !=3D 0) && + (RedfishPlatformConfigFeatureProp (REDFISH_PLATFORM_CONFIG_ALL= OW_SUPPRESSED) || !HiiStatementPrivate->Suppressed)) + { TmpString =3D HiiStatementPrivate->DescriptionStr; if (TmpString !=3D NULL) { Status =3D RegularExpressionProtocol->MatchString ( @@ -698,6 +700,7 @@ GetStatementPrivateByConfigureLang ( LIST_ENTRY *HiiNextStatementLink; REDFISH_PLATFORM_CONFIG_STATEMENT_PRIVATE *HiiStatementPrivate; EFI_STRING TmpString; + UINTN Index; =20 if ((FormsetList =3D=3D NULL) || IS_EMPTY_STRING (Schema) || IS_EMPTY_ST= RING (ConfigureLang)) { return NULL; @@ -707,6 +710,7 @@ GetStatementPrivateByConfigureLang ( return NULL; } =20 + Index =3D 0; HiiFormsetLink =3D GetFirstNode (FormsetList); while (!IsNull (FormsetList, HiiFormsetLink)) { HiiFormsetNextLink =3D GetNextNode (FormsetList, HiiFormsetLink); @@ -731,15 +735,22 @@ GetStatementPrivateByConfigureLang ( HiiNextStatementLink =3D GetNextNode (&HiiFormPrivate->StatementLi= st, HiiStatementLink); HiiStatementPrivate =3D REDFISH_PLATFORM_CONFIG_STATEMENT_FROM_LI= NK (HiiStatementLink); =20 - DEBUG_CODE ( - STATIC UINTN Index =3D 0; - Index++; - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%a: [%d] search %s in QI= D: 0x%x form: 0x%x formset: %g\n", __func__, Index, ConfigureLang, HiiState= mentPrivate->QuestionId, HiiFormPrivate->Id, &HiiFormsetPrivate->Guid)); - ); - - if (HiiStatementPrivate->Description !=3D 0) { + if ((HiiStatementPrivate->Description !=3D 0) && + (RedfishPlatformConfigFeatureProp (REDFISH_PLATFORM_CONFIG_ALL= OW_SUPPRESSED) || !HiiStatementPrivate->Suppressed)) + { TmpString =3D HiiStatementPrivate->DescriptionStr; if (TmpString !=3D NULL) { + Index++; + DEBUG_REDFISH_THIS_MODULE ( + REDFISH_PLATFORM_CONFIG_DEBUG_CONFIG_LANG_SEARCH, + "%a: [%d] check %s in QID: 0x%x form: 0x%x formset: %g\n", + __func__, + Index, + ConfigureLang, + HiiStatementPrivate->QuestionId, + HiiFormPrivate->Id, + &HiiFormsetPrivate->Guid + ); if (HiiStrCmp (TmpString, ConfigureLang) =3D=3D 0) { return HiiStatementPrivate; } @@ -1022,7 +1033,7 @@ NewRedfishXuefiStringArray ( =20 **/ REDFISH_X_UEFI_STRING_DATABASE * -GetExitOrCreateXuefiStringDatabase ( +GetExistOrCreateXuefiStringDatabase ( IN REDFISH_PLATFORM_CONFIG_FORM_SET_PRIVATE *FormsetPrivate, IN EFI_HII_STRING_PACKAGE_HDR *HiiStringPackageHeader ) @@ -1031,8 +1042,6 @@ GetExitOrCreateXuefiStringDatabase ( BOOLEAN CreateNewOne; REDFISH_X_UEFI_STRING_DATABASE *XuefiRedfishStringDatabase; =20 - DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__)); - CreateNewOne =3D TRUE; XuefiRedfishStringDatabase =3D NULL; if (!IsListEmpty (&FormsetPrivate->XuefiRedfishStringDatabase)) { @@ -1054,7 +1063,7 @@ GetExitOrCreateXuefiStringDatabase ( } =20 if (CreateNewOne) { - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, " Creating x-uefi-redfish (%a)= string database...\n", HiiStringPackageHeader->Language)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, " Creating x-uefi-redfish (%a)= string database...\n", HiiStringPackageHeader->Language)); XuefiRedfishStringDatabase =3D (REDFISH_X_UEFI_STRING_DATABASE *)Alloc= ateZeroPool (sizeof (REDFISH_X_UEFI_STRING_DATABASE)); if (XuefiRedfishStringDatabase =3D=3D NULL) { DEBUG ((DEBUG_ERROR, " Failed to allocate REDFISH_X_UEFI_STRING_DAT= ABASE.\n")); @@ -1073,7 +1082,7 @@ GetExitOrCreateXuefiStringDatabase ( } =20 DEBUG (( - REDFISH_PLATFORM_CONFIG_DEBUG, + DEBUG_REDFISH_PLATFORM_CONFIG, " x-uefi-redfish (%a):\n String array is added to XuefiRedfishSt= ringDatabase, total %d arrays now.\n", XuefiRedfishStringDatabase->XuefiRedfishLanguage, XuefiRedfishStringDatabase->StringsArrayBlocks @@ -1145,7 +1154,7 @@ RedfishXuefiStringInsertDatabase ( REDFISH_X_UEFI_STRING_DATABASE *XuefiRedfishStringDatabase; REDFISH_X_UEFI_STRINGS_ARRAY *ThisArray; =20 - XuefiRedfishStringDatabase =3D GetExitOrCreateXuefiStringDatabase (Forms= etPrivate, HiiStringPackageHeader); + XuefiRedfishStringDatabase =3D GetExistOrCreateXuefiStringDatabase (Form= setPrivate, HiiStringPackageHeader); if (XuefiRedfishStringDatabase =3D=3D NULL) { DEBUG ((DEBUG_ERROR, "%a: Failed to get REDFISH_X_UEFI_STRING_DATABASE= of x-uefi-redfish language %a.\n", __func__, HiiStringPackageHeader->Langu= age)); ReleaseXuefiStringDatabase (FormsetPrivate); @@ -1170,13 +1179,13 @@ RedfishXuefiStringInsertDatabase ( (ThisArray->ArrayEntryAddress + StringIdOffset)->StringId =3D StringId; (ThisArray->ArrayEntryAddress + StringIdOffset)->UcsString =3D StringTex= tPtr; =20 - DEBUG (( - REDFISH_PLATFORM_CONFIG_DEBUG, + DEBUG_REDFISH_THIS_MODULE ( + REDFISH_PLATFORM_CONFIG_DEBUG_STRING_DATABASE, " Insert string ID: (%d) to database\n x-uefi-string: \"%s\"\n = Language: %a.\n", StringId, StringTextPtr, HiiStringPackageHeader->Language - )); + ); return EFI_SUCCESS; } =20 @@ -1193,7 +1202,8 @@ RedfishXuefiStringInsertDatabase ( BOOLEAN CreateXuefiLanguageStringIdMap ( IN REDFISH_PLATFORM_CONFIG_FORM_SET_PRIVATE *FormsetPrivate, - IN EFI_HII_STRING_PACKAGE_HDR *HiiStringPackageHeader + IN EFI_HII_STRING_PACKAGE_HDR *HiiStringPackageHeader, + IN UINTN *TotalStringAdded ) { EFI_STATUS Status; @@ -1209,6 +1219,9 @@ CreateXuefiLanguageStringIdMap ( EFI_HII_SIBT_EXT2_BLOCK Ext2; UINT32 Length32; UINT8 *StringBlockInfo; + UINTN StringsAdded; + + StringsAdded =3D 0; =20 // // Parse the string blocks to get the string text and font. @@ -1280,6 +1293,8 @@ CreateXuefiLanguageStringIdMap ( DEBUG ((DEBUG_ERROR, "%a: Failed to insert x-uefi-redfish stri= ng %s.\n", __func__, StringTextPtr)); return FALSE; } + + StringsAdded++; } =20 BlockSize +=3D (Offset + HiiStrSize ((CHAR16 *)StringTextPtr)); @@ -1371,6 +1386,7 @@ CreateXuefiLanguageStringIdMap ( BlockHdr =3D (UINT8 *)(StringBlockInfo + BlockSize); } =20 + *TotalStringAdded =3D StringsAdded; return TRUE; } =20 @@ -1484,6 +1500,8 @@ BuildXUefiRedfishStringDatabase ( UINTN SupportedSchemaLangCount; CHAR8 **SupportedSchemaLang; BOOLEAN StringIdMapIsBuilt; + UINTN TotalStringsAdded; + UINTN NumberPackageStrings; =20 DEBUG ((DEBUG_INFO, "%a: Building x-uefi-redfish string database, HII Fo= rmset GUID - %g.\n", __func__, FormsetPrivate->Guid)); =20 @@ -1515,6 +1533,7 @@ BuildXUefiRedfishStringDatabase ( return; } =20 + TotalStringsAdded =3D 0; // // Finding the string package. // @@ -1539,14 +1558,18 @@ BuildXUefiRedfishStringDatabase ( AsciiStrLen (HiiStringPackageHeader->Language) ) =3D=3D 0) { - StringIdMapIsBuilt =3D CreateXuefiLanguageStringIdMap (Formset= Private, HiiStringPackageHeader); + StringIdMapIsBuilt =3D CreateXuefiLanguageStringIdMap (Formset= Private, HiiStringPackageHeader, &NumberPackageStrings); + if (StringIdMapIsBuilt) { + TotalStringsAdded +=3D NumberPackageStrings; + } + break; } } =20 if (StringIdMapIsBuilt =3D=3D FALSE) { if (AsciiStrStr (HiiStringPackageHeader->Language, X_UEFI_SCHEMA= _PREFIX) =3D=3D NULL) { - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, " No need to build x-u= efi-redfish string ID map for HII language %a\n", HiiStringPackageHeader->L= anguage)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, " No need to build x-u= efi-redfish string ID map for HII language %a\n", HiiStringPackageHeader->L= anguage)); } else { DEBUG ((DEBUG_ERROR, " Failed to build x-uefi-redfish string = ID map of HII language %a\n", HiiStringPackageHeader->Language)); } @@ -1556,6 +1579,8 @@ BuildXUefiRedfishStringDatabase ( PackageHeader =3D (EFI_HII_PACKAGE_HEADER *)((UINTN)PackageHeader = + PackageHeader->Length); } } + + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, " Total %d x-uefi-redfish config= language are added.\n", TotalStringsAdded)); } =20 /** @@ -1621,7 +1646,7 @@ LoadFormset ( FormsetPrivate->DevicePathStr =3D ConvertDevicePathToText (HiiFormSet->D= evicePath, FALSE, FALSE); Status =3D GetSupportedSchema (FormsetPrivate->Hi= iHandle, &FormsetPrivate->SupportedSchema); if (EFI_ERROR (Status)) { - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%a: No x-uefi-redfish configur= ation found on the formset - %g\n", __func__, FormsetPrivate->Guid)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: No x-uefi-redfish configur= ation found on the formset - %g\n", __func__, FormsetPrivate->Guid)); return EFI_UNSUPPORTED; // Can't build AttributeRegistry Meni path wit= h returning EFI_UNSUPPORTED. } else { // Building x-uefi-redfish string database @@ -1789,7 +1814,10 @@ LoadFormsetList ( InsertTailList (FormsetList, &FormsetPrivate->Link); =20 DEBUG_CODE ( + if (RedfishPlatformConfigDebugProp (REDFISH_PLATFORM_CONFIG_DEBUG_DUMP= _FORMSET)) { DumpFormsetList (FormsetList); + } + ); =20 return EFI_SUCCESS; @@ -1909,7 +1937,7 @@ NotifyFormsetUpdate ( if (TargetPendingList !=3D NULL) { TargetPendingList->IsDeleted =3D FALSE; DEBUG_CODE ( - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%a: HII handle: 0x%x is upda= ted\n", __func__, HiiHandle)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: HII handle: 0x%x is upda= ted\n", __func__, HiiHandle)); ); return EFI_SUCCESS; } @@ -1925,7 +1953,7 @@ NotifyFormsetUpdate ( InsertTailList (PendingList, &TargetPendingList->Link); =20 DEBUG_CODE ( - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%a: HII handle: 0x%x is create= d\n", __func__, HiiHandle)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: HII handle: 0x%x is create= d\n", __func__, HiiHandle)); ); =20 return EFI_SUCCESS; @@ -1962,7 +1990,7 @@ NotifyFormsetDeleted ( if (TargetPendingList !=3D NULL) { TargetPendingList->IsDeleted =3D TRUE; DEBUG_CODE ( - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%a: HII handle: 0x%x is upda= ted and deleted\n", __func__, HiiHandle)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: HII handle: 0x%x is upda= ted and deleted\n", __func__, HiiHandle)); ); return EFI_SUCCESS; } @@ -1978,7 +2006,7 @@ NotifyFormsetDeleted ( InsertTailList (PendingList, &TargetPendingList->Link); =20 DEBUG_CODE ( - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%a: HII handle: 0x%x is delete= d\n", __func__, HiiHandle)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: HII handle: 0x%x is delete= d\n", __func__, HiiHandle)); ); =20 return EFI_SUCCESS; @@ -2027,12 +2055,12 @@ ProcessPendingList ( // FormsetPrivate =3D GetFormsetPrivateByHiiHandle (Target->HiiHandle, = FormsetList); if (FormsetPrivate !=3D NULL) { - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%a: formset: %g is removed= because driver release HII resource it already\n", __func__, FormsetPrivat= e->Guid)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: formset: %g is removed= because driver release HII resource it already\n", __func__, FormsetPrivat= e->Guid)); RemoveEntryList (&FormsetPrivate->Link); ReleaseFormset (FormsetPrivate); FreePool (FormsetPrivate); } else { - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%a: formset on HII handle = 0x%x was removed already\n", __func__, Target->HiiHandle)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: formset on HII handle = 0x%x was removed already\n", __func__, Target->HiiHandle)); } } else { // @@ -2043,7 +2071,7 @@ ProcessPendingList ( // // HII formset already exist, release it and query again. // - DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%a: formset: %g is updated= . Release current formset\n", __func__, &FormsetPrivate->Guid)); + DEBUG ((DEBUG_REDFISH_PLATFORM_CONFIG, "%a: formset: %g is updated= . Release current formset\n", __func__, &FormsetPrivate->Guid)); RemoveEntryList (&FormsetPrivate->Link); ReleaseFormset (FormsetPrivate); FreePool (FormsetPrivate); --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117038): https://edk2.groups.io/g/devel/message/117038 Mute This Topic: https://groups.io/mt/105082176/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-