From: "Mike Maslenkin" <mike.maslenkin@gmail.com>
To: devel@edk2.groups.io
Cc: Mike Maslenkin <mike.maslenkin@gmail.com>,
Abner Chang <abner.chang@amd.com>,
Igor Kulchytskyy <igork@ami.com>,
Nickle Wang <nicklew@nvidia.com>
Subject: [edk2-devel] [edk2-redfish-client][RFC PATCH 3/3] RedfishClientPkg: fix the first node processing in GetRedpathNodeByIndex()
Date: Sat, 23 Mar 2024 15:00:50 +0300 [thread overview]
Message-ID: <20240323120050.53834-4-mike.maslenkin@gmail.com> (raw)
In-Reply-To: <20240323120050.53834-1-mike.maslenkin@gmail.com>
For node with index 0, the result of this function contains leading L'/'
character. But for other nodes no such characters (separators) returned.
Make processing of all fields consistent.
After this patch the debug output for specified URI is the following:
@Redfish.Settings found:/redfish/v1/Systems/system/Bios/Settings
GetNumberOfRedpathNodes:6
GetRedpathNodeByIndex[0]:redfish/v1/Systems/system/Bios/Settings
GetRedpathNodeByIndex[1]:v1/Systems/system/Bios/Settings
GetRedpathNodeByIndex[2]:Systems/system/Bios/Settings
GetRedpathNodeByIndex[3]:system/Bios/Settings
GetRedpathNodeByIndex[4]:Bios/Settings
GetRedpathNodeByIndex[5]:Settings
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
---
.../Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
index b0a3b20a40bd..c55dc2ee6d05 100644
--- a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
+++ b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
@@ -1304,7 +1304,7 @@ GetRedpathNodeByIndex (
NumberNodes = 0;
StringLen = StrLen (NodeString);
StringIndex = 1; // ConfigLang always starts with '/'.
- NodeStart = NodeString;
+ NodeStart = NodeString + StringIndex;
if (EndOfNodePtr != NULL) {
*EndOfNodePtr = NULL;
}
--
2.32.0 (Apple Git-132)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117068): https://edk2.groups.io/g/devel/message/117068
Mute This Topic: https://groups.io/mt/105101993/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-23 12:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 12:00 [edk2-devel] [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix GetRedpathNodeByIndex() Mike Maslenkin
2024-03-23 12:00 ` [edk2-devel] [edk2-redfish-client][RFC PATCH 1/3] RedfishClientPkg: fix nodes count in GetRedpathNodeByIndex() Mike Maslenkin
2024-03-26 12:16 ` Nickle Wang via groups.io
2024-03-23 12:00 ` [edk2-devel] [edk2-redfish-client][RFC PATCH 2/3] RedfishClientPkg: fix the last field processing " Mike Maslenkin
2024-03-26 12:17 ` Nickle Wang via groups.io
2024-03-23 12:00 ` Mike Maslenkin [this message]
2024-03-26 13:39 ` [edk2-devel] [edk2-redfish-client][RFC PATCH 3/3] RedfishClientPkg: fix the first node " Nickle Wang via groups.io
2024-03-25 2:12 ` [edk2-devel] [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix GetRedpathNodeByIndex() Chang, Abner via groups.io
2024-03-26 13:41 ` Nickle Wang via groups.io
2024-03-26 21:18 ` Mike Maslenkin
2024-04-01 13:33 ` Nickle Wang via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240323120050.53834-4-mike.maslenkin@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox