From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 82A427803CC for ; Tue, 26 Mar 2024 15:15:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=his5vISCHzmMiHPU5Ejf9yXgFlnZeNXzSTFEKDkXug0=; c=relaxed/simple; d=groups.io; h=Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20240206; t=1711466144; v=1; b=BVf/1idO/5L6GhvOegD/yBbxUjuIMi6kxV6YJZvsnxAUuw7dz4bAa1r4AjcuJRNnDc92sMPe ZuYagKq1xdAhhCpWYdX5qpq+/k/7qMqgvq5GbtF/IQZbTFMg/ESwEEqnW7UQH3UgRZEUf/OGhHF Xv2TJ7CfiO9Vx/6O5GmwIEiLxhf+/Dy6rApam8IGjGZ2H1D5vWWrLLLy66DfJQZSEAKLHpMAGsB Z1VZyTOVO7QXLeGvfxnTa8RnUWWNNHk07RKJ0nzfDEpCYDF4fFdfzyZ4yn+taycT7TmnYETY0kg ibPzdLbAXU2BXnIY8ivhO/3N/CvLsJddP9z/Ewh4f83VQ== X-Received: by 127.0.0.2 with SMTP id LzWLYY7687511xO3T7VZJ5Q8; Tue, 26 Mar 2024 08:15:44 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.69]) by mx.groups.io with SMTP id smtpd.web11.11689.1711466143538198778 for ; Tue, 26 Mar 2024 08:15:43 -0700 X-Received: from PH7P221CA0010.NAMP221.PROD.OUTLOOK.COM (2603:10b6:510:32a::18) by DS0PR12MB9448.namprd12.prod.outlook.com (2603:10b6:8:1bb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Tue, 26 Mar 2024 15:15:41 +0000 X-Received: from CY4PEPF0000E9D9.namprd05.prod.outlook.com (2603:10b6:510:32a:cafe::93) by PH7P221CA0010.outlook.office365.com (2603:10b6:510:32a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.13 via Frontend Transport; Tue, 26 Mar 2024 15:15:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000E9D9.mail.protection.outlook.com (10.167.241.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7409.10 via Frontend Transport; Tue, 26 Mar 2024 15:15:41 +0000 X-Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 26 Mar 2024 10:15:37 -0500 From: "Chang, Abner via groups.io" To: CC: Nickle Wang , Igor Kulchytskyy Subject: [edk2-devel] [PATCH V2 4/6] RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted unexpectedly Date: Tue, 26 Mar 2024 23:15:00 +0800 Message-ID: <20240326151503.106-5-abner.chang@amd.com> In-Reply-To: <20240326151503.106-1-abner.chang@amd.com> References: <20240326151503.106-1-abner.chang@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D9:EE_|DS0PR12MB9448:EE_ X-MS-Office365-Filtering-Correlation-Id: 07cb4576-0f38-4a8e-8626-08dc4da799ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 6izvx75y2bs8//iTHLpbSKtgOml4GS+KWe5eg4aMcUFrTo8UQXOqM6Kmyh9PZ/sq61RTxKVrzq30T36hlmJdF135xS8Tq3r37K1KvJUaxapkbt5DKbHAn9Rv7faAjTygpknN1juAI8JaiRvErnOOj1PRqt3SPo2Pm4BoiSBkCcuruh1MyKzgD0RFU3DpQdBrlhmaGL7kYQz+f8gDdxG4XTTv9pbf5fAZiPKbCwql0qKySL0QzWctVT8SEA6B7B8ACy/E6NhLoLy8YixxY+CbeI7dqsv+fNrUeITwOCvlBhFga5Hi4R2Dc/Ta+jjmY1BtggfXgDyvSuPzkFBZtG6oc0vZIuuknt2+tLNb9vc1g5fDYYp80lPq8jTenADknUuaUs0i9VSDoKdNEZNlG22tA75GvYRG0QDOsOgdsL/PGNl/vzYB6fyT9mOqEiiBNbJboDbLIfAhzcXWWbtmsOLbRzZlBjQTxeRf6ajK2buzAMeD9TXZ6p8tAA0eoU6zZUALwPPjEKxb24JDWelkBnU8JspYcys2ygnGQZXjdHw8RYlKyKABK6MgFuE9d4XBTwJNWxMgMS0AQnipIVdnEuvwsHqOuCOUK1CEM+IfQ4FxdFG/YTKYGrzaWm3Eg0ORo9K/rXvdfOc0PCl8uOqohejeuyzN6gk/bvEEtPTtbC8+WlpzBe6zx6NTeJ57WlflwhNqYt6Dv4VNbijRj2cm2QCYOb5EGF1jBU0v/agoA/zqcMYq9b6R6t40Z61BoTM0Xly0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 15:15:41.1863 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 07cb4576-0f38-4a8e-8626-08dc4da799ab X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D9.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9448 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 26 Mar 2024 08:15:43 -0700 Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Ypca3NhP8yAjBpYprC1E9JEkx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="BVf/1idO"; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Abner Chang Add the condition check when delete HII string. Only when the HiiStatement operand equal to "EFI_IFR_STRING_OP" and the statement value type =3D EFI_IFR_TYPE_STRING. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy --- .../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c= b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index 8a02c839035..d165799f9a1 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c @@ -1873,8 +1873,11 @@ RedfishPlatformConfigSetStatementCommon ( DEBUG ((DEBUG_ERROR, "%a: failed to save question value: %r\n", __func= __, Status)); } =20 - if (StatementValue->Value.string !=3D 0) { - HiiDeleteString (StatementValue->Value.string, TargetStatement->Parent= Form->ParentFormset->HiiHandle); + if ((TargetStatement->HiiStatement->Operand =3D=3D EFI_IFR_STRING_OP) &&= (StatementValue->Type =3D=3D EFI_IFR_TYPE_STRING)) { + if (StatementValue->Value.string !=3D 0) { + // Delete HII string which was created for HII statement operand =3D= EFI_IFR_STRING_OP and Type =3D EFI_IFR_TYPE_STRING. + HiiDeleteString (StatementValue->Value.string, TargetStatement->Pare= ntForm->ParentFormset->HiiHandle); + } } =20 return Status; --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117125): https://edk2.groups.io/g/devel/message/117125 Mute This Topic: https://groups.io/mt/105159786/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-