From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 09722D8078A for ; Wed, 27 Mar 2024 23:11:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Vl0U60QA/st84j/toQH9MtLCQM5oUk4lue9TYBUQ+sQ=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1711581112; v=1; b=13O4LAK31+NveGQJbxoAWvQNhbvBIaF058wqcVZn8+LM8qAaCljGaEcuIaUR5dAYvnfM4h0J rXVYK1vyUcWsl8D+QuX+F3giJG4sHcq6yxZ/UM/Qh3Om7x4xD7vKRPBBaLZibBHDkQMgn1mErt7 jSXUav0ENl62cAsUMT1cc2i24gESxGXEDAe465loa6qGA8RBDEfI7IZQ8LmI1eRRCh7c/lfOEsu MddIV77ZxMxL+aaTw7hnUuuiPAUnFJTlanFZS4qbQ+0HTw53EYURyTjuf4aR6ki9SwcmTm+22nm 2aHT6JCowcn2JbsQe4aU8w+ON/PPcVK8MRc1x6d5A4Pdg== X-Received: by 127.0.0.2 with SMTP id PaHoYY7687511x1niebIvIKP; Wed, 27 Mar 2024 16:11:52 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by mx.groups.io with SMTP id smtpd.web10.1005.1711572180653284994 for ; Wed, 27 Mar 2024 13:43:00 -0700 X-CSE-ConnectionGUID: tdn/mkERS7+6b1cQD43WxQ== X-CSE-MsgGUID: Ldz7TK7HSQWri6wIpIIVYg== X-IronPort-AV: E=McAfee;i="6600,9927,11026"; a="6919537" X-IronPort-AV: E=Sophos;i="6.07,159,1708416000"; d="scan'208";a="6919537" X-Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2024 13:42:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,159,1708416000"; d="scan'208";a="47409656" X-Received: from ppabbax-desk1.gar.corp.intel.com ([10.66.254.59]) by orviesa002.jf.intel.com with ESMTP; 27 Mar 2024 13:42:56 -0700 From: phanindrax.babu.pabba@intel.com To: devel@edk2.groups.io Cc: PhanindraX Babu Pabba , Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong Subject: [edk2-devel] [ edk2-platforms: [PATCH] MinPlatformPkg: Add missed call to FreePool v2] MinPlatformPkg: Add missed call to FreePool Date: Thu, 28 Mar 2024 02:12:44 +0530 Message-Id: <20240327204244.5919-1-phanindrax.babu.pabba@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 27 Mar 2024 16:11:51 -0700 Reply-To: devel@edk2.groups.io,phanindrax.babu.pabba@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: jaxKEeg5p2Vc0LWOJZO820JSx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=13O4LAK3; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) From: PhanindraX Babu Pabba Adding missed out call to FreePool API to free the allocated memory. Signed-off-by: PhanindraX Babu Pabba Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 5 +++-- Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b= /Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index 2a833ec9..9a91d131 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -975,7 +975,7 @@ InstallMcfgFromScratch ( FixedPcdGet32 (PcdAcpiDefaultOemRevision)=0D );=0D if (EFI_ERROR (Status)) {=0D - return Status;=0D + goto Done;=0D }=0D =0D //=0D @@ -1002,7 +1002,8 @@ InstallMcfgFromScratch ( McfgTable->Header.Length,=0D &TableHandle=0D );=0D -=0D +Done:=0D + FreePool (McfgTable);=0D return Status;=0D }=0D =0D diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c b/Platfor= m/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c index 9bc22245..f5b1a71c 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c @@ -195,6 +195,7 @@ PublishAcpiTablesFromFv ( // Increment the instance=0D //=0D Instance++;=0D + FreePool (CurrentTable);=0D CurrentTable =3D NULL;=0D }=0D }=0D --=20 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117182): https://edk2.groups.io/g/devel/message/117182 Mute This Topic: https://groups.io/mt/105187779/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-