From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0C5EC941D5E for ; Wed, 27 Mar 2024 23:11:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nhh/0D8t+qy4VfTF4P9RSO2q0fCBjsB2/ttDzhAafZA=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1711581112; v=1; b=cd9JqRh1e2t8zcgsyCrb0bdtLhjZ1cNvDb/8bkfNkWhB3X67ypnGoYpxhYRw+/9Olk2xkIhB W+HotaKFVn8XYr+lByWHmTPJuGfrxl0SHG5sH0Wo1af5vDn6lDPtymiEJTfcE1D3lHE9q+ah227 Mi4wnPhl/QyJm7NxSXfSWYJvaSp4aieUko2vBZvHzRqK4bmrQpyTQwqfegENA2UGdFrqp+RNNw6 1378TWdQZXedYGUWY/S6siqnSsBHXOsEkDuU0OfjGvh9XUVwY6fGT5AJpl8W+Yoq2I7CJVs9uh2 jEWO2I+8hBR10JRpX7PwN7yTH2FnEM6YPO0m0q2L9066A== X-Received: by 127.0.0.2 with SMTP id EUeFYY7687511xWjhVRk3XNo; Wed, 27 Mar 2024 16:11:52 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mx.groups.io with SMTP id smtpd.web11.27.1711574995989821330 for ; Wed, 27 Mar 2024 14:29:56 -0700 X-CSE-ConnectionGUID: jKsXthvqR1qC4FbC0TW89Q== X-CSE-MsgGUID: ZVIm36d9RAS2t+sTKuNdcQ== X-IronPort-AV: E=McAfee;i="6600,9927,11026"; a="10497250" X-IronPort-AV: E=Sophos;i="6.07,160,1708416000"; d="scan'208";a="10497250" X-Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2024 14:29:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,160,1708416000"; d="scan'208";a="47636071" X-Received: from ppabbax-desk1.gar.corp.intel.com ([10.66.254.59]) by fmviesa001.fm.intel.com with ESMTP; 27 Mar 2024 14:29:53 -0700 From: phanindrax.babu.pabba@intel.com To: devel@edk2.groups.io Cc: PhanindraX Babu Pabba , Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong Subject: [edk2-devel] [edk2-platforms: PATCH v2] MinPlatformPkg: Add missed call to FreePool Date: Thu, 28 Mar 2024 02:57:21 +0530 Message-Id: <20240327212720.5964-1-phanindrax.babu.pabba@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 27 Mar 2024 16:11:52 -0700 Reply-To: devel@edk2.groups.io,phanindrax.babu.pabba@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: m4zCm9bjY1tFnOpZu4eqVrwux7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=cd9JqRh1; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: PhanindraX Babu Pabba Adding missed out call to FreePool API to free the allocated memory. Signed-off-by: PhanindraX Babu Pabba Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 5 +++-- Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index 2a833ec9..9a91d131 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -975,7 +975,7 @@ InstallMcfgFromScratch ( FixedPcdGet32 (PcdAcpiDefaultOemRevision) ); if (EFI_ERROR (Status)) { - return Status; + goto Done; } // @@ -1002,7 +1002,8 @@ InstallMcfgFromScratch ( McfgTable->Header.Length, &TableHandle ); - +Done: + FreePool (McfgTable); return Status; } diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c index 9bc22245..f5b1a71c 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c @@ -195,6 +195,7 @@ PublishAcpiTablesFromFv ( // Increment the instance // Instance++; + FreePool (CurrentTable); CurrentTable = NULL; } } -- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117183): https://edk2.groups.io/g/devel/message/117183 Mute This Topic: https://groups.io/mt/105186400/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-