From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6F2A67803CE for ; Fri, 29 Mar 2024 02:32:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=EaTaEnb9ImT5aagy+ZOrsdD2/ueH2uEfsRwqTa4Zhy0=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1711679567; v=1; b=M3qD3Zvwu4ld+MbP/LKNI4tjoJAWnkhmz2uDuoxQo7DbHRBwncJP5QLP3sjJspVCaNyO44Lf 2OQjDshGbYU/wOjx/5sK2fBM3gt7Hq/x7kVLKdousESDiRjglbax8ZE2jRdcaMK3Vq0iJ5Z5QO/ KWXgoGTHEk/FtHE7pGiu9HOlFEu4VVpDAhsLZj5HK+Z+d0BlsdnBN1+M9FWRh/GzIDJWfEPjDqb 427persCN2WXBrHJK4jdswZw3vbZGPiHGYu7IUBO+DXlndG9KSVhNBjh+PFGW3QFPLsTzHmKEq0 FX3GRGoxCz8BhVvIqJQau0PPaupezcdEHfaBhEwz+cDgA== X-Received: by 127.0.0.2 with SMTP id jsfIYY7687511xLSzYnoLUTP; Thu, 28 Mar 2024 19:32:47 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mx.groups.io with SMTP id smtpd.web10.8843.1711679565535436757 for ; Thu, 28 Mar 2024 19:32:46 -0700 X-CSE-ConnectionGUID: Ue6U4iAOQLaVVOJrBS7b4A== X-CSE-MsgGUID: NnXgdAA8QeC97bj+KGlNDA== X-IronPort-AV: E=McAfee;i="6600,9927,11027"; a="6804775" X-IronPort-AV: E=Sophos;i="6.07,162,1708416000"; d="scan'208";a="6804775" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2024 19:32:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,162,1708416000"; d="scan'208";a="54306212" X-Received: from shwdejointd777.ccr.corp.intel.com ([10.239.58.116]) by orviesa001.jf.intel.com with ESMTP; 28 Mar 2024 19:32:45 -0700 From: "Wenxing Hou" To: devel@edk2.groups.io Cc: Jiewen Yao , Yi Li Subject: [edk2-devel] [PATCH 1/3] CryptoPkg: Update OPTIONAL location for BaseCryptLibMbedTls Date: Fri, 29 Mar 2024 10:32:40 +0800 Message-Id: <20240329023242.2443-2-wenxing.hou@intel.com> In-Reply-To: <20240329023242.2443-1-wenxing.hou@intel.com> References: <20240329023242.2443-1-wenxing.hou@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 28 Mar 2024 19:32:46 -0700 Reply-To: devel@edk2.groups.io,wenxing.hou@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: osA3ZjufIhb3dA8Nzzd8gboBx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=M3qD3Zvw; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4740 There is a wrong usage for OPTIONAL. Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou --- .../Library/BaseCryptLibMbedTls/Pk/CryptPkcs1OaepNull.c | 6 ++---- CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptX509Null.c | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs1OaepNull.c = b/CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs1OaepNull.c index a686308652..0273b7b63f 100644 --- a/CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs1OaepNull.c +++ b/CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs1OaepNull.c @@ -38,10 +38,8 @@ Pkcs1v2Encrypt ( IN UINTN PublicKeySize,=0D IN UINT8 *InData,=0D IN UINTN InDataSize,=0D - IN CONST UINT8 *PrngSeed,=0D - OPTIONAL=0D - IN UINTN PrngSeedSize,=0D - OPTIONAL=0D + IN CONST UINT8 *PrngSeed OPTIONAL,=0D + IN UINTN PrngSeedSize OPTIONAL,=0D OUT UINT8 **EncryptedData,=0D OUT UINTN *EncryptedDataSize=0D )=0D diff --git a/CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptX509Null.c b/Cry= ptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptX509Null.c index 8ee3d44435..96356f87fd 100644 --- a/CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptX509Null.c +++ b/CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptX509Null.c @@ -377,8 +377,7 @@ EFIAPI X509GetSerialNumber (=0D IN CONST UINT8 *Cert,=0D IN UINTN CertSize,=0D - OUT UINT8 *SerialNumber,=0D - OPTIONAL=0D + OUT UINT8 *SerialNumber OPTIONAL,=0D IN OUT UINTN *SerialNumberSize=0D )=0D {=0D @@ -441,8 +440,7 @@ EFIAPI X509GetSignatureAlgorithm (=0D IN CONST UINT8 *Cert,=0D IN UINTN CertSize,=0D - OUT UINT8 *Oid,=0D - OPTIONAL=0D + OUT UINT8 *Oid OPTIONAL,=0D IN OUT UINTN *OidSize=0D )=0D {=0D --=20 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117221): https://edk2.groups.io/g/devel/message/117221 Mute This Topic: https://groups.io/mt/105210160/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-