From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8CE66941915 for ; Fri, 29 Mar 2024 20:21:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Hv8JAzGAZ0/Z0sEKX/cvCFLSOY8TGAZohE810SGvbOw=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1711743688; v=1; b=jU598Pdiu0CHr+1pqQqXXjgLxLNwPC35TK3RLILZfaCGVzlwxTOd14wBvniB/1iMxf53Ycjg /GziXg8mDifOXL4VJW2SNuTXGAi+/GYRlcN3xicgEsunbJC5F2qgvo5UjZjUchtNV7ftwqEsiNe tz5+fXJNhM9ZBmZ6klgDU2enDJAnc40fmMTzxtP66kBFZYkifTvlh05Zal2w0PFByAF2CD8KISM 5jumasdVEl82ENH8ZUMv3uTs17aUNsfg1shJwqlhODS31gaccCmC1E7Q1N0gxmqVhAZKqbd1YWJ wOrT3MWeRb8bxIaKOIgmioJP3i2e6R9fDbw4m8a7dFgGQ== X-Received: by 127.0.0.2 with SMTP id Dg45YY7687511x6BSuYSzMlL; Fri, 29 Mar 2024 13:21:28 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.974.1711743685265644307 for ; Fri, 29 Mar 2024 13:21:25 -0700 X-Received: from OSD-Desktop.redmond.corp.microsoft.com (unknown [131.107.159.43]) by linux.microsoft.com (Postfix) with ESMTPSA id B378D20E6F42; Fri, 29 Mar 2024 13:21:24 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B378D20E6F42 From: "Oliver Smith-Denny" To: devel@edk2.groups.io Cc: Liming Gao , Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Taylor Beebe Subject: [edk2-devel] [PATCH v3 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes Date: Fri, 29 Mar 2024 13:21:26 -0700 Message-Id: <20240329202129.12988-1-osde@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 29 Mar 2024 13:21:25 -0700 Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: B6mQSwUzU7FxVzr0zDAgO6MLx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=jU598Pdi; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io ImagePropertiesRecordLib is currently creating Image Records that are not accurate. It is setting the CodeSegmentSize to be the size of the raw data in the image file, however, when the image is loaded into memory, the raw data size is aligned to the section alignment. This caused the memory attributes table to have incorrect entries for systems, like ARM64, where the section alignment is not 4k for all modules. In fixing this, I noticed that MemoryProtection.c is using its own version of image record creation where this logic was actually correct. ImagePropertiesRecordLib was created to consolidate the logic around creating and managing image records, so this patchset also updates MemoryProtection.c to use ImagePropertiesRecordsLib after making a few small adjustments to ensure the same functionality is present. This patchset was tested on ArmVirtQemu to ensure that all image records were the same before and after this, other than fixing the CodeSegmentSize. v3: - Fix merge conflict in MemoryProtection.c v2: - Align VirtualSize instead of SizeOfRawData Github PR: https://github.com/tianocore/edk2/pull/5504 Cc: Liming Gao Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Taylor Beebe Oliver Smith-Denny (3): MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesLib Oliver Smith-Denny (3): MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesLib MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c = | 241 +++----------------- MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.c= | 86 +++++-- 2 files changed, 94 insertions(+), 233 deletions(-) --=20 2.40.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117239): https://edk2.groups.io/g/devel/message/117239 Mute This Topic: https://groups.io/mt/105223002/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-