From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A064A94127D for ; Mon, 1 Apr 2024 06:04:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=cVE80MmOmdkdEdU4Ty59CpvXNkVyg9c8IQZZUBgqtPw=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1711951468; v=1; b=GgxaBAJNnpzHsCRVnuttt+5o73F+yaW85edVvn/UObjsznpPvkUalJsCopCcIiRMqptvCiTk W/1APL/tr6MqPF9wGA/qogCWsYxSmyELmVQjdA1eenSfv4ZcU9WtofR4ok7kx5UgedomVes2WlA vLSATFanlnXLN2SpD+Jcenp2N5vXoj8BXyiBMEme8WLr0I9a2Vh5VJ69E5/ajCEURXS6TlGLjaY zXSwobQnJKFuZ2uQnTN0glOjDzb1ZWuJOxgZIS+ZVym/GIoV0SuoEYLT5hpmGgqjkUKK5bqSnhu beqsLRhJsuZbGGY+7BxTagdr1Siqc4TF6+aDhVSuu7JTg== X-Received: by 127.0.0.2 with SMTP id QA9cYY7687511xyuizVaiU7a; Sun, 31 Mar 2024 23:04:28 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mx.groups.io with SMTP id smtpd.web10.31899.1711951462693257400 for ; Sun, 31 Mar 2024 23:04:27 -0700 X-CSE-ConnectionGUID: is7+zov1TSC5xbjAULjKfw== X-CSE-MsgGUID: am5YfQnuT9igU61BSRW7wQ== X-IronPort-AV: E=McAfee;i="6600,9927,11030"; a="7214029" X-IronPort-AV: E=Sophos;i="6.07,171,1708416000"; d="scan'208";a="7214029" X-Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2024 23:04:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,171,1708416000"; d="scan'208";a="17438914" X-Received: from shwdeopenlab702.ccr.corp.intel.com ([10.239.55.43]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2024 23:04:26 -0700 From: "duntan" To: devel@edk2.groups.io Cc: Ray Ni , Jason Lou , Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong Subject: [edk2-devel] [edk2-platforms V2 1/3] MinPlatformPkg: Remove the global variable mForceX2ApicId Date: Mon, 1 Apr 2024 14:04:09 +0800 Message-Id: <20240401060411.899-2-dun.tan@intel.com> In-Reply-To: <20240401060411.899-1-dun.tan@intel.com> References: <20240401060411.899-1-dun.tan@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 31 Mar 2024 23:04:27 -0700 Reply-To: devel@edk2.groups.io,dun.tan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kbSjXCcx9Fdr3imgyT2yrLtGx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=GgxaBAJN; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io This global variable mForceX2ApicId is not assigned to any value in code and will be initialized to 0 when the driver is loaded. So remove the global variable and related code that will not be executed. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Jason Lou Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index 2a833ec99c..62a7da290a 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -53,7 +53,6 @@ VOID *mLocalTable[] = { EFI_ACPI_TABLE_PROTOCOL *mAcpiTable; UINT32 mNumOfBitShift = 6; -BOOLEAN mForceX2ApicId; BOOLEAN mX2ApicEnabled; EFI_MP_SERVICES_PROTOCOL *mMpService; @@ -163,14 +162,6 @@ CreateCpuLocalApicInTable ( CpuIdMapPtr->Thread = ProcessorInfoBuffer.Location.Thread; CpuIdMapPtr->Flags = ((ProcessorInfoBuffer.StatusFlag & PROCESSOR_ENABLED_BIT) != 0); CpuIdMapPtr->SocketNum = ProcessorInfoBuffer.Location.Package; - - //update processorbitMask - if (CpuIdMapPtr->Flags == 1) { - if (mForceX2ApicId) { - CpuIdMapPtr->SocketNum &= 0x7; - CpuIdMapPtr->AcpiProcessorUid &= 0xFF; //keep lower 8bit due to use Proc obj in dsdt - } - } } else { //not enabled CpuIdMapPtr->ApicId = (UINT32)-1; CpuIdMapPtr->Thread = (UINT32)-1; @@ -1537,7 +1528,6 @@ InstallAcpiPlatform ( } DEBUG ((DEBUG_INFO, "mX2ApicEnabled - 0x%x\n", mX2ApicEnabled)); - DEBUG ((DEBUG_INFO, "mForceX2ApicId - 0x%x\n", mForceX2ApicId)); // support up to 64 threads/socket AsmCpuidEx (CPUID_EXTENDED_TOPOLOGY, 1, &mNumOfBitShift, NULL, NULL, NULL); -- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117279): https://edk2.groups.io/g/devel/message/117279 Mute This Topic: https://groups.io/mt/105259123/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-