public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: <devel@edk2.groups.io>
Cc: Andrew Fish <afish@apple.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: [edk2-devel] [PATCH RESEND V4 6/6] Maintainers: AMD as SPI driver stack maintainer
Date: Thu, 4 Apr 2024 17:10:52 +0800	[thread overview]
Message-ID: <20240404091052.794-7-abner.chang@amd.com> (raw)
In-Reply-To: <20240404091052.794-1-abner.chang@amd.com>

From: Abner Chang <abner.chang@amd.com>

Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
 .../Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlash.c       | 12 ++++++------
 .../Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdp.c  | 12 ++++++------
 Maintainers.txt                                      | 11 +++++++++++
 3 files changed, 23 insertions(+), 12 deletions(-)

diff --git a/MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlash.c b/MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlash.c
index 066a827bf49..3ac5420fbf6 100644
--- a/MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlash.c
+++ b/MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlash.c
@@ -18,7 +18,7 @@
 #include "SpiNorFlash.h"
 
 /**
-  Fill Write Buffer with Opcode, Address, Dummy Bytes, and Data
+  Fill Write Buffer with Opcode, Address, Dummy Bytes, and Data.
 
   @param[in]    Instance               The instance of SPI_NOR_FLASH
   @param[in]    Opcode                 Opcode for transaction
@@ -187,7 +187,7 @@ InternalReadStatus (
 }
 
 /**
-  Set Write Enable Latch
+  Set Write Enable Latch.
 
   @param[in]  Instance          SPI NOR instance with all protocols, etc.
 
@@ -233,7 +233,7 @@ SetWel (
 }
 
 /**
-  Check for not device write in progress
+  Check for not device write in progress.
 
   @param[in]  SpiNorFlashInstance  SPI NOR instance with all protocols, etc.
   @param[in]  Timeout              Timeout in microsecond
@@ -287,7 +287,7 @@ WaitNotWip (
 }
 
 /**
-  Check for write enable latch set and not device write in progress
+  Check for write enable latch set and not device write in progress.
 
   @param[in]  SpiNorFlashInstance  SPI NOR instance with all protocols, etc.
   @param[in]  Timeout              Timeout in microsecond
@@ -342,7 +342,7 @@ WaitWelNotWip (
 }
 
 /**
-  Check for not write enable latch set and not device write in progress
+  Check for not write enable latch set and not device write in progress.
 
   @param[in]  SpiNorFlashInstance  SPI NOR instance with all protocols, etc.
   @param[in]  Timeout              Timeout in microsecond
@@ -462,7 +462,7 @@ GetFlashId (
 }
 
 /**
-  Read data from the SPI flash at not fast speed
+  Read data from the SPI flash at not fast speed.
 
   This routine must be called at or below TPL_NOTIFY.
   This routine reads data from the SPI part in the buffer provided.
diff --git a/MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdp.c b/MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdp.c
index 78327d37ff0..284567d1f4b 100644
--- a/MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdp.c
+++ b/MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdp.c
@@ -755,7 +755,7 @@ CreateSingleFlashSectorMap (
 }
 
 /**
-  Set EraseBlockBytes in SPI NOR Flash Protocol
+  Set EraseBlockBytes in SPI NOR Flash Protocol.
 
   @param[in]  Instance    Spi Nor Flash Instance data with pointer to
                           EFI_SPI_NOR_FLASH_PROTOCOL and EFI_SPI_IO_PROTOCOL
@@ -1173,7 +1173,7 @@ GetFastReadParameter (
 }
 
 /**
-  Return the flash device size from SFDP Basic Flash Parameter Table DWORD 2
+  Return the flash device size from SFDP Basic Flash Parameter Table DWORD 2.
 
   @param[in]  Instance    Spi Nor Flash Instance data with pointer to
                           EFI_SPI_NOR_FLASH_PROTOCOL and
@@ -1361,7 +1361,7 @@ ReadSfdp (
 }
 
 /**
-  Read SFDP Specific Parameter Header
+  Read SFDP Specific Parameter Header.
 
   This routine reads the JEDEC SPI Flash Discoverable Parameter header from the
   SPI chip.  Fails if Major Revision is not = SFDP_SUPPORTED_MAJOR_REVISION.
@@ -1469,7 +1469,7 @@ ReadSfdpParameterHeader (
 }
 
 /**
-  Read from SFDP table pointer
+  Read from SFDP table pointer.
 
   This routine sends SPI_FLASH_RDSFDP command and reads parameter from the
   given TablePointer.
@@ -1556,7 +1556,7 @@ SpiReadSfdpPtp (
 }
 
 /**
-  Read SFDP Sector Map Parameter into buffer
+  Read SFDP Sector Map Parameter into buffer.
 
   This routine reads the JEDEC SPI Flash Discoverable Parameters from the SPI
   chip.
@@ -1623,7 +1623,7 @@ ReadSfdpSectorMapParameterTable (
 }
 
 /**
-  Read SFDP Basic Parameters into buffer
+  Read SFDP Basic Parameters into buffer.
 
   This routine reads the JEDEC SPI Flash Discoverable Parameters from the SPI
   chip.
diff --git a/Maintainers.txt b/Maintainers.txt
index 799f27f914c..7d9cdca611f 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -417,6 +417,11 @@ M: Abner Chang <abner.chang@amd.com> [changab]
 R: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> [abdattar]
 R: Nickle Wang <nicklew@nvidia.com> [nicklela]
 
+MdeModulePkg: SPI driver stack
+F: MdeModulePkg/Bus/Spi/
+M: Abner Chang <abner.chang@amd.com> [changab]
+R: Brit Chesley <brit.chesley@amd.com> [BritChesley]
+
 MdePkg
 F: MdePkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/MdePkg
@@ -450,6 +455,12 @@ M: Abner Chang <abner.chang@amd.com> [changab]
 R: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> [abdattar]
 R: Nickle Wang <nicklew@nvidia.com> [nicklela]
 
+MdePkg: SPI related C header files
+F: MdePkg/Include/Protocol/Spi*.h
+F: MdePkg/Include/IndustryStandard/SpiNorFlashJedecSfdp.h
+M: Abner Chang <abner.chang@amd.com> [changab]
+R: Brit Chesley <brit.chesley@amd.com> [BritChesley]
+
 NetworkPkg
 F: NetworkPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg
-- 
2.37.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117410): https://edk2.groups.io/g/devel/message/117410
Mute This Topic: https://groups.io/mt/105325629/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      parent reply	other threads:[~2024-04-04  9:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04  9:10 [edk2-devel] [PATCH RESEND V4 0/6] SPI NOR Flash Driver for SFDP flash device Chang, Abner via groups.io
2024-04-04  9:10 ` [edk2-devel] [PATCH RESEND V4 1/6] MdePkg/Include: Update definitions of SPI related header files Chang, Abner via groups.io
2024-04-15  8:21   ` Abdul Lateef Attar via groups.io
2024-04-04  9:10 ` [edk2-devel] [PATCH RESEND V4 2/6] MdePkg/Include: Add SPI NOR Flash JEDEC SFDP header file Chang, Abner via groups.io
2024-04-04  9:10 ` [edk2-devel] [PATCH RESEND V4 3/6] MdeModulePkg: Add definitions in DEC for SPI NOR Flash SFDP driver Chang, Abner via groups.io
2024-04-04  9:10 ` [edk2-devel] [PATCH RESEND V4 4/6] MdeModulePkg/SpiNorFlashJedecSfdp: SPI NOR Flash JEDEC SFDP Chang, Abner via groups.io
2024-04-04  9:10 ` [edk2-devel] [PATCH RESEND V4 5/6] MdeModulePkg: Add SPI NOR FLash SFDP drivers to DSC Chang, Abner via groups.io
2024-04-04  9:10 ` Chang, Abner via groups.io [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240404091052.794-7-abner.chang@amd.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox