public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: phillip@axleos.com
To: devel@edk2.groups.io
Cc: phillip@axleos.com, xypron.glpk@gmx.de
Subject: [edk2-devel] [PATCH] OvmfPkg: OVMF supports USB mouses
Date: Fri,  5 Apr 2024 13:58:55 +0100	[thread overview]
Message-ID: <20240405125855.48427-1-phillip@axleos.com> (raw)

From: Phillip Tennen <phillip@axleos.com>

UsbMouseDxe was missing from the OVMF build description, so 
the Simple Pointer Protocol wasn't usable from within QEMU.

Here's an example of somone getting tripped up by this:
https://forum.osdev.org/viewtopic.php?f=1&t=31572.

I worked around this by including the below patch in my local
builds, and was encouraged by Heinrich Schuchardt to submit a patch.

I have not contributed to this project before, so please accept
my apologies if I've formatted anything incorrect. All the best.

Signed-off-by: Phillip Tennen <phillip@axleos.com>

---
 OvmfPkg/OvmfPkgX64.dsc | 1 +
 OvmfPkg/OvmfPkgX64.fdf | 1 +
 2 files changed, 2 insertions(+)

diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
index 56c920168d..d76a263859 100644
--- a/OvmfPkg/OvmfPkgX64.dsc
+++ b/OvmfPkg/OvmfPkgX64.dsc
@@ -953,6 +953,7 @@
   MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf
   MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
   MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
+  MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf
 
 !include OvmfPkg/Include/Dsc/ShellComponents.dsc.inc
 
diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf
index eb3fb90cb8..bfe201a352 100644
--- a/OvmfPkg/OvmfPkgX64.fdf
+++ b/OvmfPkg/OvmfPkgX64.fdf
@@ -342,6 +342,7 @@ INF  MdeModulePkg/Bus/Pci/EhciDxe/EhciDxe.inf
 INF  MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
 INF  MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf
 INF  MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
+INF  MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf
 INF  MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
 
 INF  OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf
-- 
2.39.3 (Apple Git-145)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117459): https://edk2.groups.io/g/devel/message/117459
Mute This Topic: https://groups.io/mt/105348119/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



             reply	other threads:[~2024-04-05 15:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 12:58 phillip [this message]
2024-04-05 13:33 ` [edk2-devel] [PATCH] OvmfPkg: OVMF supports USB mouses Heinrich Schuchardt
2024-04-05 13:43 ` Heinrich Schuchardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240405125855.48427-1-phillip@axleos.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox