From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8464874003D for ; Sat, 6 Apr 2024 12:42:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+xNA9nWEkOi8Se/5OqYFL8SQggWOAGgtt+wdTYHcBZA=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1712407324; v=1; b=qYTcOMqysheExfGgyDmEpgibRG3l9x70sxVjHo+rW1ifBMHCM+MbskNWyvPfDrAleHcM9gPZ NAbXDMjhe/U6Ggv4bPD9O7WfELvcbUS4nrdn9pAznPsYLsDUfE8k/Z+lpvu9S+ZOkqNzMKboeFF x8sN54MolNaGQBM6kh7lNswnPG6DzfhiQq8GBOqKos4wPL+drwUtm/sYqWvtQJkjBkeLc5Uq/ym NCxKuMzvpUL8/ToRhCtpdUcl/bKkPciZAevtC4kktnol96bQkZVj8jSc3jhXnkOBWUQRWdcMVAy xAty/zCs1ytefrKvhqok/N+3macinlt3FgsJweMCZzCbA== X-Received: by 127.0.0.2 with SMTP id vo9LYY7687511xmR194zFXbo; Sat, 06 Apr 2024 05:42:04 -0700 X-Received: from smtp-relay-canonical-0.canonical.com (smtp-relay-canonical-0.canonical.com [185.125.188.120]) by mx.groups.io with SMTP id smtpd.web10.20812.1712407323655017052 for ; Sat, 06 Apr 2024 05:42:04 -0700 X-Received: from LT2ubnt.fritz.box (ip-062-143-245-032.um16.pools.vodafone-ip.de [62.143.245.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 5372A3F2D6; Sat, 6 Apr 2024 12:42:01 +0000 (UTC) From: "Heinrich Schuchardt" To: Ard Biesheuvel , Jiewen Yao , Gerd Hoffmann Cc: devel@edk2.groups.io, Phillip Tennen , Heinrich Schuchardt Subject: [edk2-devel] [PATCH v2 1/1] OvmfPkg: OVMF supports USB mouses Date: Sat, 6 Apr 2024 14:41:54 +0200 Message-ID: <20240406124154.17978-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sat, 06 Apr 2024 05:42:04 -0700 Resent-From: heinrich.schuchardt@canonical.com Reply-To: devel@edk2.groups.io,heinrich.schuchardt@canonical.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: d572LEWx93YLEFhGLnoSFpAWx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=qYTcOMqy; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=canonical.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Phillip Tennen From: Phillip Tennen REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4747 UsbMouseDxe was missing from the OVMF build description, so=3D20 the Simple Pointer Protocol wasn't usable from within QEMU. Here's an example of someone getting tripped up by this: https://forum.osdev.org/viewtopic.php?f=3D1&t=3D31572. Signed-off-by: Phillip Tennen Reviewed-by: Heinrich Schuchardt --- v2: fix formatting problems leading to the patch not being applicable move both insertions below UsbKbDxe update commit message --- OvmfPkg/OvmfPkgX64.dsc | 1 + OvmfPkg/OvmfPkgX64.fdf | 1 + 2 files changed, 2 insertions(+) diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index 56c920168d25..b775db6e0919 100644 --- a/OvmfPkg/OvmfPkgX64.dsc +++ b/OvmfPkg/OvmfPkgX64.dsc @@ -952,6 +952,7 @@ [Components] MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf + MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf =20 !include OvmfPkg/Include/Dsc/ShellComponents.dsc.inc diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf index eb3fb90cb8b6..bfe201a352d0 100644 --- a/OvmfPkg/OvmfPkgX64.fdf +++ b/OvmfPkg/OvmfPkgX64.fdf @@ -342,6 +342,7 @@ [FV.DXEFV] INF MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf +INF MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf =20 INF OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf --=20 2.43.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117467): https://edk2.groups.io/g/devel/message/117467 Mute This Topic: https://groups.io/mt/105365480/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-