From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail03.groups.io (mail03.groups.io [45.79.227.220]) by spool.mail.gandi.net (Postfix) with ESMTPS id 93A06740039 for ; Fri, 12 Apr 2024 14:34:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=//o5g4R1G1u0FIpRms+wa0u/jrfUSMEIStnyWQsJy5Y=; c=relaxed/simple; d=groups.io; h=Received-SPF:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:NoDisclaimer:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1712932456; v=1; b=WtlOVpT+Lswnjk51FWgCFOCkY/1rsUCkzSS1Ci8GLescYiyALKGofd1iABoBVbXS+tQcqWMG 1BGW8ou2G6HLvJ9JhYnPtW1ZLjSr8dTdxDnrcxgtzPWhum8R/TJVp4w+DnpIqAKeROZPSMJrK2B DFCSg8ETzjSyhXItBhmnnqz1CGlhmUMZs944H3e+rqmpPY1v6s6WqjpwGGMMDI+jfIrzvp3Wz5k zeuy7c40PN77qfcxTveaGUxU2zJEGWiuM5+MkJfQ+lpetNap9Fj83Kf4+EQHnDefHz6fWJ9qE9G yIaznU5LKaJ+yw6Tj1m6sVcXpyWYqF7w1ei+hC243xivg== X-Received: by 127.0.0.2 with SMTP id rlMNYY7687511xOc9OSuKyY8; Fri, 12 Apr 2024 07:34:16 -0700 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.72]) by mx.groups.io with SMTP id smtpd.web10.48548.1712932441390815019 for ; Fri, 12 Apr 2024 07:34:01 -0700 X-Received: from AM4PR05CA0027.eurprd05.prod.outlook.com (2603:10a6:205::40) by AM0PR08MB5364.eurprd08.prod.outlook.com (2603:10a6:208:186::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Fri, 12 Apr 2024 14:33:58 +0000 X-Received: from AM3PEPF0000A79B.eurprd04.prod.outlook.com (2603:10a6:205:0:cafe::55) by AM4PR05CA0027.outlook.office365.com (2603:10a6:205::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.25 via Frontend Transport; Fri, 12 Apr 2024 14:33:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM3PEPF0000A79B.mail.protection.outlook.com (10.167.16.106) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 14:33:58 +0000 X-Received: ("Tessian outbound 9fd7e4b543e6:v313"); Fri, 12 Apr 2024 14:33:58 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2973f31685593c11 X-CR-MTA-TID: 64aa7808 X-Received: from 5c920f24e27c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8EB98430-8CB7-4B85-A0C9-72F824BBF394.1; Fri, 12 Apr 2024 14:33:50 +0000 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5c920f24e27c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 12 Apr 2024 14:33:50 +0000 X-Received: from DB7PR03CA0088.eurprd03.prod.outlook.com (2603:10a6:10:72::29) by PAXPR08MB7575.eurprd08.prod.outlook.com (2603:10a6:102:23d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Fri, 12 Apr 2024 14:33:48 +0000 X-Received: from DU2PEPF00028D02.eurprd03.prod.outlook.com (2603:10a6:10:72:cafe::e) by DB7PR03CA0088.outlook.office365.com (2603:10a6:10:72::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.26 via Frontend Transport; Fri, 12 Apr 2024 14:33:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by DU2PEPF00028D02.mail.protection.outlook.com (10.167.242.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 14:33:47 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr 2024 14:33:41 +0000 X-Received: from E114225.Arm.com (10.1.196.56) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Fri, 12 Apr 2024 14:33:41 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , Subject: [edk2-devel] [PATCH v2 32/45] ArmVirtPkg: RMM 1.0-bet1 - Update width of RSI host call struct Date: Fri, 12 Apr 2024 15:33:09 +0100 Message-ID: <20240412143322.5244-33-sami.mujawar@arm.com> In-Reply-To: <20240412143322.5244-1-sami.mujawar@arm.com> References: <20240412143322.5244-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DU2PEPF00028D02:EE_|PAXPR08MB7575:EE_|AM3PEPF0000A79B:EE_|AM0PR08MB5364:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d0fb392-ebea-4005-4625-08dc5afd96d2 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: svkJlAICLNdjPdaUuXDyL0RgUsJniK7Eh/DuI16LyZSqCvfKe4aDalbdfnqH8GyHkkNPXzLAIpqpJCdd4lLiwcXtO9qG8j827oHdK+LfsysTKhNLGYp+N/+JK0bDnr4gyTAfT8Rhp+fW/zCX7uV/10UODJy9QHLDc0xSDsz0ZeGlbN1utYHgiCGoascUqUrqoFHSbLkW67W7L5ojTAkNUFe+VI6przLJMzAUmat37fig8zVvEVYvaHSPt/ipAVslKlOAMxUBGGyVeX/GfPkc4VHrkuC5eG1uTh5oZL+mprnNIb3GBK4Ur9+jdhqDqC0jW1xZrbBGHyFEAph1Ai+ihLL/3hMpvjsOngdCMxAFaPsH9I02cJqfYvC7DqzOgdpS7YcxIdq96vkswIV9nZMYfMVB5MLg5iBy71+30RJ2qSzZhhVeAJiYVR/jGPXIPA5DE3uqijiszyOEPL9GmBx4kl8zPED1AMfirVwKZhO7uWoVcbzFL7s0aQkutKzZrc8QpyD1+DRH2QHfl8VyvRuWk/9ODueX6tIy0hfZ0fAxmCr099xTfECtfQQ+IMDzeWfu/mzd2n9gXAXzw1Ig+fK+BQAbduLJ4MazS6YNhQAOrLZnhR2O792JaduLXMVdsev+fQAehwfxYwxbuZ45osyGFRz+ass8AI9gM05lLd/IOcnkbVrhTdqzPOkcfYerPw4Z/4X+j3h4v1mk/DDKk7aIfBRj9WyhJXaClHkqj8Xh2yFDQFIPYS3C+UY+cZZz51yn X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(1800799015)(82310400014)(36860700004)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7575 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM3PEPF0000A79B.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ce6978c6-e54b-4b0b-aac5-08dc5afd90a2 X-Microsoft-Antispam-Message-Info: dPsHWn5Qqv74hLooEV4CZ3cC/0sjWuz5yhkMDzQ6l2ioeCN1IoOb51m0D1LvcTFJdWw/C3Qud2Ubti76mkP5rWBU3m1AsrETPBt83NiZr8NAsvOUYQEy0T5EMA9RfnOwFtuoKXfsd8iKX8cMvAbkFQzj9h5147mUAoVrmQjkoMr6YQH/7Fy9oeW0CnJPMrl0SYu8s0oflFF+CNZL8mGrvPGWVjQB9j+t77bjU6aqaa4wxqk1jvr/xUL0lwrB4jZg1dWjj/+q81KMaCQMhDRqWXlGidsX0WOa6w3AleZCtOjF74CsEv3iw+8HIDvmLFt1XhAyekhpC6zO22uhQgCM/1f/oFdEYSS8nrju80xwAVAZfzMCk6rpR1lS3ikr4+Ic5Jd/I6CzytlI5o1I9TV3ScGd12CTFxp5yFWNAD4jz0nV25vcf3jNDLjlTf8FfV2RJH/eSy4YjaxhUS++hjiAn5hVhC3hxJQypa8fOTYm8D5JGSICsuJSFmoJ20K3Bn5qiaVc+5HUSN10zHxVuLaYMHYofx2It8HQhRHJv0TdKaNdgz9mpYuu4svtZqIMGC+WhRwNbKq+EA88WmhEt4u5ylEpJMavDofHjKkIVORycXobUFeO2u6CEBI4n21GDvPT4tCzM+vBaWiMpHlKrK3Z/knMDuu6hSAuCBp28jC1S1l5W/BsmMAOFAcatBN5qtO/OFOjzobVQRB39oHfhuc/4UTvMoymxzJZl6UyW829NOQJ2rns5zXq+Lct4fpJfVER X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 14:33:58.2731 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d0fb392-ebea-4005-4625-08dc5afd96d2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A79B.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5364 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 12 Apr 2024 07:34:01 -0700 Resent-From: sami.mujawar@arm.com Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: tNZIWS47lRAFNsjEljNCZnTrx7686176AA= Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=WtlOVpT+; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.227.220 as permitted sender) smtp.mailfrom=bounce@groups.io The RMM 1.0-bet1 updates the width of the RsiHostCall structure to 256 (0x100) bytes. Therefore, update the RSI HOST_CALL_ARGS structure to reflect these changes. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Gerd Hoffmann Signed-off-by: Sami Mujawar --- ArmVirtPkg/Include/Library/ArmCcaRsiLib.h | 6 +++--- ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c | 6 ++++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/ArmVirtPkg/Include/Library/ArmCcaRsiLib.h b/ArmVirtPkg/Include/Library/ArmCcaRsiLib.h index af4be275d37f0376335de5344f9626c9a92c70d2..81d125a81941cc1680cfdfb08e001193851d50e5 100644 --- a/ArmVirtPkg/Include/Library/ArmCcaRsiLib.h +++ b/ArmVirtPkg/Include/Library/ArmCcaRsiLib.h @@ -11,7 +11,7 @@ - REM - Realm Extensible Measurement @par Reference(s): - - Realm Management Monitor (RMM) Specification, version A-bet0 + - Realm Management Monitor (RMM) Specification, version 1.0-bet1 (https://developer.arm.com/documentation/den0137/) **/ @@ -82,7 +82,7 @@ typedef struct RealmConfig { } REALM_CONFIG; /** A structure describing the Host Call arguments - See Section 4.4.2 RsiHostCall type, RMM Specification, version A-bet0 + See Section 4.4.2 RsiHostCall type, RMM Specification, version 1.0-bet1 */ typedef struct HostCallArgs { UINT16 Imm; @@ -95,7 +95,7 @@ typedef struct HostCallArgs { UINT64 Gprs4; UINT64 Gprs5; UINT64 Gprs6; - UINT8 Reserved[0x1000 - (sizeof (UINT64) * 8)]; + UINT8 Reserved[0x100 - (sizeof (UINT64) * 8)]; } HOST_CALL_ARGS; /** diff --git a/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c b/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c index dc41e77b55f4369e89592b5437e525baf80aa0b3..5984651f6d9d627d9fee30a4fbf11c45b3951877 100644 --- a/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c +++ b/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c @@ -11,7 +11,7 @@ - REM - Realm Extensible Measurement @par Reference(s): - - Realm Management Monitor (RMM) Specification, version A-bet0 + - Realm Management Monitor (RMM) Specification, version 1.0-bet1 (https://developer.arm.com/documentation/den0137/) **/ @@ -516,7 +516,9 @@ RsiHostCall ( return RETURN_INVALID_PARAMETER; } - STATIC_ASSERT (sizeof (HOST_CALL_ARGS) == SIZE_4KB); + // See RMM specification, version 1.0-bet1, Section B4.4.2 RsiHostCall type + // The width of the RsiHostCall structure is 256 (0x100) bytes. + STATIC_ASSERT (sizeof (HOST_CALL_ARGS) == 0x100); // Clear the reserved fields ZeroMem (&Args->Reserved1, sizeof (Args->Reserved1)); -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117694): https://edk2.groups.io/g/devel/message/117694 Mute This Topic: https://groups.io/mt/105483434/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-