From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail03.groups.io (mail03.groups.io [45.79.227.220]) by spool.mail.gandi.net (Postfix) with ESMTPS id AC11578003C for ; Fri, 12 Apr 2024 14:34:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=v7nH4eEb8+VGdZLTTrUdsHSQtEK8ExNmNKnVxFxpElM=; c=relaxed/simple; d=groups.io; h=Received-SPF:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:NoDisclaimer:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1712932460; v=1; b=JiEqb1GeDSh5uP3dq0z1pyVqig1F7quLMidE9sl5UntOZ6qxNKpbmdGEmA/kSZTf+eKMDTWL ylRunJiehsihuZOHBHb+veU7R362ZH0jy0LC0Y35ifwTCron4ATu0mRWyZ1o05pLhbCpqyrScLr J/qxvjHdJVkuL7mRVxoD9DsLi9YpVnrLwK5OobHm+iT0v+5pmrn6JxbQ0+H36rnlaYSsiLJaZIe CA5HTcyi5J3md7loa3zos97F20ek/sW/l1Yf6SluwRcyvCMIVBeEhegYaLx/67qpa5ZFgRB+cSF zkcVHzJ/3dQbC8vGWJXqPsZLi6IWJ9J9MpVq0bgCbqbRA== X-Received: by 127.0.0.2 with SMTP id 7K9FYY7687511xbyAUTFGRDg; Fri, 12 Apr 2024 07:34:20 -0700 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.51]) by mx.groups.io with SMTP id smtpd.web10.48558.1712932448630966990 for ; Fri, 12 Apr 2024 07:34:09 -0700 X-Received: from AM9P195CA0013.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:21f::18) by DB9PR08MB7722.eurprd08.prod.outlook.com (2603:10a6:10:391::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr 2024 14:34:05 +0000 X-Received: from AM4PEPF00025F9B.EURPRD83.prod.outlook.com (2603:10a6:20b:21f:cafe::5d) by AM9P195CA0013.outlook.office365.com (2603:10a6:20b:21f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.26 via Frontend Transport; Fri, 12 Apr 2024 14:34:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM4PEPF00025F9B.mail.protection.outlook.com (10.167.16.10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7495.0 via Frontend Transport; Fri, 12 Apr 2024 14:34:04 +0000 X-Received: ("Tessian outbound 9fd7e4b543e6:v313"); Fri, 12 Apr 2024 14:34:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ec8c4ff28e246c03 X-CR-MTA-TID: 64aa7808 X-Received: from 87b11b129f7d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 35292560-01FD-4BCE-9C43-EAEC57C38C99.1; Fri, 12 Apr 2024 14:33:53 +0000 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 87b11b129f7d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 12 Apr 2024 14:33:53 +0000 X-Received: from DB6PR0301CA0073.eurprd03.prod.outlook.com (2603:10a6:6:30::20) by AS1PR08MB7539.eurprd08.prod.outlook.com (2603:10a6:20b:483::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr 2024 14:33:50 +0000 X-Received: from DU2PEPF00028CFF.eurprd03.prod.outlook.com (2603:10a6:6:30:cafe::b4) by DB6PR0301CA0073.outlook.office365.com (2603:10a6:6:30::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.26 via Frontend Transport; Fri, 12 Apr 2024 14:33:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by DU2PEPF00028CFF.mail.protection.outlook.com (10.167.242.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 14:33:50 +0000 X-Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr 2024 14:33:43 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr 2024 14:33:43 +0000 X-Received: from E114225.Arm.com (10.1.196.56) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Fri, 12 Apr 2024 14:33:42 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , Subject: [edk2-devel] [PATCH v2 35/45] ArmVirtPkg: RMM 1.0-eac1 - Relax alignment of RSI host call arg Date: Fri, 12 Apr 2024 15:33:12 +0100 Message-ID: <20240412143322.5244-36-sami.mujawar@arm.com> In-Reply-To: <20240412143322.5244-1-sami.mujawar@arm.com> References: <20240412143322.5244-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DU2PEPF00028CFF:EE_|AS1PR08MB7539:EE_|AM4PEPF00025F9B:EE_|DB9PR08MB7722:EE_ X-MS-Office365-Filtering-Correlation-Id: cd3f35a4-4051-4763-816c-08dc5afd9a94 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jB6y7UGS0lbYLSczCBQYLooDtElTqwh7sCIIqxAzXvY51P3v/UDLMmIhKswS8y4xQ+TfZLQjwj+WZD9wM1WosTLmcSqFmA33kaOW1FJMevMynOm8nSIIHtoz0rQEwBmX9ucfbxaLrhP2i1ChKFfQep4Dpm9cE5HXUHDn+bshz436ZucLiC/+umQAM8uv7hPWgwz1z1H1dKtruOmYHDAmuC/1v4KOo72K0kYuClZaG0LJIs/OfuKqmD/irWR9k2KKC4ErD7czZ8J4DAeEC9mDhdvVLVIdBJ5yXhKxVOSSYPc1R6GAwdqsfJArY+BTfbrk7JpMIbp7x3gVZGtDMVoCPdoiwwqGgeS4g8IRi6XALlSAQ5JsMGDn1Phdpzye6jPi31DhXoJj9CtVy3J5PaAzhNo17MWmyrRzjsfSfQVMVfgK4M9e4P4vdAJ0gQ2vCqmPy4xZL97e1gQHQ/2w1sOWQh/JLy57jd/vlwnNYxbGrrNAcxqL8jqTNIJovT8XVtwAOLPCwFehGL6m6Cg9rNIHoHW7/aH2KBJDHkZa5s3Ctb4H8nEgpKIkKJsyqATK+QlHYyzuSPE2ZSEsAyBNMmeI+I+DtDxg0J+YzsotQrDWT3mhdxE8lzFkmf+Bdz8VICTS6mVN1h4sMtoE3hAuF9KMXP5I4BaobZpvodOBafsDtgL0xS7BPErToU1AxXp67T3qwfhraQN0t2DbhxX3RjJRJ6u9zo+yj2lZkxuEUp6hCQTBzwZ7GBPxwKHkthc2/o9n X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(376005)(82310400014)(36860700004)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7539 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM4PEPF00025F9B.EURPRD83.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8441e32f-029b-4e51-7f96-08dc5afd9206 X-Microsoft-Antispam-Message-Info: MLpsjoZ3MJHU23c+H25IHCjP6JQRS8XPHDKtu9UjbCaf0+7QVPHru/CVmB807UIdjarCuUl8GmdGHr1L9GmEBSTCX6pcGivteZnlj6tW65vFqf/1al2pO/MbRolefkwl25+jJwUFW+D4MHaeOsdE1R2E/FqK757GkwHg76d52gZbRUKq76dQB2wziGqFh+x09pJ96MFfwNRKU8kH2Ux13wsn/jAbX9Po+Rfnsv+hDI9w+2cjMGw21YjvrvoIsmJlc5dhKeJZ0ng/eSA4leXdM4uKQPUhFHsZLYS0XkVaQMraF82n1Hwh2NzmK/QLg66wa3wfeoUC9gUfUCpe3zUI+CO4b3Uy24816/i2zeTxUSggcfUFGZR/ANMANtNZxFnOfdOR9EwlAjycCxQMdm4z9OY9WLpO8JPu9u/28TdJwCG34XLZwJVH5X93f8BTa80rXXrlgfMeUeW9eLPu64VG7bLflzCtD66uW2Q3pk7iNZGu9R6OEjtEEMNagSt69CJm+JJ2I+LRMW3sNC1TUE8KNa7HwkMGFBudoL2eoCCvHsZpp4V/SntCzbAyZZxAaiBsvuC0dIwNQNRD33kglHF2UrE2KQKiK/x9t+MAj+GjmSIJbhTO/MUDMgzH2sUTOmiYW7JcF37jvf1PDcSGOhYfBrLcoYtr2VK01zIcqNROl0S9VmNx8CQ9wgzjlljy9Pw5x1NzeMETx9HHG9qig69UnV+BJFIzPHKkWHRuWNPFSpw= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 14:34:04.5948 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd3f35a4-4051-4763-816c-08dc5afd9a94 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00025F9B.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7722 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 12 Apr 2024 07:34:09 -0700 Resent-From: sami.mujawar@arm.com Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: SbjN5ExDRFDCwMMG4iVtLpttx7686176AA= Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=JiEqb1Ge; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.227.220 as permitted sender) smtp.mailfrom=bounce@groups.io The RMM 1.0-eac1 relaxed the RSI_HOST_CALL alignment requirement from 4KB to 256B. Therefore, update the alignment check for the address parameter of the RSI_HOST_CALL command to relax the alignment requirement to 256 bytes. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Gerd Hoffmann Signed-off-by: Sami Mujawar --- ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c b/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c index 59b9d7a12c82a534280595328347995f1ff51ee2..0280d8e42882ddfb02d0a40c47a6fba7855ba84f 100644 --- a/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c +++ b/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c @@ -11,7 +11,7 @@ - REM - Realm Extensible Measurement @par Reference(s): - - Realm Management Monitor (RMM) Specification, version 1.0-eac0 + - Realm Management Monitor (RMM) Specification, version 1.0-eac1 (https://developer.arm.com/documentation/den0137/) **/ @@ -512,7 +512,11 @@ RsiHostCall ( { ARM_SMC_ARGS SmcCmd; - if ((Args == NULL) || (!AddrIsGranuleAligned ((UINT64 *)Args))) { + // The RMM specification, version 1.0-eac1, relaxes the alignment + // requirement for RSI_HOST_CALL from 4KB to 256B. Also see RMM + // specification, sections B4.3.3 RSI_HOST_CALL command and + // section B4.3.3.2 Failure conditions. + if ((Args == NULL) || (((UINT64)Args & (0x100 - 1)) != 0)) { return RETURN_INVALID_PARAMETER; } -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117705): https://edk2.groups.io/g/devel/message/117705 Mute This Topic: https://groups.io/mt/105483448/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-