From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail03.groups.io (mail03.groups.io [45.79.227.220]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6227AAC134E for ; Fri, 12 Apr 2024 15:14:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qfvL0GC2AM8SEZ+Mft/qtS8g/s20Tj1GyJ6ycjoTU00=; c=relaxed/simple; d=groups.io; h=Received-SPF:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:NoDisclaimer:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1712934844; v=1; b=snXrAlqk7FMrYLxRAD9sBDs935OKzCpyEH1hPMepoQAGit4dkrUDroPklVp0t6irXCfhG+rx pOBmOKTwDEuBrYfbsCWuBGVvR9BKSOHCKso93g28e/zb+WQ95KLdpo2zDMU2e6WgYS23Y90f8oh AUdnhlrmK33H71Wwlg7dVvwsagtdWN66LsAW37zQtXDDXPuSYVix4DpIq4cHJ0JStwq0Re0tUxh 7KH/71UUTH1+K7t9R/Qx9bcmZnXaZ3po1exJnXbdcr58xS4bBW9pxlbkSs/Beos6NaliVaHjWdZ xFEv9/JSgWsXMNXcqWVb5SIBE7tZ4QszPlAWZKEyxqgwQ== X-Received: by 127.0.0.2 with SMTP id 720FYY7687511xsi7l9bsK3x; Fri, 12 Apr 2024 08:14:04 -0700 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.84]) by mx.groups.io with SMTP id smtpd.web10.49602.1712934843178384831 for ; Fri, 12 Apr 2024 08:14:03 -0700 X-Received: from DU2PR04CA0208.eurprd04.prod.outlook.com (2603:10a6:10:28d::33) by AM7PR08MB5397.eurprd08.prod.outlook.com (2603:10a6:20b:dd::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Fri, 12 Apr 2024 15:13:59 +0000 X-Received: from DB5PEPF00014B8F.eurprd02.prod.outlook.com (2603:10a6:10:28d:cafe::90) by DU2PR04CA0208.outlook.office365.com (2603:10a6:10:28d::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.25 via Frontend Transport; Fri, 12 Apr 2024 15:13:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5PEPF00014B8F.mail.protection.outlook.com (10.167.8.203) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 15:13:59 +0000 X-Received: ("Tessian outbound 9fd7e4b543e6:v313"); Fri, 12 Apr 2024 15:13:59 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4f43977a4d758632 X-CR-MTA-TID: 64aa7808 X-Received: from cdf170003071.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F7EEE663-0B4D-47DD-BD30-9F87D9882D74.1; Fri, 12 Apr 2024 15:13:47 +0000 X-Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cdf170003071.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 12 Apr 2024 15:13:47 +0000 X-Received: from AM6PR0202CA0071.eurprd02.prod.outlook.com (2603:10a6:20b:3a::48) by PA6PR08MB10766.eurprd08.prod.outlook.com (2603:10a6:102:3cd::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.53; Fri, 12 Apr 2024 15:13:45 +0000 X-Received: from AMS0EPF00000192.eurprd05.prod.outlook.com (2603:10a6:20b:3a:cafe::f0) by AM6PR0202CA0071.outlook.office365.com (2603:10a6:20b:3a::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.26 via Frontend Transport; Fri, 12 Apr 2024 15:13:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AMS0EPF00000192.mail.protection.outlook.com (10.167.16.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 15:13:44 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr 2024 15:13:43 +0000 X-Received: from E114225.Arm.com (10.1.196.56) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Fri, 12 Apr 2024 15:13:43 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , Subject: [edk2-devel] [PATCH v2 30/45] ArmVirtPkg: ArmCcaRsiLib: Fix incorrect RSI version masks Date: Fri, 12 Apr 2024 16:13:37 +0100 Message-ID: <20240412151341.16488-2-sami.mujawar@arm.com> In-Reply-To: <20240412151341.16488-1-sami.mujawar@arm.com> References: <20240412151341.16488-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AMS0EPF00000192:EE_|PA6PR08MB10766:EE_|DB5PEPF00014B8F:EE_|AM7PR08MB5397:EE_ X-MS-Office365-Filtering-Correlation-Id: d862a241-4e83-4720-10a2-08dc5b032e21 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: aLMZX1IPUL9ZMAjkBwNiWUTss2XGb2h1JeLg/hi5+O+w34orZZla9x63mcEaUICThGnNpyg5AAzsyC1dHjzmf2PJL7Ua+9PSI5BBUv6XqO/2epH8ZOM5s6ignfn/zURJ2Peu78wZGOJmOt/sNUoygVRJn5ZchAH7MuXbK4gwnYTD56bl2skoYckn4MYyk/VbLCUn6ksRnQuNd+PRJmy2Kpm3Ox5hzSl62q//e/QlWdLrfr/ljjjryEexMrRUVrrG9E2UnFmlKmwGTbqvklH803TmfYQPXCNOJu8pCVDdL1SLArXkQKve6kgVeMFG0mu7OBUOgTUx1mtaAH+K10qGlSM0KNEUOQw7ik5Ynr4d3qiTzzvHcPxIq/wZMRaDatJklWfHmcdK+RcLmZSduN2y3UiiH+Ilo7B41tGUL7nxO/fvBbsI84GnykzT+QPM5qSZjjyXdRGtcuSWcJwRWRnqf32pbqOlai8US9LYUXvt04QzAtUBKwl8kUJzyXPtLVC8/cTldRAr473N6tee8M7T9qJZgY4D9O66o/Wq5Vf5XktU2xhDAh3Nsky36674i5gz2Y14D80sb0aaCXKdMEVt5a3Hm66Sl0Y6WHupE1X0mFfcT1PCzGUj/HmG2wyk5GD2Yyx5qAzTGnA9TK/VzDSCY/mOwxpGXjrTFJTWsWdjPNpUiUtfOOx1EfvqL9Rg73MDjnlp1m0Apbc2pytBg/KEC+0J8jmRSqtitrcqRqLL/LfxzX3BlNIItvXmjZRZNWJV X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(82310400014)(376005)(1800799015)(36860700004);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR08MB10766 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5PEPF00014B8F.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 078627f8-1a37-4ceb-97dc-08dc5b03255d X-Microsoft-Antispam-Message-Info: ac3ML4otJx7q8esM7v8ZXSoz/2jJ/YR0QmMfdQNxEgwbEy+7Na84+CaiT3qe4DMqFcvKs5Zn9tYZwAaHu4KIY3V7LBDgmnpmv/M3ww8JSFHjOP+e9i36HUwyvFjCSdajwcIIvFLUDZaANg8y5tEMJpMX44srrWAkyh0t2h5pOx2TTlq3UBfrf4Rs3j9TW7yYLtdxHdU+GOfsQ74fszf6opdceCF9xEGQYvvIdfLNgMWi0pICZBHPaVe5OxZU3LZ1ERasF+95ClVK/YVl2Nt8n7dfd1zuXoZyFNNshprW7K21Ew2C18xdE6XRdcL0UHeIeR9ST05TLaG/tCc847OUnketLUK62IEwf0KgfiSgXUbo8HgSR3sqcl5oDCoNkcsfHQmcf7kdC+eMYeFpM9F3EQ6d2ISVDOgbjv3THptITPlMmcQor6TckMUhsHl3WpV1JWDJOyw347q96zCE/KmPt+/qqlm3j8E3QLPkwCzFryQY+ymMzFO+hu01greiUVTM9jQq++KbBDAmaLIdQbUUShtJSP3WxFQGRP1U9yPr1EeWw8+xRUfoBKpbQ05kDZAQji+bKm9cLt/hNR3PBDkfrgIOZDfJeP++HzJbnTvsr73cN5fWu6qq/36wUbUmIwiK3k+On4Juv+8gqjwOUB+NtvrAf1skwARWMnpZy3oihQGEAojXHyU/1iz8vKMoM2ijPWHcwVCmfet29EXbSf03GmQ/pMyFSOAT/OxizElnU/sMWIQfJIQQhjdSvHqbPjm4 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 15:13:59.6716 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d862a241-4e83-4720-10a2-08dc5b032e21 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B8F.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5397 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 12 Apr 2024 08:14:03 -0700 Resent-From: sami.mujawar@arm.com Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: B1emm4zIU8Ce95swIGA5d6fyx7686176AA= Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=snXrAlqk; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.227.220 as permitted sender) smtp.mailfrom=bounce@groups.io The RsiInterfaceVersion fieldset contains an RSI interface version and the width of this fieldset is 64 bits. The bits 15:0 of this fieldset represent the RSI minor revision number and the bits 30:16 represent the major revision number. The remaining bits 63:31 are reserved and should be zero. The RSI version masks were incorrectly defined which resulted in an incorrect RSI version being returned by RsiGetVersion (). Therefore, fix the RSI version masks to reflect the bit fields defined by the RMM specification. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Gerd Hoffmann Signed-off-by: Sami Mujawar --- ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsi.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsi.h b/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsi.h index 70e84a20711f04c32a5850230cc907a6d231f50b..b1c359e2486c20ee19493b10ed3fcef1e20f2689 100644 --- a/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsi.h +++ b/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsi.h @@ -41,8 +41,8 @@ See Section B4.4.3, RMM Specification, version A-bet0. The width of the RsiInterfaceVersion fieldset is 64 bits. */ -#define RSI_VER_MINOR_MASK 0x00FFULL -#define RSI_VER_MAJOR_MASK 0x7F00ULL +#define RSI_VER_MINOR_MASK 0x0000FFFFULL +#define RSI_VER_MAJOR_MASK 0x7FFF0000ULL #define RSI_VER_MAJOR_SHIFT 16 #endif // ARM_CCA_RSI_H_ -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117712): https://edk2.groups.io/g/devel/message/117712 Mute This Topic: https://groups.io/mt/105484263/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-