From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6FECD740048 for ; Mon, 15 Apr 2024 19:47:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=SnALUDvGdOZZYrwGp2648M1YXhzReEvYAKcU3o6S8os=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20240206; t=1713210431; v=1; b=lpqxf9LpJ85AwL6vkev7R7AjeUwehHCBQARwJPTnBeUAqvSeXKuA4LhkcVakcGX/ZyBOstfq 4ww+ZH5TgudKpSC2WwA4VzRYEj63TMC1m62cLTE8YvQcrpidGwOVHLqjtsQ/zHY4ddz89Tcmh/1 ix0Def0xLbsK2j9VHlMf65cOVMkLkg2p7jnbuoZ6V7mKeruZJDm62TNUhCAVg+z6WpkG3ZCfQCS GJrQeeiG4fpRIHt9NeZR674rRB3enmG/kXp3jd1GgVflSzKQu7eF3Uifyj7RwnVg5ZGVYRjFlUt I6P/LEzEcbVYK7gS5KSH5gz8OUiFVfDIdEPaWmfW7KFXA== X-Received: by 127.0.0.2 with SMTP id 6GDgYY7687511xpB3DwKNzDi; Mon, 15 Apr 2024 12:47:11 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.2410.1713210430348834949 for ; Mon, 15 Apr 2024 12:47:10 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-458-IhGxRH_5Mea1TFgeYkgi0A-1; Mon, 15 Apr 2024 15:47:06 -0400 X-MC-Unique: IhGxRH_5Mea1TFgeYkgi0A-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B4083801788; Mon, 15 Apr 2024 19:47:05 +0000 (UTC) X-Received: from osteffen-laptop.redhat.com (unknown [10.39.192.92]) by smtp.corp.redhat.com (Postfix) with ESMTP id 20E0540C1435; Mon, 15 Apr 2024 19:47:04 +0000 (UTC) From: "Oliver Steffen" To: devel@edk2.groups.io Cc: Oliver Steffen , Bob Feng , Gerd Hoffmann , Jiewen Yao , Laszlo Ersek , Liming Gao , Rahul Kumar , Rebecca Cran , Yuwei Chen Subject: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Warn if out of space when writing variables Date: Mon, 15 Apr 2024 21:46:37 +0200 Message-ID: <20240415194637.276959-2-osteffen@redhat.com> In-Reply-To: <20240415194637.276959-1-osteffen@redhat.com> References: <20240415194637.276959-1-osteffen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 15 Apr 2024 12:47:10 -0700 Resent-From: osteffen@redhat.com Reply-To: devel@edk2.groups.io,osteffen@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vcnG22Qd0gm0k8SOnXhVl211x7686176AA= Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=lpqxf9Lp; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io Emit a DEBUG_ERROR message if there is not enough flash variable left to write/update a variable. This condition is currently not logged appropriately in all cases, given that full variable store can easily render the system unbootable. This new message helps identifying this condition. Cc: Bob Feng Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Laszlo Ersek Cc: Liming Gao Cc: Rahul Kumar Cc: Rebecca Cran Cc: Yuwei Chen Signed-off-by: Oliver Steffen Reviewed-by: Laszlo Ersek --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c index d394d237a53f..97317270c4a7 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c @@ -2364,6 +2364,8 @@ UpdateVariable ( ); ASSERT_EFI_ERROR (Status); } + } else if (Status == EFI_OUT_OF_RESOURCES) { + DEBUG ((DEBUG_ERROR, "UpdateVariable failed: Out of variable space\n")); } return Status; -- 2.44.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117804): https://edk2.groups.io/g/devel/message/117804 Mute This Topic: https://groups.io/mt/105543779/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-