From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id DEC7B940F6C for ; Tue, 16 Apr 2024 02:41:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=dEo5MlOW2iZ9dSaUEvVTVs7u57tb8TqyIa54fuTCitQ=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1713235286; v=1; b=g+vu9RJH2WqJkB8YQCO/H3LYvrWf8bOWPUDxMlpt3nKviqjqAq4ilNjDOgvK7lV6xsHgIlN8 TR+lhipFFEyAyz1T0FQae6PUzzvI8T/Xj2Iakfyrr9mxz4SBFvYfKvjNpB4egnGhFDIdgZ2/fFk dNF/trbVw+zbceUkTczLopAD+LNSlguEAUr2oH+2JJt7oe+/TIGauwBsVIGc0PYKWw2ubZJM3ys Blfrx6y0P7syoSj/wuejbSb4acSQjlEHMQc/Y76gb3hzxVmwMOM99vaIXgbfzNTlFn0MJwj1oLu hOsj5+XaG3PFaS7rXphwkW1AKE3RTGZ3I5ZIFeNUi27YA== X-Received: by 127.0.0.2 with SMTP id G6gHYY7687511xqzC5Fr7ki9; Mon, 15 Apr 2024 19:41:26 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by mx.groups.io with SMTP id smtpd.web10.11001.1713235276662353128 for ; Mon, 15 Apr 2024 19:41:26 -0700 X-CSE-ConnectionGUID: K1CvJvORQ2CZQDsJLOdL9A== X-CSE-MsgGUID: ACILm+lLTymo2AAOq1bd7A== X-IronPort-AV: E=McAfee;i="6600,9927,11045"; a="9205583" X-IronPort-AV: E=Sophos;i="6.07,204,1708416000"; d="scan'208";a="9205583" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 19:41:26 -0700 X-CSE-ConnectionGUID: tngVKNBQTaqlaggi3Tbe9Q== X-CSE-MsgGUID: SGSDb1neTVeHcdjVzJs1qg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,204,1708416000"; d="scan'208";a="59553315" X-Received: from shwdesfp01.ccr.corp.intel.com ([10.239.158.151]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 19:41:24 -0700 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Zhiguang Liu , Liming Gao , Jiaxin Wu , Ray Ni , Laszlo Ersek , Ard Biesheuvel , Sami Mujawar Subject: [edk2-devel] [PATCH v4 4/6] Revert ae1079b386a597108a8070652bf7cdaa4ec3dda3 Date: Tue, 16 Apr 2024 10:41:06 +0800 Message-Id: <20240416024108.1358-5-zhiguang.liu@intel.com> In-Reply-To: <20240416024108.1358-1-zhiguang.liu@intel.com> References: <20240416024108.1358-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 15 Apr 2024 19:41:26 -0700 Resent-From: zhiguang.liu@intel.com Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ROVeSBPN1Jf0DxVF9sMMVBaHx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=g+vu9RJH; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io This reverts "MdeModulePkg/SMM: Support to unregister SMI handler inside SMI handler" for better design later. Cc: Liming Gao Cc: Jiaxin Wu Cc: Ray Ni Cc: Laszlo Ersek Reviewed-by: Ray Ni Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Sami Mujawar Signed-off-by: Zhiguang Liu --- MdeModulePkg/Core/PiSmmCore/Smi.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/MdeModulePkg/Core/PiSmmCore/Smi.c b/MdeModulePkg/Core/PiSmmCore/Smi.c index 3489c130fd..2985f989c3 100644 --- a/MdeModulePkg/Core/PiSmmCore/Smi.c +++ b/MdeModulePkg/Core/PiSmmCore/Smi.c @@ -134,14 +134,8 @@ SmiManage ( Head = &SmiEntry->SmiHandlers; - for (Link = Head->ForwardLink; Link != Head;) { + for (Link = Head->ForwardLink; Link != Head; Link = Link->ForwardLink) { SmiHandler = CR (Link, SMI_HANDLER, Link, SMI_HANDLER_SIGNATURE); - // - // To support unregister SMI handler inside SMI handler itself, - // get next node before handler is executed, since LIST_ENTRY that - // Link points to may be freed if unregister SMI handler. - // - Link = Link->ForwardLink; Status = SmiHandler->Handler ( (EFI_HANDLE)SmiHandler, -- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117821): https://edk2.groups.io/g/devel/message/117821 Mute This Topic: https://groups.io/mt/105550118/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-