From: "Stuart Yoder" <stuart.yoder@arm.com>
To: devel@edk2.groups.io, Edhaya.Chandran@arm.com, gaojie@byosoft.com.cn
Cc: Alex_Fox@phoenix.com, heinrich.schuchardt@canonical.com,
David_Wright@phoenix.com, lichao@loongson.cn
Subject: [edk2-devel] [PATCH v2 3/4] uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
Date: Tue, 16 Apr 2024 09:54:00 -0500 [thread overview]
Message-ID: <20240416145401.3213797-4-stuart.yoder@arm.com> (raw)
In-Reply-To: <20240416145401.3213797-1-stuart.yoder@arm.com>
Fix compiler warning by adding #pragma pack() to close a pragma
section. Also delete extraneous #pragma pack(1).
Signed-off-by: Stuart Yoder <stuart.yoder@arm.com>
Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h
index deba13f21804..95307b7fa50f 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h
@@ -79,7 +79,6 @@ typedef struct {
UINT8 buffer[TEST_STRING_LEN];
} TPM2B_MAX_BUFFER;
-#pragma pack(1)
// TPM2B_DIGEST as defined in Table 73 of TPM Library Spec Part 2: Structures
typedef struct {
UINT16 size;
@@ -110,7 +109,7 @@ typedef struct {
TPM2B_DIGEST data;
TPMT_TK_HASHCHECK validation;
} TPM2_HASH_RESPONSE;
-#pragma
+#pragma pack()
EFI_STATUS
EFIAPI
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117885): https://edk2.groups.io/g/devel/message/117885
Mute This Topic: https://groups.io/mt/105558008/7686176
Mute #pragma:https://edk2.groups.io/g/devel/mutehashtag/pragma
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-04-16 14:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 14:53 [edk2-devel] [PATCH v2 0/4] TCG2 protocol clean up Stuart Yoder
2024-04-16 14:53 ` [edk2-devel] [PATCH v2 1/4] uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct Stuart Yoder
2024-04-24 11:16 ` G Edhaya Chandran
2024-04-24 11:32 ` G Edhaya Chandran
2024-04-24 11:36 ` G Edhaya Chandran
2024-04-24 13:58 ` Stuart Yoder
2024-04-25 5:40 ` G Edhaya Chandran
2024-04-16 14:53 ` [edk2-devel] [PATCH v2 2/4] uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets Stuart Yoder
2024-04-24 11:17 ` G Edhaya Chandran
2024-04-16 14:54 ` Stuart Yoder [this message]
2024-04-24 11:17 ` [edk2-devel] [PATCH v2 3/4] uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup G Edhaya Chandran
2024-04-16 14:54 ` [edk2-devel] [PATCH v2 4/4] uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings Stuart Yoder
2024-04-24 11:17 ` G Edhaya Chandran
2024-04-22 19:15 ` [edk2-devel] [PATCH v2 0/4] TCG2 protocol clean up Heinrich Schuchardt
2024-04-23 9:52 ` G Edhaya Chandran
2024-05-03 23:47 ` [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // " G Edhaya Chandran
2024-05-05 22:21 ` [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 Heinrich Schuchardt
2024-05-06 17:26 ` G Edhaya Chandran
2024-05-09 20:23 ` [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up David Wright
2024-05-10 2:43 ` G Edhaya Chandran
2024-05-10 2:55 ` Chao Li
2024-05-10 14:56 ` G Edhaya Chandran
2024-05-11 2:47 ` Chao Li
[not found] ` <17CE4F3DF61B149E.21609@groups.io>
2024-05-13 6:21 ` Chao Li
2024-05-13 15:21 ` G Edhaya Chandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416145401.3213797-4-stuart.yoder@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox