From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id CD7C8740032 for ; Thu, 18 Apr 2024 06:56:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YAAuLHD6QHmlVC3d7mbE9Yrm/NrMNwj0p5VSoJrWuoA=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe; s=20240206; t=1713423373; v=1; b=eoJhMVF4Mxcp2/ve2vScJfOG+Md7r+c7pJNL6ZWloLHQqrGHykHDzjIzFdSp7lmESBVR46tl pPkHsu8rgYMpYmHYrp/acU/eUp4gUvupwaJQKStM2GkB52sHBloDFY30+a4CDtMgWNL6Ld9wx5r eaA4yBDq9cgopLfrO96grcnuulqt5Geme0NBkCC3QUUtKkmENVRAX+1bWMe0p7uZpCTIa/Ka0Mh kWL8PlXdMt/friWrOBL649JQX4L/jVKas/CsDKeZ4t5EYneclLbsWqZb7lloEOtpQWqUaZaFCBi G4f0GssxSEZMdFoKto8uhGX3E7xt1o8aKgr3XTZpzZ27w== X-Received: by 127.0.0.2 with SMTP id NVnuYY7687511xOEOzTEzDpu; Wed, 17 Apr 2024 23:56:13 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mx.groups.io with SMTP id smtpd.web10.7041.1713423363789669653 for ; Wed, 17 Apr 2024 23:56:12 -0700 X-CSE-ConnectionGUID: 9LQoh8t/SZ+uzQKJ0YwNkA== X-CSE-MsgGUID: sbCFCbDQTTCIrWtu2RTa9Q== X-IronPort-AV: E=McAfee;i="6600,9927,11047"; a="8822214" X-IronPort-AV: E=Sophos;i="6.07,211,1708416000"; d="scan'208";a="8822214" X-Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2024 23:56:11 -0700 X-CSE-ConnectionGUID: cJNuoMtsTGuup9pLJC3obA== X-CSE-MsgGUID: DmmBkBlJSk+Nz7AfoavA0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,211,1708416000"; d="scan'208";a="22754942" X-Received: from sh1gapp1009.ccr.corp.intel.com ([10.239.189.219]) by orviesa010.jf.intel.com with ESMTP; 17 Apr 2024 23:56:09 -0700 From: "Wu, Jiaxin" To: devel@edk2.groups.io Cc: Ray Ni , Zeng Star , Gerd Hoffmann , Rahul Kumar Subject: [edk2-devel] [PATCH v3 04/13] UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory allocation Date: Thu, 18 Apr 2024 14:55:47 +0800 Message-Id: <20240418065556.5696-5-jiaxin.wu@intel.com> In-Reply-To: <20240418065556.5696-1-jiaxin.wu@intel.com> References: <20240418065556.5696-1-jiaxin.wu@intel.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 17 Apr 2024 23:56:12 -0700 Resent-From: jiaxin.wu@intel.com Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 15Pm1h3zYRB6NHFN7t6gCQPex7686176AA= X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=eoJhMVF4; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Since SMM relocation is performed serially for each CPU, there is no need to allocate buffers for all CPUs to store the SmBase address in mSmBase and the Rebased flag in mRebased. A defined global variable is sufficient. This patch focuses on the mSmBase and mRebased global variables to prevent unnecessary memory allocation for these variables. Cc: Ray Ni Cc: Zeng Star Cc: Gerd Hoffmann Cc: Rahul Kumar Signed-off-by: Jiaxin Wu --- .../Library/SmmRelocationLib/SmmRelocationLib.c | 201 +++++++++------------ 1 file changed, 90 insertions(+), 111 deletions(-) diff --git a/UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.c b/UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.c index ca98f06a05..3694a07cbb 100644 --- a/UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.c +++ b/UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.c @@ -25,31 +25,57 @@ EFI_PROCESSOR_INFORMATION *mProcessorInfo = NULL; // IDT used during SMM Init // IA32_DESCRIPTOR gcSmmInitIdtr; // -// Smbase for all CPUs +// Smbase for current CPU // -UINT64 *mSmBase = NULL; +UINT64 mSmBase; // -// SmBase Rebased flag for all CPUs +// SmBase Rebased flag for current CPU // -volatile BOOLEAN *mRebased; +volatile BOOLEAN mRebased; + +/** + This function will get the SmBase for CpuIndex. + + @param[in] CpuIndex The processor index. + @param[in] SmmRelocationStart The start address of Smm relocated memory in SMRAM. + @param[in] TileSize The total size required for a CPU save state, any + additional CPU-specific context and the size of code + for the SMI entry point. + + @retval The value of SmBase for CpuIndex. + +**/ +UINTN +GetSmBase ( + IN UINTN CpuIndex, + IN EFI_PHYSICAL_ADDRESS SmmRelocationStart, + IN UINTN TileSize + ) +{ + return (UINTN)(SmmRelocationStart) + CpuIndex * TileSize - SMM_HANDLER_OFFSET; +} /** This function will create SmBase for all CPUs. - @param[in] SmBase Pointer to SmBase for all CPUs. + @param[in] SmmRelocationStart The start address of Smm relocated memory in SMRAM. + @param[in] TileSize The total size required for a CPU save state, any + additional CPU-specific context and the size of code + for the SMI entry point. @retval EFI_SUCCESS Create SmBase for all CPUs successfully. @retval Others Failed to create SmBase for all CPUs. **/ EFI_STATUS CreateSmmBaseHob ( - IN UINT64 *SmBase + IN EFI_PHYSICAL_ADDRESS SmmRelocationStart, + IN UINTN TileSize ) { UINTN Index; SMM_BASE_HOB_DATA *SmmBaseHobData; UINT32 CpuCount; @@ -90,11 +116,11 @@ CreateSmmBaseHob ( DEBUG ((DEBUG_INFO, "CreateSmmBaseHob - SmmBaseHobData[%d]->NumberOfProcessors: %d\n", HobCount, SmmBaseHobData->NumberOfProcessors)); for (Index = 0; Index < SmmBaseHobData->NumberOfProcessors; Index++) { // // Calculate the new SMBASE address // - SmmBaseHobData->SmBase[Index] = SmBase[Index + CpuCount]; + SmmBaseHobData->SmBase[Index] = GetSmBase (Index + CpuCount, SmmRelocationStart, TileSize); DEBUG ((DEBUG_INFO, "CreateSmmBaseHob - SmmBaseHobData[%d]->SmBase[%d]: 0x%08x\n", HobCount, Index, SmmBaseHobData->SmBase[Index])); } CpuCount += NumberOfProcessorsInHob; HobCount++; @@ -126,18 +152,18 @@ SmmInitHandler ( for (Index = 0; Index < mNumberOfCpus; Index++) { if (ApicId == (UINT32)mProcessorInfo[Index].ProcessorId) { // // Configure SmBase. // - ConfigureSmBase (mSmBase[Index]); + ConfigureSmBase (mSmBase); // // Hook return after RSM to set SMM re-based flag // SMM re-based flag can't be set before RSM, because SMM save state context might be override // by next AP flow before it take effect. // - SemaphoreHook (Index, &mRebased[Index]); + SemaphoreHook (Index, &mRebased); return; } } ASSERT (FALSE); @@ -145,14 +171,22 @@ SmmInitHandler ( /** Relocate SmmBases for each processor. Execute on first boot and all S3 resumes + @param[in] MpServices2 Pointer to this instance of the MpServices. + @param[in] SmmRelocationStart The start address of Smm relocated memory in SMRAM. + @param[in] TileSize The total size required for a CPU save state, any + additional CPU-specific context and the size of code + for the SMI entry point. + **/ VOID SmmRelocateBases ( - VOID + IN EDKII_PEI_MP_SERVICES2_PPI *MpServices2, + IN EFI_PHYSICAL_ADDRESS SmmRelocationStart, + IN UINTN TileSize ) { UINT8 BakBuf[BACK_BUF_SIZE]; SMRAM_SAVE_STATE_MAP BakBuf2; SMRAM_SAVE_STATE_MAP *CpuStatePtr; @@ -196,17 +230,18 @@ SmmRelocateBases ( // Relocate SM bases for all APs // This is APs' 1st SMI - rebase will be done here, and APs' default SMI handler will be overridden by gcSmmInitTemplate // BspIndex = (UINTN)-1; for (Index = 0; Index < mNumberOfCpus; Index++) { - mRebased[Index] = FALSE; if (BspApicId != (UINT32)mProcessorInfo[Index].ProcessorId) { + mRebased = FALSE; + mSmBase = GetSmBase (Index, SmmRelocationStart, TileSize); SendSmiIpi ((UINT32)mProcessorInfo[Index].ProcessorId); // // Wait for this AP to finish its 1st SMI // - while (!mRebased[Index]) { + while (!mRebased) { } } else { // // BSP will be Relocated later // @@ -216,16 +251,18 @@ SmmRelocateBases ( // // Relocate BSP's SMM base // ASSERT (BspIndex != (UINTN)-1); + mRebased = FALSE; + mSmBase = GetSmBase (BspIndex, SmmRelocationStart, TileSize); SendSmiIpi (BspApicId); // // Wait for the BSP to finish its 1st SMI // - while (!mRebased[BspIndex]) { + while (!mRebased) { } // // Restore contents at address 0x38000 // @@ -382,87 +419,10 @@ SplitSmramHobForSmmRelocation ( ZeroMem (&GuidHob->Name, sizeof (GuidHob->Name)); return EFI_SUCCESS; } -/** - This function will initialize SmBase for all CPUs. - - @param[in,out] SmBase Pointer to SmBase for all CPUs. - - @retval EFI_SUCCESS Initialize SmBase for all CPUs successfully. - @retval Others Failed to initialize SmBase for all CPUs. - -**/ -EFI_STATUS -InitSmBaseForAllCpus ( - IN OUT UINT64 **SmBase - ) -{ - EFI_STATUS Status; - UINTN TileSize; - UINT64 SmmRelocationSize; - EFI_PHYSICAL_ADDRESS SmmRelocationStart; - UINTN Index; - - SmmRelocationStart = 0; - - ASSERT (SmBase != NULL); - - // - // Calculate SmmRelocationSize for all of the tiles. - // - // The CPU save state and code for the SMI entry point are tiled within an SMRAM - // allocated buffer. The minimum size of this buffer for a uniprocessor system - // is 32 KB, because the entry point is SMBASE + 32KB, and CPU save state area - // just below SMBASE + 64KB. If more than one CPU is present in the platform, - // then the SMI entry point and the CPU save state areas can be tiles to minimize - // the total amount SMRAM required for all the CPUs. The tile size can be computed - // by adding the CPU save state size, any extra CPU specific context, and - // the size of code that must be placed at the SMI entry point to transfer - // control to a C function in the native SMM execution mode. This size is - // rounded up to the nearest power of 2 to give the tile size for a each CPU. - // The total amount of memory required is the maximum number of CPUs that - // platform supports times the tile size. - // - TileSize = SIZE_8KB; - SmmRelocationSize = EFI_PAGES_TO_SIZE (EFI_SIZE_TO_PAGES (SIZE_32KB + TileSize * (mMaxNumberOfCpus - 1))); - - // - // Split SmramReserve HOB to reserve SmmRelocationSize for Smm relocated memory - // - Status = SplitSmramHobForSmmRelocation ( - SmmRelocationSize, - &SmmRelocationStart - ); - if (EFI_ERROR (Status)) { - return Status; - } - - ASSERT (SmmRelocationStart != 0); - DEBUG ((DEBUG_INFO, "InitSmBaseForAllCpus - SmmRelocationSize: 0x%08x\n", SmmRelocationSize)); - DEBUG ((DEBUG_INFO, "InitSmBaseForAllCpus - SmmRelocationStart: 0x%08x\n", SmmRelocationStart)); - - // - // Init SmBase - // - *SmBase = (UINT64 *)AllocatePages (EFI_SIZE_TO_PAGES (sizeof (UINT64) * mMaxNumberOfCpus)); - if (*SmBase == NULL) { - return EFI_OUT_OF_RESOURCES; - } - - for (Index = 0; Index < mMaxNumberOfCpus; Index++) { - // - // Return each SmBase in SmBase - // - (*SmBase)[Index] = (UINTN)(SmmRelocationStart)+ Index * TileSize - SMM_HANDLER_OFFSET; - DEBUG ((DEBUG_INFO, "InitSmBaseForAllCpus - SmBase For CPU[%d]: 0x%08x\n", Index, (*SmBase)[Index])); - } - - return EFI_SUCCESS; -} - /** CPU SmmBase Relocation Init. This function is to relocate CPU SmmBase. @@ -476,17 +436,21 @@ EFI_STATUS EFIAPI SmmRelocationInit ( IN EDKII_PEI_MP_SERVICES2_PPI *MpServices2 ) { - EFI_STATUS Status; - UINTN NumberOfEnabledCpus; - UINTN SmmStackSize; - UINT8 *SmmStacks; - UINTN Index; + EFI_STATUS Status; + UINTN NumberOfEnabledCpus; + UINTN TileSize; + UINT64 SmmRelocationSize; + EFI_PHYSICAL_ADDRESS SmmRelocationStart; + UINTN SmmStackSize; + UINT8 *SmmStacks; + UINTN Index; - SmmStacks = NULL; + SmmRelocationStart = 0; + SmmStacks = NULL; DEBUG ((DEBUG_INFO, "SmmRelocationInit Start \n")); if (MpServices2 == NULL) { return EFI_INVALID_PARAMETER; } @@ -528,17 +492,43 @@ SmmRelocationInit ( } } } // - // Initialize the SmBase for all CPUs + // Calculate SmmRelocationSize for all of the tiles. // - Status = InitSmBaseForAllCpus (&mSmBase); + // The CPU save state and code for the SMI entry point are tiled within an SMRAM + // allocated buffer. The minimum size of this buffer for a uniprocessor system + // is 32 KB, because the entry point is SMBASE + 32KB, and CPU save state area + // just below SMBASE + 64KB. If more than one CPU is present in the platform, + // then the SMI entry point and the CPU save state areas can be tiles to minimize + // the total amount SMRAM required for all the CPUs. The tile size can be computed + // by adding the CPU save state size, any extra CPU specific context, and + // the size of code that must be placed at the SMI entry point to transfer + // control to a C function in the native SMM execution mode. This size is + // rounded up to the nearest power of 2 to give the tile size for a each CPU. + // The total amount of memory required is the maximum number of CPUs that + // platform supports times the tile size. + // + TileSize = SIZE_8KB; + SmmRelocationSize = EFI_PAGES_TO_SIZE (EFI_SIZE_TO_PAGES (SIZE_32KB + TileSize * (mMaxNumberOfCpus - 1))); + + // + // Split SmramReserve HOB to reserve SmmRelocationSize for Smm relocated memory + // + Status = SplitSmramHobForSmmRelocation ( + SmmRelocationSize, + &SmmRelocationStart + ); if (EFI_ERROR (Status)) { goto ON_EXIT; } + ASSERT (SmmRelocationStart != 0); + DEBUG ((DEBUG_INFO, "SmmRelocationInit - SmmRelocationSize: 0x%08x\n", SmmRelocationSize)); + DEBUG ((DEBUG_INFO, "SmmRelocationInit - SmmRelocationStart: 0x%08x\n", SmmRelocationStart)); + // // Fix up the address of the global variable or function referred in // SmmInit assembly files to be the absolute address // SmmInitFixupAddress (); @@ -569,32 +559,21 @@ SmmRelocationInit ( // InitSmmIdt (); // // Relocate SmmBases for each processor. - // Allocate mRebased as the flag to indicate the relocation is done for each CPU. // - mRebased = (BOOLEAN *)AllocateZeroPool (sizeof (BOOLEAN) * mMaxNumberOfCpus); - if (mRebased == NULL) { - Status = EFI_OUT_OF_RESOURCES; - goto ON_EXIT; - } - - SmmRelocateBases (); + SmmRelocateBases (MpServices2, SmmRelocationStart, TileSize); // // Create the SmBase HOB for all CPUs // - Status = CreateSmmBaseHob (mSmBase); + Status = CreateSmmBaseHob (SmmRelocationStart, TileSize); ON_EXIT: if (SmmStacks != NULL) { FreePages (SmmStacks, EFI_SIZE_TO_PAGES (SmmStackSize)); } - if (mSmBase != NULL) { - FreePages (mSmBase, EFI_SIZE_TO_PAGES (sizeof (UINT64) * mMaxNumberOfCpus)); - } - DEBUG ((DEBUG_INFO, "SmmRelocationInit Done\n")); return Status; } -- 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117949): https://edk2.groups.io/g/devel/message/117949 Mute This Topic: https://groups.io/mt/105593572/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-