[edk2-devel] [PATCH v1 0/1] BaseTools/GetUtcDateTime.py 3.12 support

[edk2-devel] [PATCH v1 0/1] BaseTools/GetUtcDateTime.py 3.12 support

[Guo, Gua]

From: Gua Guo <gua.guo@intel.com>

PR: https://github.com/tianocore/edk2/pull/5576
V1: Currently, Build FSP will be failure by python3.12 by calling GetUtcDateTime.py

Gua Guo (1):
  BaseTools/GetUtcDateTime.py: Python 3.12 support

 BaseTools/Scripts/GetUtcDateTime.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.39.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118053): https://edk2.groups.io/g/devel/message/118053
Mute This Topic: https://groups.io/mt/105650841/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v1 1/1] BaseTools/GetUtcDateTime.py: Python 3.12 support

[Guo, Gua]

From: Gua Guo <gua.guo@intel.com>

Ref to https://docs.python.org/3/whatsnew/3.12.html
utcnow() and utcfromtimestamp() are deprecated
Prevent use it cause build error.

Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Gua Guo <gua.guo@intel.com>
---
 BaseTools/Scripts/GetUtcDateTime.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Scripts/GetUtcDateTime.py b/BaseTools/Scripts/GetUtcDateTime.py
index 3cfb6ac2ae..6764fb22a7 100644
--- a/BaseTools/Scripts/GetUtcDateTime.py
+++ b/BaseTools/Scripts/GetUtcDateTime.py
@@ -29,7 +29,7 @@ def Main():
         print ("ERROR: At least one argument is required!\n")
         PARSER.print_help()
 
-    today = datetime.datetime.utcnow()
+    today = datetime.datetime.now(datetime.UTC)
     if ARGS.year:
         ReversedNumber = str(today.year)[::-1]
         print (''.join(hex(ord(HexString))[2:] for HexString in ReversedNumber))
-- 
2.39.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118054): https://edk2.groups.io/g/devel/message/118054
Mute This Topic: https://groups.io/mt/105650842/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/1] BaseTools/GetUtcDateTime.py 3.12 support

[Guo, Gua]

Hi @Liming Gao and @Rebecca Cran

May I get one of your help for code review + 1 ?
Maybe we can merge it EOW, I think it's no harmful change.

Thanks,
Gua

-----Original Message-----
From: Guo, Gua <gua.guo@intel.com> 
Sent: Sunday, April 21, 2024 8:51 PM
To: devel@edk2.groups.io
Cc: Guo, Gua <gua.guo@intel.com>; Kasbekar, Saloni <saloni.kasbekar@intel.com>
Subject: [PATCH v1 0/1] BaseTools/GetUtcDateTime.py 3.12 support

From: Gua Guo <gua.guo@intel.com>

PR: https://github.com/tianocore/edk2/pull/5576
V1: Currently, Build FSP will be failure by python3.12 by calling GetUtcDateTime.py

Gua Guo (1):
  BaseTools/GetUtcDateTime.py: Python 3.12 support

 BaseTools/Scripts/GetUtcDateTime.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.39.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118057): https://edk2.groups.io/g/devel/message/118057
Mute This Topic: https://groups.io/mt/105650841/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/1] BaseTools/GetUtcDateTime.py 3.12 support

[Guo, Gua]

Hi @Chiu, Chasel and @Kinney, Michael D

As you know, Intel don't have owner own basetools now, may I get your help to reach the PR to maintainer.

Thanks,
Gua

-----Original Message-----
From: Guo, Gua 
Sent: Monday, April 22, 2024 9:06 AM
To: devel@edk2.groups.io; Liming Gao <gaoliming@byosoft.com.cn>; Rebecca Cran <rebecca@bsdio.com>
Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>
Subject: RE: [PATCH v1 0/1] BaseTools/GetUtcDateTime.py 3.12 support

Hi @Liming Gao and @Rebecca Cran

May I get one of your help for code review + 1 ?
Maybe we can merge it EOW, I think it's no harmful change.

Thanks,
Gua

-----Original Message-----
From: Guo, Gua <gua.guo@intel.com> 
Sent: Sunday, April 21, 2024 8:51 PM
To: devel@edk2.groups.io
Cc: Guo, Gua <gua.guo@intel.com>; Kasbekar, Saloni <saloni.kasbekar@intel.com>
Subject: [PATCH v1 0/1] BaseTools/GetUtcDateTime.py 3.12 support

From: Gua Guo <gua.guo@intel.com>

PR: https://github.com/tianocore/edk2/pull/5576
V1: Currently, Build FSP will be failure by python3.12 by calling GetUtcDateTime.py

Gua Guo (1):
  BaseTools/GetUtcDateTime.py: Python 3.12 support

 BaseTools/Scripts/GetUtcDateTime.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.39.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118108): https://edk2.groups.io/g/devel/message/118108
Mute This Topic: https://groups.io/mt/105650841/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/1] BaseTools/GetUtcDateTime.py 3.12 support

[Rebecca Cran]

Sorry, I haven’t had time to look at EDK2 patches recently. I’ll spend some time going through them tomorrow.

Rebecca

On Mon, Apr 22, 2024, at 8:29 PM, Guo, Gua wrote:
> Hi @Chiu, Chasel and @Kinney, Michael D
>
> As you know, Intel don't have owner own basetools now, may I get your 
> help to reach the PR to maintainer.
>
> Thanks,
> Gua
>
> -----Original Message-----
> From: Guo, Gua 
> Sent: Monday, April 22, 2024 9:06 AM
> To: devel@edk2.groups.io; Liming Gao <gaoliming@byosoft.com.cn>; 
> Rebecca Cran <rebecca@bsdio.com>
> Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>
> Subject: RE: [PATCH v1 0/1] BaseTools/GetUtcDateTime.py 3.12 support
>
> Hi @Liming Gao and @Rebecca Cran
>
> May I get one of your help for code review + 1 ?
> Maybe we can merge it EOW, I think it's no harmful change.
>
> Thanks,
> Gua
>
> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com> 
> Sent: Sunday, April 21, 2024 8:51 PM
> To: devel@edk2.groups.io
> Cc: Guo, Gua <gua.guo@intel.com>; Kasbekar, Saloni <saloni.kasbekar@intel.com>
> Subject: [PATCH v1 0/1] BaseTools/GetUtcDateTime.py 3.12 support
>
> From: Gua Guo <gua.guo@intel.com>
>
> PR: https://github.com/tianocore/edk2/pull/5576
> V1: Currently, Build FSP will be failure by python3.12 by calling 
> GetUtcDateTime.py
>
> Gua Guo (1):
>   BaseTools/GetUtcDateTime.py: Python 3.12 support
>
>  BaseTools/Scripts/GetUtcDateTime.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.39.2.windows.1
>
>
>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118109): https://edk2.groups.io/g/devel/message/118109
Mute This Topic: https://groups.io/mt/105650841/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v1 1/1] BaseTools/GetUtcDateTime.py: Python 3.12 support

[gaoliming via groups.io]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Guo, Gua
> 发送时间: 2024年4月21日 20:51
> 收件人: devel@edk2.groups.io
> 抄送: gua.guo@intel.com; saloni.kasbekar@intel.com; Rebecca Cran
> <rebecca@bsdio.com>; Liming Gao <gaoliming@byosoft.com.cn>; Bob Feng
> <bob.c.feng@intel.com>; Yuwei Chen <yuwei.chen@intel.com>
> 主题: [edk2-devel] [PATCH v1 1/1] BaseTools/GetUtcDateTime.py: Python
> 3.12 support
> 
> From: Gua Guo <gua.guo@intel.com>
> 
> Ref to https://docs.python.org/3/whatsnew/3.12.html
> utcnow() and utcfromtimestamp() are deprecated
> Prevent use it cause build error.
> 
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Signed-off-by: Gua Guo <gua.guo@intel.com>
> ---
>  BaseTools/Scripts/GetUtcDateTime.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Scripts/GetUtcDateTime.py
> b/BaseTools/Scripts/GetUtcDateTime.py
> index 3cfb6ac2ae..6764fb22a7 100644
> --- a/BaseTools/Scripts/GetUtcDateTime.py
> +++ b/BaseTools/Scripts/GetUtcDateTime.py
> @@ -29,7 +29,7 @@ def Main():
>          print ("ERROR: At least one argument is required!\n")
> 
>          PARSER.print_help()
> 
> 
> 
> -    today = datetime.datetime.utcnow()
> 
> +    today = datetime.datetime.now(datetime.UTC)
> 
>      if ARGS.year:
> 
>          ReversedNumber = str(today.year)[::-1]
> 
>          print (''.join(hex(ord(HexString))[2:] for HexString in
> ReversedNumber))
> 
> --
> 2.39.2.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#118054):
> https://edk2.groups.io/g/devel/message/118054
> Mute This Topic: https://groups.io/mt/105650842/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118145): https://edk2.groups.io/g/devel/message/118145
Mute This Topic: https://groups.io/mt/105690657/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-