From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 51A15D811B2 for ; Mon, 22 Apr 2024 08:52:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=HPckPnnBR/NXgNZkif73qY4IdXG9Q9AOyibMmFKkjiw=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1713775919; v=1; b=0ENTps80DF6t9iXvj3IIzHivFId8/bdcjCTZgRmTBC7F388REZnNkjuO5u62UcR2iTOXRXsz PUztSvIMBt7a3DVNQuJsxRExJDpzp7Ot+XCTdaS6IGI6/JPDBL+c6VQ0A34z0G2nmUaVsMdMkwB k/5nsHxpINLKUye/gAM6b3NTmm8Z36ShHM5eFjn/dg2weQ99aLtC+GArCe7EEIcbfZXg9YPCvSm f64uvfKsQwzR7+4+4RIN5xtWnwxOcMEutVJ080AdlMxYAW7n1Sz5rMLxfwUJgVkAPj2ZWtz7N/z SE783cij5ggts7iM9yGY2VpRv+mUjUsreSuxyz9TdwXTQ== X-Received: by 127.0.0.2 with SMTP id MUd7YY7687511xT1wqCNNBT1; Mon, 22 Apr 2024 01:51:59 -0700 X-Received: from muminek.juszkiewicz.com.pl (muminek.juszkiewicz.com.pl [213.251.184.221]) by mx.groups.io with SMTP id smtpd.web10.13790.1713775918810841584 for ; Mon, 22 Apr 2024 01:51:59 -0700 X-Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id 388E1261387; Mon, 22 Apr 2024 10:51:56 +0200 (CEST) X-Virus-Scanned: Debian amavis at juszkiewicz.com.pl X-Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavis, port 10024) with ESMTP id uXqZPHo7veac; Mon, 22 Apr 2024 10:51:54 +0200 (CEST) X-Received: from applejack.lan (83.11.0.31.ipv4.supernova.orange.pl [83.11.0.31]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id C037626071B; Mon, 22 Apr 2024 10:51:53 +0200 (CEST) From: "Marcin Juszkiewicz" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Graeme Gregory , Marcin Juszkiewicz Subject: [edk2-devel] [PATCH edk2-platforms] SbsaQemu: move code outside of methods in DSDT Date: Mon, 22 Apr 2024 10:51:45 +0200 Message-ID: <20240422085145.1234981-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 22 Apr 2024 01:51:59 -0700 Resent-From: marcin.juszkiewicz@linaro.org Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: O1yhmxPbx5QZCgrQBOvSwBFox7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=0ENTps80; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none) IASL complained that DSDT is not optimal: Dsdt.iiii 83: Name (RBUF, ResourceTemplate() { Remark 2173 - Creation of named objects within a method is highly inefficient, use globals or method local variables instead ^ (\_SB.USB0._CRS) Dsdt.iiii 377: Name (RBUF, ResourceTemplate () { Remark 2173 - Creation of named objects within a method is highly inefficient, use globals or method local variables instead ^ (\_SB.PCI0._CRS) --- Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl b/Silicon/Qemu/Sbs= aQemu/AcpiTables/Dsdt.asl index b55ad6c5cc07..60c72fecc74f 100644 --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl @@ -77,13 +77,13 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", Method (_STA) { Return (XHCI) } + Name (RBUF, ResourceTemplate() { + Memory32Fixed (ReadWrite, + FixedPcdGet32 (PcdPlatformXhciBase), + FixedPcdGet32 (PcdPlatformXhciSize)) + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) {= 43 } + }) Method (_CRS, 0x0, Serialized) { - Name (RBUF, ResourceTemplate() { - Memory32Fixed (ReadWrite, - FixedPcdGet32 (PcdPlatformXhciBase), - FixedPcdGet32 (PcdPlatformXhciSize)) - Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusiv= e) { 43 } - }) Return (RBUF) } =20 @@ -371,7 +371,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", }) =20 // Root complex resources - Method (_CRS, 0, Serialized) { Name (RBUF, ResourceTemplate () { WordBusNumber ( // Bus numbers assigned to this root ResourceProducer, @@ -418,10 +417,10 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", FixedPcdGet32 (PcdPciIoSize), // Length ,,,TypeTranslation ) - }) // Name(RBUF) - + }) // Name(RBUF) + Method (_CRS, 0, Serialized) { Return (RBUF) - } // Method(_CRS) + } =20 Device (RES0) { --=20 2.44.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118078): https://edk2.groups.io/g/devel/message/118078 Mute This Topic: https://groups.io/mt/105666235/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-