From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 31E6194148F for ; Wed, 24 Apr 2024 11:32:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8xfc/zcu7OcaZlgX8XrouZEc+Vx2XpOopbRJrZR6BzE=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1713958364; v=1; b=C9EXYSGqEtVkL4KX3G75VW80iePccOAONmFqhyq4doqBO8vI7vTQDK/UojGLg/yCOZPe1PbE Me9UrTttse0PoTrGjNcz6YAVWOAMsH37PUgLNrTQCgJK46iFa7xijDlIVHLYJizv2HlAs7R1hoG t82MyylLn2xZLWJRqAyHoQQFy4t6XOFxxToa/in3qKGMY80b/KVhJ5uLsnbwImVl1Koxp+Ck2Z3 /e4MTZtw/JYK7aiX9wtvNYtiZwN/BUmop7SmJPVtqWpP6p82g+btA7/Z+c9XGLMGjPU7esH+T5w utJ884YOwd0SRJfLBei7nZHVExH5M5921TsnzfoTADLxA== X-Received: by 127.0.0.2 with SMTP id BlRlYY7687511xxssVwA9nfi; Wed, 24 Apr 2024 04:32:44 -0700 X-Received: from muminek.juszkiewicz.com.pl (muminek.juszkiewicz.com.pl [213.251.184.221]) by mx.groups.io with SMTP id smtpd.web10.14187.1713958363988554747 for ; Wed, 24 Apr 2024 04:32:44 -0700 X-Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id 21DF726124E; Wed, 24 Apr 2024 13:32:42 +0200 (CEST) X-Virus-Scanned: Debian amavis at juszkiewicz.com.pl X-Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavis, port 10024) with ESMTP id Vg-c4ID51UNn; Wed, 24 Apr 2024 13:32:40 +0200 (CEST) X-Received: from applejack.lan (83.11.103.26.ipv4.supernova.orange.pl [83.11.103.26]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id A2726261252; Wed, 24 Apr 2024 13:32:39 +0200 (CEST) From: "Marcin Juszkiewicz" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Graeme Gregory , Marcin Juszkiewicz Subject: [edk2-devel] [PATCH edk2-platforms v2 2/2] SbsaQemu: remove some methods from DSDT Date: Wed, 24 Apr 2024 13:32:35 +0200 Message-ID: <20240424113235.497373-3-marcin.juszkiewicz@linaro.org> In-Reply-To: <20240424113235.497373-1-marcin.juszkiewicz@linaro.org> References: <20240424113235.497373-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 24 Apr 2024 04:32:44 -0700 Resent-From: marcin.juszkiewicz@linaro.org Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6uGvVJoERGk9IKKv46UBVMyox7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=C9EXYSGq; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io IASL complained that DSDT is not optimal: Dsdt.iiii 83: Name (RBUF, ResourceTemplate() { Remark 2173 - Creation of named objects within a method is highly inefficient, use globals or method local variables instead ^ (\_SB.USB0._CRS) Dsdt.iiii 377: Name (RBUF, ResourceTemplate () { Remark 2173 - Creation of named objects within a method is highly inefficient, use globals or method local variables instead ^ (\_SB.PCI0._CRS) Simplified some _CRS nodes. Signed-off-by: Marcin Juszkiewicz --- Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl b/Silicon/Qemu/Sbs= aQemu/AcpiTables/Dsdt.asl index b55ad6c5cc07..c134fb66e860 100644 --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl @@ -77,15 +77,12 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", Method (_STA) { Return (XHCI) } - Method (_CRS, 0x0, Serialized) { - Name (RBUF, ResourceTemplate() { - Memory32Fixed (ReadWrite, - FixedPcdGet32 (PcdPlatformXhciBase), - FixedPcdGet32 (PcdPlatformXhciSize)) - Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusiv= e) { 43 } - }) - Return (RBUF) - } + Name (_CRS, ResourceTemplate() { + Memory32Fixed (ReadWrite, + FixedPcdGet32 (PcdPlatformXhciBase), + FixedPcdGet32 (PcdPlatformXhciSize)) + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) {= 43 } + }) =20 // Root Hub Device (RHUB) { @@ -371,8 +368,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", }) =20 // Root complex resources - Method (_CRS, 0, Serialized) { - Name (RBUF, ResourceTemplate () { + Name (_CRS, ResourceTemplate () { WordBusNumber ( // Bus numbers assigned to this root ResourceProducer, MinFixed, MaxFixed, PosDecode, @@ -418,10 +414,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", FixedPcdGet32 (PcdPciIoSize), // Length ,,,TypeTranslation ) - }) // Name(RBUF) - - Return (RBUF) - } // Method(_CRS) + }) // Name(_CRS) =20 Device (RES0) { --=20 2.44.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118207): https://edk2.groups.io/g/devel/message/118207 Mute This Topic: https://groups.io/mt/105707993/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-