From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 12CF9941D61 for ; Sun, 28 Apr 2024 19:18:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+vjI77AoLu76hPPWt0EpJdBSKSDkNBRLhhA6cebU7Ns=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1714331937; v=1; b=i0MZH+0ZQ4hEDLIuESdeR5Fg8I7qv4IH3yPas+Qo5mlMWFMWW/bLSlpE7CWPDGGimo5cIltH mfWjIwntST58yyLTaB1rqPHr+ZEb3USUzUDY9auOdnDCjp3UOQ+5oq7xgN1OiKz1Vgn14xAPC2e vLjLYUBgvNqgB5P9o6NgyUE815NZZJVvGYKGAcenRYlFy6V2TgVCZEtKeyvGFUeB95IVcanP3gQ TIC0ugQtrs3P3BowEhfsKU8/ysmcC7qBtfWgU/49G5ltlmSMt0HQ4c6DBe4j7f1CHim0Cgul4Cv yHDMaLCIBYwXtEIXBDZgYx7ct8Y9zo2n5o8Q1GFyfJc3A== X-Received: by 127.0.0.2 with SMTP id DjRXYY7687511xlZIsu6gAq2; Sun, 28 Apr 2024 12:18:57 -0700 X-Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by mx.groups.io with SMTP id smtpd.web10.3759.1714331931766651114 for ; Sun, 28 Apr 2024 12:18:52 -0700 X-Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2df9af57b5eso23053101fa.2 for ; Sun, 28 Apr 2024 12:18:51 -0700 (PDT) X-Gm-Message-State: Hlx1dPz4iPA2mNIRZtSVXxPdx7686176AA= X-Google-Smtp-Source: AGHT+IE2i8OsGlPMlpvfd5SHoJnEBXFPfvnfPxJv8TjVt6LIJKwxGXCZZsDcnGr70jliRvC5vbIOyQ== X-Received: by 2002:a2e:a316:0:b0:2da:e75:e755 with SMTP id l22-20020a2ea316000000b002da0e75e755mr7182494lje.8.1714331929522; Sun, 28 Apr 2024 12:18:49 -0700 (PDT) X-Received: from localhost.localdomain ([185.20.45.104]) by smtp.gmail.com with ESMTPSA id t17-20020a2e7811000000b002d816c0500asm3349827ljc.118.2024.04.28.12.18.49 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 28 Apr 2024 12:18:49 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: ray.ni@intel.com, zhichao.gao@intel.com, gaoliming@byosoft.com.cn, Mike Maslenkin Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg/RamDiskDxe: fix memory leak. Date: Sun, 28 Apr 2024 22:18:47 +0300 Message-Id: <20240428191847.84240-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 28 Apr 2024 12:18:52 -0700 Resent-From: mike.maslenkin@gmail.com Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=i0MZH+0Z; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Cc: Ray Ni Cc: Zhichao Gao Cc: Liming Gao Signed-off-by: Mike Maslenkin --- MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c b/MdeModu= lePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c index 60cf3c8c4a79..2dac121c478c 100644 --- a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c +++ b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c @@ -404,7 +404,8 @@ HiiCreateRamDisk ( );=0D } while (Key.UnicodeChar !=3D CHAR_CARRIAGE_RETURN);=0D =0D - return EFI_DEVICE_ERROR;=0D + Status =3D EFI_DEVICE_ERROR;=0D + goto ErrorExit;=0D }=0D }=0D =0D @@ -431,7 +432,7 @@ HiiCreateRamDisk ( );=0D } while (Key.UnicodeChar !=3D CHAR_CARRIAGE_RETURN);=0D =0D - return Status;=0D + goto ErrorExit;=0D }=0D =0D //=0D @@ -442,6 +443,10 @@ HiiCreateRamDisk ( PrivateData->CreateMethod =3D RamDiskCreateHii;=0D =0D return EFI_SUCCESS;=0D +=0D +ErrorExit:=0D + gBS->FreePool (StartingAddr);=0D + return Status;=0D }=0D =0D /**=0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118353): https://edk2.groups.io/g/devel/message/118353 Mute This Topic: https://groups.io/mt/105788221/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-