From: "Pete Batard via groups.io" <pete=akeo.ie@groups.io>
To: devel@edk2.groups.io
Cc: quic_llindhol@quicinc.com, ardb+tianocore@kernel.org,
michael.d.kinney@intel.com, gaoliming@byosoft.com.cn
Subject: [edk2-devel] [PATCH 0/1] MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio
Date: Wed, 8 May 2024 09:51:46 +0100 [thread overview]
Message-ID: <20240508085148.1725-1-pete@akeo.ie> (raw)
The following patch fixes a regression/breakage that currently prevents
compilation of MdePkg for AARCH64 with Visual Studio 2022. This regression
was introduced with the patch that was discussed in October 2020 at:
https://edk2.groups.io/g/devel/topic/77247140#msg65813 and that was
eventually integrated in September 2023.
The full error can be seen on a real life example at:
https://github.com/pbatard/EfiFs/actions/runs/8988513468/job/24689531001#step:8:220
Because this is a regression/breakage for one of the major toolchains, and
the fix is expected to be low impact, I would appreciate if this could be
speed-tracked for review and integration for the 202405 edk2 release, which
is currently in soft freeze.
Also, since this appears not to be the case, and it would have helped with
this issue being caught during patch integration rather than 6 months down
the line, I would also very much like to push for a VS2019/AARCH64 CI
pipeline to be added to the edk2 patch validation process.
Thanks,
/Pete
Pete Batard (1):
MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio
MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
1 file changed, 1 insertion(+)
--
2.45.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118665): https://edk2.groups.io/g/devel/message/118665
Mute This Topic: https://groups.io/mt/105977469/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next reply other threads:[~2024-05-08 8:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 8:51 Pete Batard via groups.io [this message]
2024-05-08 8:51 ` [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio Pete Batard via groups.io
2024-05-08 9:07 ` Ard Biesheuvel
2024-05-08 9:08 ` Ard Biesheuvel
2024-05-08 9:21 ` Pete Batard via groups.io
2024-05-08 9:39 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508085148.1725-1-pete@akeo.ie \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox