From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id B3078D806DA for ; Fri, 10 May 2024 07:36:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5nGhAWYigBpos2k7W6duE6b3yvbM7Wo9yENpHKaeR3U=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715326618; v=1; b=bpzIL7exuZLBoKhWWWqPeBqGDjNNM9UcjbiQ0yjN8oqLmLAwJzFWX8h1gjtaYgMKSb36u/1s mj4rfys51/5H+JNUvCD66Tn6xTK/95JboSxyuGGFrmvl2oWrRQYn7WxKeDWmnjlLs/vjN8pHgS1 MBFlEqesRIqKU1J/ct1vIJOUGx5i+bm13HZ8It/PztPby+bGAGMW46P9jU50hBkIk6CLHf040EU 0twKZbLJJlkgo2yl33pqIE94YjC6Z+w/d9DwxVkqIEodLH6IhrQvz5N/s3GDpv9MzA+mzvGHf0w uyrc466TIunokaQ8dgwtrDvkv7vIhNWk3vUMPRecFkN5g== X-Received: by 127.0.0.2 with SMTP id 9a6LYY7687511x6NXVnIE01M; Fri, 10 May 2024 00:36:58 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.105]) by mx.groups.io with SMTP id smtpd.web11.7411.1715326616437868050 for ; Fri, 10 May 2024 00:36:56 -0700 X-Received: from DS7PR10MB5375.namprd10.prod.outlook.com (2603:10b6:5:3ab::11) by IA1PR10MB7264.namprd10.prod.outlook.com (2603:10b6:208:3fe::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.47; Fri, 10 May 2024 07:36:52 +0000 X-Received: from DS7PR10MB5375.namprd10.prod.outlook.com ([fe80::8150:88f6:2efe:6242]) by DS7PR10MB5375.namprd10.prod.outlook.com ([fe80::8150:88f6:2efe:6242%7]) with mapi id 15.20.7544.048; Fri, 10 May 2024 07:36:52 +0000 From: "Santhosh Kumar V via groups.io" To: "devel@edk2.groups.io" , Santhosh Kumar V CC: Sivaraman Nainar , Raj V Akilan , Saloni Kasbekar , Zachary Clark-williams Subject: [edk2-devel] [PATCH] NetworkPkg:SnpDxe:Fix Coverity Issues Thread-Topic: [PATCH] NetworkPkg:SnpDxe:Fix Coverity Issues Thread-Index: AQHaoqzTvG4F77xES06d7fzuhpbwBg== Date: Fri, 10 May 2024 07:36:52 +0000 Message-ID: <20240510073650.1255-1-santhoshkumarv@ami.com> Accept-Language: en-US, en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR10MB5375:EE_|IA1PR10MB7264:EE_ x-ms-office365-filtering-correlation-id: de861007-0f5d-4d17-2da4-08dc70c3f5d7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?iso-8859-1?Q?zFJKwctntho15zHBWHKCNoSHEobPnd6V4+FFCD7u/ociy6k/sfNt283wde?= =?iso-8859-1?Q?UjpbgLEhqP8gTaqXEsM2No8WpedRX532n2zdFJJuRJ5UbgvwJNuQTauhH4?= =?iso-8859-1?Q?GtKui192cJ97em782AUwOyaOj8+d2FQY4C8xHBX42TDhq0IiEt14r9SRxP?= =?iso-8859-1?Q?Hj0I4sxODb8aKcviQf6nIroELSGflRaeAHF3HkIBAskS5IYPxgfFWyfEf3?= =?iso-8859-1?Q?rQCkNsTooNyMGoNXGYs81pjdBOJnYq/TkMNsUBTdSTLdZpU/7vhWN3ST8S?= =?iso-8859-1?Q?rwIPlUYsiVJQIfBbxST/L9wClBaRxxJ9YjXbaFE+YJVvHMapL4DI8POOje?= =?iso-8859-1?Q?HMhxbRGMcPvIkZk4H1GO/mnkTEjlifMH+937+isepPwAX37/dN5a3LzqHA?= =?iso-8859-1?Q?3cTpBpYpE1uu/peCFwdIVK2copWVKJeGDZ7zelIAvCo8/ahLHZ6Gwa4s8Q?= =?iso-8859-1?Q?unxV+4TMn1ApFXC7XwsDL5+/01aX7+562xv/CDWwsSYA0akxFVQvbb15lb?= =?iso-8859-1?Q?DrQzCwswbJVRvobC30XSKRqpW2ijSCdGXlgDUUc5FjHFEtDJK0TVOPCeQU?= =?iso-8859-1?Q?zOlAMnTlwDLwFue54EIYdQzFgus6DCaCJJOQzrkaNEUWwbTL/Y8bFi00l7?= =?iso-8859-1?Q?kuMwVV2PM3Ctm0lrbqaQp2gHoNj7qY0cxQXzgaZKYA7/VxHKd8RdgTNax1?= =?iso-8859-1?Q?JbvbgDEwJ5Lis2ZefKG5giAQFd8sREBqYavAfALOw4fYxLrcycJohGxug4?= =?iso-8859-1?Q?0QTEJh7osmSP+CYDb2laRx7IeOhImMqlcYWyu4sdPQH4CHIhEwiChmuqsl?= =?iso-8859-1?Q?Bb+0ZGZGM9eOCfjDvOxWXEzLDOcTLrys03oTfasZ812IItx2tsrLGVNrzH?= =?iso-8859-1?Q?eDC4pJd2p79lOH8B1+1yBWkvuDxmve0lgY0jri4igGVvU5TO5dsfEfmyvU?= =?iso-8859-1?Q?crvWrddIsEnHdjGSEc26yUz+3GZJ2a8W4EHOsgbU9l55ilczFuXFKcYqux?= =?iso-8859-1?Q?KFyMmEsm5hnzjbeCiGpSjvQkhIuruaUSXA/MTpc1tN+1wsS9mFGUNAzZgu?= =?iso-8859-1?Q?eh1qDxaSUIf8qTHsxU3sgUVPxegxeRVPN1vg4hoQ57ZSa2ViofJA+Lbwao?= =?iso-8859-1?Q?rWMOFhVeairn+uD8pkCQ7pugN5NMxfyAH2p+WQI+ISu3Kq770NXr4OuIQa?= =?iso-8859-1?Q?j06PZCxYrvasfYEMuKwdAnzSMD/J4x7kaQWgFlUrcMcTVAF5tmba3YqtI0?= =?iso-8859-1?Q?AC/wwt5IlaS3b1qi2LvuA2YbLzVdttIE6xtJc2d/XyTU2rVuUkPR1sznoy?= =?iso-8859-1?Q?bIXyOEiHN6M3mPtIOc8xX0wtpo3Cw82Ken7DMnhBiTuY04rt72CRL+Il3C?= =?iso-8859-1?Q?xyrSYJMv0TBC3VT6wmwAkRsCURtuQ5vw=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?EWvie4JWx9AW5y3oM/mbgimMEkqMg6rlSjZBcC8NwoOu89zgzpnR2RqInA?= =?iso-8859-1?Q?6c1VQflAvw0KU3aiJUU5Gb4fdzUjCni6NyBnWLk7d0yv1jgqPVR4f18g4H?= =?iso-8859-1?Q?Re6N4vM3a2FhMKZA0g9xVsZZvmhy0lcEtzEWCNbALWYMc5WtIOBsRQJERb?= =?iso-8859-1?Q?fzNZDfE0d3CQ3JVsJw4psSH8erKCkHofntr+FP5n9PGPepUHbTWaEjM3F7?= =?iso-8859-1?Q?9E1QLRs2K5xqhc9qDxczwaxsyTvVc5KgAGXpth4XVupre+6GC6fSywWYQ3?= =?iso-8859-1?Q?Y1VkUOB80T9Sg5RAhK6uYb7izICWsyYvui25FJ1GS/JzDWiJnaqZMLAdD2?= =?iso-8859-1?Q?dTpGEFn77O8ZJv4L3554cbK8zMTiFVHhYYdiQCg4Gamojd7EDj9BX9wcdf?= =?iso-8859-1?Q?+58RS/QK7+Q+09GlLsjVThKQF+xzXRQSzj7FgjH4DCCTj7d68v0a6iwBHZ?= =?iso-8859-1?Q?hMHQ8LKJjqP5bIueKu7uhFHVd14DFP2iJ7elbANle7T3hPul6tfhLdrsW+?= =?iso-8859-1?Q?HxrUQtxRslPFzipyCDv4t6WXSms4o2weEVN7Vvhr6DTC9vFhlQ/q4sAnUc?= =?iso-8859-1?Q?T78r65vnkBKEG3DY95YUjNmcVyP7AdQVaAiTIopx5kWxIanY8lt0Vyo1Lx?= =?iso-8859-1?Q?5x/GWQeh8rACKjflsNoAFAhxAwi5qYOZBEZGhl/HV6BSmo5HVzOpgcOxC7?= =?iso-8859-1?Q?Ajg5eGtfGmuYqExDrxXEyHRUsVCOqDEYLQ1p2xiigfkYgjhOBUmKEfiKpz?= =?iso-8859-1?Q?5SjWZkDyMTtL/vRBTn/T1EIPusS6TUwKspqvmrzRFeuVz4a19GXfGPkkqo?= =?iso-8859-1?Q?8dwnINHKdmg9GuICJgMQ8yq9q7uNgCqWjsEohJ78GnUx3USD10MkdLN1DA?= =?iso-8859-1?Q?9w5R9me5LNgp2e9paXwzLSP9tpG4d0Mt7tTA/1dVaO5GRxxV4oK5jS/w3C?= =?iso-8859-1?Q?4rQw8k3UFtPEcz9mq9Tl0IqOyXP7aCrQ/hcv02IMntzdpnTeC7mLQtPDgH?= =?iso-8859-1?Q?10WaRPOFvosfnLnuPh2pANGJmWFVNJAO9rzEr4C3VGqKBXY+VKTf9jXJZz?= =?iso-8859-1?Q?1HfEFa5nkvyecwel7oJoHmpqMVfy+Aa0HX8fQvtnueH5l6Ylhrl9V3uMMB?= =?iso-8859-1?Q?V+J2Xm9IZa5U45rGar2NrgK9wiArUxAV8MsZGFS3nZChpkf2nnDxhgJC8N?= =?iso-8859-1?Q?67XrVp+62Van9rh3efohLj9W7/kWaI77z4CWdM7I7KmY6I4aDH8QHARDqo?= =?iso-8859-1?Q?TSt+f/X5tUTY/v6RJYDYtwwNsT5++OXqrK3WvSAPNqZNwoXt81QpYyU+ve?= =?iso-8859-1?Q?ckTBZ8kgt3wPIKkQQxZmqbiLYmsrJQIXSmGYdz+yhU1CO/+BPm6URi9pWg?= =?iso-8859-1?Q?vhTp5BPdUIsjiS5mteMW5tdntbOimcFWaN69rAIyvLAKiR/U1a1dBabodq?= =?iso-8859-1?Q?zLHqGaEDNfC/RB998j4teHM5S4KgnklbXMj0PHSrlCdF+r4bI5SglKHNoV?= =?iso-8859-1?Q?wxZ/ClKpdsXS1AKLUOWjcm5YpRvPnZz/7HwHz0zzHPSP5nUjZ5WfvZnNEf?= =?iso-8859-1?Q?z+O1f0qE56vVXo3sOk8iGMe3ecMY6zvDmAdPaW5ZRLoscCHM8JqLj4EWxy?= =?iso-8859-1?Q?etx/mDLI1DxBGDJLIhAL4axHy/xPSM19nqNinEqk63J855WFDpetrGfw?= =?iso-8859-1?Q?=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5375.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de861007-0f5d-4d17-2da4-08dc70c3f5d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2024 07:36:52.4766 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wK3SS+sy7dqYONkalWUuRLHeVWr65UjCUNY/eECJlg33JoWkpRJXwTH6w3YG/xG79qfLq/WuC4B6BMFuUObvlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7264 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 10 May 2024 00:36:57 -0700 Resent-From: santhoshkumarv@ami.com Reply-To: devel@edk2.groups.io,santhoshkumarv@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Lj99mbZgRnYpFhaKdwi1qAVOx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=bpzIL7ex; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io Resolved Coverity Issues reported in SNP Dxe. 1.ComponentName.c (Overflow) Expression "OffSet--", which is equal to 18446744073709551615, where "OffSe= t" is known to be equal to 0, underflows the type that receives it. 2.SnpUndi32GetStatus,SnpUndi32Initialize,SnpUndi32Transmit (Deadcode) Execution is not reaching as always snp is not equal to NULL As This pointer is compared with NULL in function start Macro EFI_SIMPLE_NETWORK_DEV_FROM_THIS always return address in This pointe= r 3.PxeInit(Overflow) Expression "Snp->TxRxBufferSize - 1U", where "Snp->TxRxBufferSize" is known= to be equal to 0, underflows the type that receives it 4.SnpUndi32Reset (Not used Variable) ExtendedVerification variable is assigned but not used in that function.hen= ce assign Cc: Saloni Kasbekar Cc: Zachary Clark-williams Signed-off-by: SanthoshKumarV --- NetworkPkg/SnpDxe/ComponentName.c | 3 ++- NetworkPkg/SnpDxe/Get_status.c | 3 --- NetworkPkg/SnpDxe/Initialize.c | 17 +++++++---------- NetworkPkg/SnpDxe/Reset.c | 3 +-- NetworkPkg/SnpDxe/Transmit.c | 3 --- 5 files changed, 10 insertions(+), 19 deletions(-) diff --git a/NetworkPkg/SnpDxe/ComponentName.c b/NetworkPkg/SnpDxe/Componen= tName.c index cc4cc5bddb..7d1360ff46 100644 --- a/NetworkPkg/SnpDxe/ComponentName.c +++ b/NetworkPkg/SnpDxe/ComponentName.c @@ -267,7 +267,8 @@ UpdateName ( // // Remove the last '-' // - OffSet--; + if (OffSet > 0) + OffSet--; OffSet +=3D UnicodeSPrint ( HandleName + OffSet, sizeof (HandleName) - OffSet * sizeof (CHAR16), diff --git a/NetworkPkg/SnpDxe/Get_status.c b/NetworkPkg/SnpDxe/Get_status.= c index 14b678fd36..6f277eb1a4 100644 --- a/NetworkPkg/SnpDxe/Get_status.c +++ b/NetworkPkg/SnpDxe/Get_status.c @@ -218,9 +218,6 @@ SnpUndi32GetStatus ( OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); - if (Snp =3D=3D NULL) { - return EFI_DEVICE_ERROR; - } switch (Snp->Mode.State) { case EfiSimpleNetworkInitialized: diff --git a/NetworkPkg/SnpDxe/Initialize.c b/NetworkPkg/SnpDxe/Initialize.= c index c219a1cb20..4a15ad1cbd 100644 --- a/NetworkPkg/SnpDxe/Initialize.c +++ b/NetworkPkg/SnpDxe/Initialize.c @@ -128,11 +128,13 @@ PxeInit ( ); if (Snp->TxRxBuffer !=3D NULL) { - Snp->PciIo->FreeBuffer ( - Snp->PciIo, - SNP_MEM_PAGES (Snp->TxRxBufferSize), - (VOID *)Snp->TxRxBuffer - ); + if (Snp->TxRxBufferSize !=3D 0) { + Snp->PciIo->FreeBuffer ( + Snp->PciIo, + SNP_MEM_PAGES (Snp->TxRxBufferSize), + (VOID *)Snp->TxRxBuffer + ); + } } Snp->TxRxBuffer =3D NULL; @@ -196,11 +198,6 @@ SnpUndi32Initialize ( OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); - if (Snp =3D=3D NULL) { - EfiStatus =3D EFI_INVALID_PARAMETER; - goto ON_EXIT; - } - switch (Snp->Mode.State) { case EfiSimpleNetworkStarted: break; diff --git a/NetworkPkg/SnpDxe/Reset.c b/NetworkPkg/SnpDxe/Reset.c index 2ff685376d..1257cb6d71 100644 --- a/NetworkPkg/SnpDxe/Reset.c +++ b/NetworkPkg/SnpDxe/Reset.c @@ -94,9 +94,8 @@ SnpUndi32Reset ( // // Resolve Warning 4 unreferenced parameter problem + // ExtendedVerification is not implemented // - ExtendedVerification =3D 0; - DEBUG ((DEBUG_WARN, "ExtendedVerification =3D %d is not implemented!\n",= ExtendedVerification)); if (This =3D=3D NULL) { return EFI_INVALID_PARAMETER; diff --git a/NetworkPkg/SnpDxe/Transmit.c b/NetworkPkg/SnpDxe/Transmit.c index e2c7467b86..1e4ef2a8c3 100644 --- a/NetworkPkg/SnpDxe/Transmit.c +++ b/NetworkPkg/SnpDxe/Transmit.c @@ -289,9 +289,6 @@ SnpUndi32Transmit ( OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); - if (Snp =3D=3D NULL) { - return EFI_DEVICE_ERROR; - } switch (Snp->Mode.State) { case EfiSimpleNetworkInitialized: -- 2.42.0.windows.2 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118789): https://edk2.groups.io/g/devel/message/118789 Mute This Topic: https://groups.io/mt/106016970/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-