From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 99563740045 for ; Fri, 10 May 2024 10:04:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KbFtBbiNZRd/ycQGr7uBeBJIQL/lC4Tx86eL3LVkx10=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715335488; v=1; b=GJMgtxh+rjBiCd+uCkSEWe1qQ3kiMv+syOBX5X+enNlBoqJo7JKyRc2uqbs+R6C+Nb+mb8yF jAycwfmhn00mOwv1ZWbDZgdAa6Lcyfk81VwXgr3UqHX7/QCo2kzLaQVaK740bqtJBIWEVsmiwrZ ziN0cDyrFbUtH8GZL2/M5MpYX5r3g870G4HyytZz4TPl9Y4y3tL486mz4qLGT2vTLkKoqLcHQ2u JHvtW4idZc0FTW2yZjnHshVEnUCTszSdUdyVPnhKNmTa1abimjjkIxfXee6QAJEo9fn7LmMNZWj oeWyItq9pWFWe1bRlfjRg1OJpCfqVw2vlCNwXX5L1G8jA== X-Received: by 127.0.0.2 with SMTP id oQdCYY7687511xcLccYGIek2; Fri, 10 May 2024 03:04:48 -0700 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.116]) by mx.groups.io with SMTP id smtpd.web10.9424.1715335486988451743 for ; Fri, 10 May 2024 03:04:47 -0700 X-Received: from DS7PR10MB5375.namprd10.prod.outlook.com (2603:10b6:5:3ab::11) by PH7PR10MB7732.namprd10.prod.outlook.com (2603:10b6:510:2fe::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.49; Fri, 10 May 2024 10:04:43 +0000 X-Received: from DS7PR10MB5375.namprd10.prod.outlook.com ([fe80::8150:88f6:2efe:6242]) by DS7PR10MB5375.namprd10.prod.outlook.com ([fe80::8150:88f6:2efe:6242%7]) with mapi id 15.20.7544.048; Fri, 10 May 2024 10:04:43 +0000 From: "Santhosh Kumar V via groups.io" To: "devel@edk2.groups.io" , Santhosh Kumar V CC: Sivaraman Nainar , Raj V Akilan , Saloni Kasbekar , Zachary Clark-williams Subject: [edk2-devel] [PATCH] NetworkPkg:MnpDxe:CoverityIssues Thread-Topic: [PATCH] NetworkPkg:MnpDxe:CoverityIssues Thread-Index: AQHaosF6dF9KeaYLLE2LvRKopCER3w== Date: Fri, 10 May 2024 10:04:42 +0000 Message-ID: <20240510100440.1351-1-santhoshkumarv@ami.com> Accept-Language: en-US, en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR10MB5375:EE_|PH7PR10MB7732:EE_ x-ms-office365-filtering-correlation-id: f28f0f56-ab65-45a4-c448-08dc70d89d0f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?iso-8859-1?Q?3Gi5zj6xtXWQb2jDp9xNACF1+5rGjokxWxLYPRczOQ2tQhFOTVT66bpj+I?= =?iso-8859-1?Q?KZ2KEsNivUvTxfs7CQ4qLrBBdUVwCnRXP2IZRO8JH2XM4k8EaER6i9+UFw?= =?iso-8859-1?Q?csRJN4CCKoHbTufG52Clfb9mXELAZKruv1sGDvSp16Wj5M7FaSL9IvVRx6?= =?iso-8859-1?Q?QDkxlWHqW0XgN8S4DGzIOGlIOPPA6cwBQ8ecI9edXFhr8opsxa7L0qvtF6?= =?iso-8859-1?Q?MhMXHoxnsBEwqK6TB97bgiCW85gxuouRNEUKRrYdTP1KIwh3tpygGzL3l6?= =?iso-8859-1?Q?d7F3kleSZV7tGylxsifu+ladXyXFQ1VTdFgFzpUXg1iqm5kkZUdS9mfPfZ?= =?iso-8859-1?Q?AlyFEYdhGXHmz25bFgefMCn1qYBm3eKBg/hlcADVv29BQhYGcBTD4fqaap?= =?iso-8859-1?Q?qRyKHAmdyASWavCXruz1GbTIUrFB6zo9l0NTsOjhAL1hF6uXJbLXIfky7Y?= =?iso-8859-1?Q?S3g6rvOLPmrdquB9fogox8q7aycmbsK8yEX24pQXjHFbJlfuvWWTluoSEV?= =?iso-8859-1?Q?bVVZQOqF66nICv6fNrKcmun+tB32k/NoL1uFklhhD1oj3iI0YWweaotFeT?= =?iso-8859-1?Q?iH7EH9pk7R0GJnsja+A/cf0whdrpidERz1ISGa5GGxUw/O4rCNGteQHQHC?= =?iso-8859-1?Q?b6tiNAb2ks3CekuW/Jyihh2GupmkE3xN4Xz/50KSTlwNdQrMAEFqpzOsrS?= =?iso-8859-1?Q?9yWURHc/1vB+8FgRAa3GMMAPsgArVQrzGdshNU5v1OefjYe6CE5OpxUP5Y?= =?iso-8859-1?Q?tT0j7+bx2JVowZtWXO9++aq7aTiOT4LJU7EdgDS2kZJ989Usd5tH1VQN/Q?= =?iso-8859-1?Q?982DNSMZVPALNIDMclE1jB6M595d+K+YQ8mu1O7m+I9NYv6sW6w9qTDwn7?= =?iso-8859-1?Q?suk4cfgnX4PMbKxdxhJZ7ggiXGV7B05EmB+hubYoF2RouK2CNO+H9eCjGQ?= =?iso-8859-1?Q?BwXXcbBAvSO13RExBOF1u5tOTl1pbJGea8gE7Vtc5kO6TsINTxDMjXzAWS?= =?iso-8859-1?Q?vdg+0WuzCHyVZrsHvYuPkaLPUyg/e7W37OOnqzcK91qA2MqlL9ZEIpenND?= =?iso-8859-1?Q?yhXd3nPaBACxUrX4vYGbYTsHEY0l2lsaeZvt/MXnEVRwuvZfJ00aiyi/w1?= =?iso-8859-1?Q?qLJJUcyun0a0Y0V1Y2aLSYCT3DVsUP1oTdYM5ihe7+PrW5MpBwShV+hHNV?= =?iso-8859-1?Q?TFHClQleHFn3ocE6sv/naQErgg6RHvOR9nxJEg9hldY0kb0HHGZZzlhCuX?= =?iso-8859-1?Q?LnVxw4YGYn3P3iGZkWo65iJ4xhATz17TbcMVPvvHsQnFWy6bul4OO+nBB0?= =?iso-8859-1?Q?kG+u78rCrznaxxO6c/YjQC0lPelgMOWdSQwPKIjgBP3ZjEoiL3XR4s3xzK?= =?iso-8859-1?Q?l93x1/72nuyQKPlWDWP3UF8C/9U5Sh+A=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?oPOOM/4eGk2Dc/bEkKglGjSrjukTkhU1/8Kaqg+eYaf9XwLCQqS65SMbki?= =?iso-8859-1?Q?02qJ+MejsPvZ5JpC1Xl5D+XeW5uKcq0ykEnH71nj4RK+8Su31n0V1Dt9by?= =?iso-8859-1?Q?ot9OMN4C9SVMxznuc+NHT53CrKuUpI+qhmUFeRdtFCUXm9G4igIGY/LpoX?= =?iso-8859-1?Q?FpKVfplr+mGNY/HdgFiuBwGqYpPfFqyRznjnoNYEw+oVDfbTMZYbX8zMwR?= =?iso-8859-1?Q?MRc1CHyHrt8c3VZZ0PIOs54p/qDqZSiAfm2+mF6ylym/ASzT1uU4cICxy+?= =?iso-8859-1?Q?jUar1gr9CcJzm76SDF3wXy4KqV/PHY1vAh5SKtvsU4Zj5RVUNiD1jyxvKN?= =?iso-8859-1?Q?yZPeFS+jYYSLlhPDIasXCOg4dk69jW2XQpZjmm+/5jmndzQrI3shNX8isL?= =?iso-8859-1?Q?6cRTa1wc5XPNCfGzAGOVbPEV1UQNpChckFRS2cTwB67KTVPwf7/deWMHrj?= =?iso-8859-1?Q?dhXCrDIvBZb7R8+YikvHAKDBKll3Zzoyw5UVn7p94ro3ScQNPLYFYHQd2o?= =?iso-8859-1?Q?OgAsf+2fsZ/lfv+OsjtJ0OhPdrttRWAynOupzRZiOJEmwYochqYrDBlRcW?= =?iso-8859-1?Q?dpS6XHPYhiCQoxR4xTulDQlXGSJ0LYCtjLkw+/VQ/zd8S7QPBMrWouoRdX?= =?iso-8859-1?Q?1SGlJ+UuncGln+ZJEPBty/ZiZAuNMlxw3AUXm/O1d65eVaBPEdKIK7VG3T?= =?iso-8859-1?Q?gimLwfj49LptKxAeI8aA6YgQbGtWhu+Wre1L8k64LfsTRBOhKBaXkP+cZe?= =?iso-8859-1?Q?h4vKYZWykyv2nURNk2md426uhxhaLYK2dcgnPPsE5dYYRkUn5JDAwgwY3D?= =?iso-8859-1?Q?iS067GARtNfPlN4Ybg9Fs1WzRDxtInYHgF5HvBCDjcJzf2IvQef/j3KL/c?= =?iso-8859-1?Q?XuYP7UVZ1m3kFogyco6g4RWudvgWQCuFKmqmTJAbpOBfwvoin+h2/jiCDa?= =?iso-8859-1?Q?37SkxkuSbH12TxXNLwNyoOcAGUYP9A54+V5Ifd4LqsQFvFxEBZXVoGDFo2?= =?iso-8859-1?Q?5mbKqgc3W1W145PgXC8JfLe9xQg+/I21Im77d8Fz1UNQmQNYa6cgkE84ut?= =?iso-8859-1?Q?cKOuB/qpLhh589/bjp4tEu9z/oXq16H6209W1L3uOQ/itNbDnQkSQcQtu2?= =?iso-8859-1?Q?MxsxwSPSZpvUOiz1czsru2lXXHJXuSuRV9oq6SOJJTPKF9vV4qhmjVeyXD?= =?iso-8859-1?Q?42I3oDUnaFZZLF2LMD0pKVvi0DgF90l7VNKTFfBfPRmVPWgBwYsAY8C4XA?= =?iso-8859-1?Q?sm6Rtz+7/jgK8TvZ/GAYt9tYpgphOr8Or+m814xR3SrpkEZp1tQlxf8hgG?= =?iso-8859-1?Q?nZeNFI/PxEjRyNggGtzPYQsbkWB990f4zrHDkJ0uA+XWbT4dWJIhYOxkJt?= =?iso-8859-1?Q?mzfAAjREpfbox7jusk/RKj4jJ+XWHWoDHdj/AVKukMmVYpky9vC6V+PMPJ?= =?iso-8859-1?Q?n8K/KR/WLT3Vt75E3Db5n+JGEOURqmt1Gihv+BmDHT0MGuE+J+tV88GAQb?= =?iso-8859-1?Q?wrlCRvHd0NWO+SrOZwOdg6PKnfD7OG+VF/o2Py68dQTfMb6QLLuU2//FTb?= =?iso-8859-1?Q?P7KEU/RV5WVvXW0f9cyRx1qL3DqU66V1v4qQOw7oyae80uHZz5uZTnOfv1?= =?iso-8859-1?Q?s+lxkUexJWrDo/8/djJLwYP+cgxoO8oaEQJFPsbdnY07JUTrFDw4E6gA?= =?iso-8859-1?Q?=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5375.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f28f0f56-ab65-45a4-c448-08dc70d89d0f X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2024 10:04:42.9991 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: odqKO0k3hy9OHWHq7nj7qAWE5bFu2p1sUVBvnx4IPFMs8fPFldMqAqjt1675mtSSqw/hEdbOZDmwxWsdIhA2IQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB7732 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 10 May 2024 03:04:47 -0700 Resent-From: santhoshkumarv@ami.com Reply-To: devel@edk2.groups.io,santhoshkumarv@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: DnhdtU4Z60z5qSAJizkbj750x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=GJMgtxh+; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Resolved INTEGER_OVERFLOW Coverity Issues in MNP Dxe 1.MnpStop,MnpInstanceDeliverPacket Expression "MnpDeviceData->ConfiguredChildrenNumber--" and Instance->RcvdPa= cketQueueSize-- where Both variables are known to be equal to 0, underflow= s the type that receives it. Cc: Saloni Kasbekar Cc: Zachary Clark-williams Signed-off-by: SanthoshKumarV --- NetworkPkg/MnpDxe/MnpConfig.c | 3 ++- NetworkPkg/MnpDxe/MnpIo.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/MnpDxe/MnpConfig.c b/NetworkPkg/MnpDxe/MnpConfig.c index 93587d53aa..80253e88de 100644 --- a/NetworkPkg/MnpDxe/MnpConfig.c +++ b/NetworkPkg/MnpDxe/MnpConfig.c @@ -1313,7 +1313,8 @@ MnpStop ( // // Decrease the children number. // - MnpDeviceData->ConfiguredChildrenNumber--; + if (MnpDeviceData->ConfiguredChildrenNumber > 0) + MnpDeviceData->ConfiguredChildrenNumber--; if (MnpDeviceData->ConfiguredChildrenNumber > 0) { // diff --git a/NetworkPkg/MnpDxe/MnpIo.c b/NetworkPkg/MnpDxe/MnpIo.c index 087c879c46..492edd9b66 100644 --- a/NetworkPkg/MnpDxe/MnpIo.c +++ b/NetworkPkg/MnpDxe/MnpIo.c @@ -351,7 +351,8 @@ MnpInstanceDeliverPacket ( // All resources are OK, remove the packet from the queue. // NetListRemoveHead (&Instance->RcvdPacketQueue); - Instance->RcvdPacketQueueSize--; + if (Instance->RcvdPacketQueueSize !=3D 0) + Instance->RcvdPacketQueueSize--; RxData =3D &RxDataWrap->RxData; SnpMode =3D MnpDeviceData->Snp->Mode; -- 2.42.0.windows.2 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118791): https://edk2.groups.io/g/devel/message/118791 Mute This Topic: https://groups.io/mt/106018089/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-