From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3AF367803D7 for ; Fri, 10 May 2024 10:09:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=81610RfeemDMogKFeJFqqPmwIzKw4PEDYmnjgzR4JIg=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1715335760; v=1; b=jNUzTe2VaiEz7BPpqOG8x/XUFwZJlOBK/Nq+EYUYYM48zbrB6BuIPCD5/oO3JytPqIb7GGA1 ZQmUkTdvS5bIsc7GnAcaZ1ltmeCzd+7gvQt+ahNH+WpptFPbNFyLsThmW4hl0wRXRQ6WiolJSCh ioMBNKctG0WQG/3UVQVQMoOLrWXuj+UGmHJ1pwLD4JabjEaAl4Ja16fTKZBOYm9+VDXMpuVtV/k JmNsjl811Qr6dPDs0pkWWUgPzHuQlyoTXUzTeOSj2/yZogfpetNPjvI6FsUCdU17n+E6/jCXkLR OgVrm29k9S3Lh4erWHpFPOdZS2Co3D8m/3HXV5g/xsj/A== X-Received: by 127.0.0.2 with SMTP id HHDNYY7687511xlAdyuuVEzo; Fri, 10 May 2024 03:09:20 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mx.groups.io with SMTP id smtpd.web10.9485.1715335727366928454 for ; Fri, 10 May 2024 03:09:20 -0700 X-CSE-ConnectionGUID: XsviyTrwTl+AZAOdlugFJw== X-CSE-MsgGUID: hZWVLG+UQ2mvI8kSl4kySQ== X-IronPort-AV: E=McAfee;i="6600,9927,11068"; a="28819201" X-IronPort-AV: E=Sophos;i="6.08,150,1712646000"; d="scan'208";a="28819201" X-Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2024 03:09:20 -0700 X-CSE-ConnectionGUID: cCWP9KPJRyaP/Kv8vdgD6w== X-CSE-MsgGUID: qzUc6ZpzT2eMSzLGcoJHng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,150,1712646000"; d="scan'208";a="60424312" X-Received: from unknown (HELO shwdeopenlab702.ccr.corp.intel.com) ([10.239.55.43]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2024 03:09:19 -0700 From: "duntan" To: devel@edk2.groups.io Cc: Ray Ni , Laszlo Ersek , Rahul Kumar , Gerd Hoffmann , Jiaxin Wu Subject: [edk2-devel] [PATCH 12/18] UefiCpuPkg: Remove code to load mtrr setting Date: Fri, 10 May 2024 18:08:21 +0800 Message-Id: <20240510100827.1903-13-dun.tan@intel.com> In-Reply-To: <20240510100827.1903-1-dun.tan@intel.com> References: <20240510100827.1903-1-dun.tan@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 10 May 2024 03:09:20 -0700 Resent-From: dun.tan@intel.com Reply-To: devel@edk2.groups.io,dun.tan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ovCgMOzuWalW8wAo6NxMQk8jx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=jNUzTe2V; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Remove code to load mtrr setting in CpuS3.c. In previous commits, before transferring to CpuS3.c, MTRR setting has been loaded in S3RestoreConfig2() for all CPU. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Jiaxin Wu --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c index d67fb49890..7ac6b62676 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c @@ -91,36 +91,6 @@ UINT8 mApHltLoopCodeTemplate[] = { 0xEB, 0xFC // jmp $-2 }; -/** - Sync up the MTRR values for all processors. - - @param MtrrTable Table holding fixed/variable MTRR values to be loaded. -**/ -VOID -EFIAPI -LoadMtrrData ( - EFI_PHYSICAL_ADDRESS MtrrTable - ) - -/*++ - -Routine Description: - - Sync up the MTRR values for all processors. - -Arguments: - -Returns: - None - ---*/ -{ - MTRR_SETTINGS *MtrrSettings; - - MtrrSettings = (MTRR_SETTINGS *)(UINTN)MtrrTable; - MtrrSetAllMtrrs (MtrrSettings); -} - /** Increment semaphore by 1. @@ -554,8 +524,6 @@ InitializeCpuBeforeRebase ( IN BOOLEAN IsBsp ) { - LoadMtrrData (mAcpiCpuData.MtrrTable); - SetRegister (TRUE); ProgramVirtualWireMode (); -- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118804): https://edk2.groups.io/g/devel/message/118804 Mute This Topic: https://groups.io/mt/106018137/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-