From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 386EDD8110E for ; Fri, 10 May 2024 14:42:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=EWSoPj+20vsQWxiZ4q1BOQ2nH6URDE2/CfKe04IM5LQ=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20240206; t=1715352148; v=1; b=0oOXwNRiJOnGJnLJwynqs4bGdJrqPuBYGBOClX4ZKYrSV6RLXi6cXGvssbX/VtYQn6j/Z6V+ dj/xE3udYmBhJSWCKWUY8A8QFC5zzLddgNwjjMjMlJxY0+G/+Qnx8Du5eHdqmdv2+8WXVi4RhCd jIcP+O9F9bo2StG5Cjf1XjByxlCwTaW4QDo8y9dZzvcyIeo1AZxKfQWMs+c3HrloKFXVpCKfIhu dQKOUVstKNflViXFqlBpklJp6ttWcD+2n78KaNi0fcFVs5p7231k6n97YjPEBNp0urmtfwYT1jV ++yNDFVUFdCEw7yICrRYt3aSl6JgwZFJEOX3/70prGH7g== X-Received: by 127.0.0.2 with SMTP id kjAKYY7687511xFz0qESPeQM; Fri, 10 May 2024 07:42:28 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.14671.1715352148110421996 for ; Fri, 10 May 2024 07:42:28 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-195-CJIe8J01MlOD174Q2MAF-Q-1; Fri, 10 May 2024 10:42:25 -0400 X-MC-Unique: CJIe8J01MlOD174Q2MAF-Q-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8320F29AC036; Fri, 10 May 2024 14:42:25 +0000 (UTC) X-Received: from osteffen-laptop.redhat.com (unknown [10.39.193.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id 65B7C10B3079; Fri, 10 May 2024 14:42:24 +0000 (UTC) From: "Oliver Steffen" To: devel@edk2.groups.io Cc: Gerd Hoffmann , Oliver Steffen , Liming Gao , Michael D Kinney , Zhiguang Liu Subject: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Warn if out of space when writing variables Date: Fri, 10 May 2024 16:42:20 +0200 Message-ID: <20240510144220.581433-1-osteffen@redhat.com> In-Reply-To: <20240510143515.580797-1-osteffen@redhat.com> References: <20240510143515.580797-1-osteffen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 10 May 2024 07:42:28 -0700 Resent-From: osteffen@redhat.com Reply-To: devel@edk2.groups.io,osteffen@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: H3QfZeqp4Xn4MPtFk31Izmwox7686176AA= Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=0oOXwNRi; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) Emit a DEBUG_ERROR message if there is not enough flash variable left to write/update a variable. This condition is currently not logged appropriately in all cases, given that full variable store can easily render the system unbootable. This new message helps identifying this condition. Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu Signed-off-by: Oliver Steffen Reviewed-by: Laszlo Ersek Reviewed-by: Gerd Hoffmann --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c index d394d237a53f..97317270c4a7 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c @@ -2364,6 +2364,8 @@ UpdateVariable ( ); ASSERT_EFI_ERROR (Status); } + } else if (Status == EFI_OUT_OF_RESOURCES) { + DEBUG ((DEBUG_ERROR, "UpdateVariable failed: Out of variable space\n")); } return Status; -- 2.44.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118820): https://edk2.groups.io/g/devel/message/118820 Mute This Topic: https://groups.io/mt/106022074/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-