From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3AEDED8106C for ; Fri, 17 May 2024 09:46:35 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1Cj5hwMN8nDK/c+XHethcOU0Vh0BwyCz+28DacPAXhw=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1715939193; v=1; b=caL7+aRAQ6Lk0JPIeKgMzA+fmSYH6UTgAwnHC1FpEPpHiAgSiA0V4/HwjaK/owF+xXuKPlIT Hv8cERINyOui0ZgUc+Cq4QT0bwYPP7UWmoOZq+OsvGYUQaIsNo0EVsEs8EtaFNfX4brAAfkXt9n wA8WbbKZ2K8hoYJ2DFBeiuHZ0zxyyjn+RaWv8pyG1dnuO9NaJHJRpYtivp4gdHikVTuZvJi7YwU m2wQrLL/Jje6uLKL0ztyUir8ImRHgV4ETI/6RyLifZd37LUPqKhTofr7ZrpxD/Ht+xHJYWLnjOo wN9KNMJMqx9dgcZiGVm9s9e14IU686uPbRoCEYUVBrQzg== X-Received: by 127.0.0.2 with SMTP id c5pxYY7687511xJp1v9jZt1I; Fri, 17 May 2024 02:46:33 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by mx.groups.io with SMTP id smtpd.web10.35972.1715939193005332147 for ; Fri, 17 May 2024 02:46:33 -0700 X-CSE-ConnectionGUID: lSsGfY09TGyNkE5sPKZq6w== X-CSE-MsgGUID: GC3OXz1mSpuHUWmXB47z9Q== X-IronPort-AV: E=McAfee;i="6600,9927,11074"; a="12318706" X-IronPort-AV: E=Sophos;i="6.08,167,1712646000"; d="scan'208";a="12318706" X-Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 02:46:33 -0700 X-CSE-ConnectionGUID: TW0o0XdMSciX/NYU+vYkfA== X-CSE-MsgGUID: 8aRtHYQ9RFOqyd3PQ9mAyA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,167,1712646000"; d="scan'208";a="36646752" X-Received: from unknown (HELO shwdeopenlab702.ccr.corp.intel.com) ([10.239.55.43]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 02:46:30 -0700 From: "duntan" To: devel@edk2.groups.io Cc: Liming Gao , Jiaxin Wu , Ray Ni , Ard Biesheuvel , Jiewen Yao , Gerd Hoffmann , Rahul Kumar Subject: [edk2-devel] [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm cpu driver Date: Fri, 17 May 2024 17:45:52 +0800 Message-Id: <20240517094610.533-1-dun.tan@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 17 May 2024 02:46:33 -0700 Resent-From: dun.tan@intel.com Reply-To: devel@edk2.groups.io,dun.tan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Wz7JVsNNIJdcJoKDLungR3ETx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=caL7+aRA; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) Comparing to V1 patchs set, the V2 patch set only adjusts the commits ordering and modifies copy right year in some files. This patch set is to remove some S3 related code in CpuS3.c of smm cpu driver. It contain commits to: 1) S3 MTRRs operation: > MdeModulePkg: Add gEdkiiS3MtrrSettingGuid > OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe > UefiCpuPkg: Add locbox lib instance in DSC > UefiCpuPkg: Save MTRR by lockbox in CpuS3DataDxe > UefiCpuPkg: LoadMtrrData for all cpu in S3Resume > UefiCpuPkg: Remove code to load mtrr setting 2) AP page table unavailiable issue fix: > UefiCpuPkg: Disable PG in IA32 ApLoopCode 3) Register table cleanup: > UefiCpuPkg:Set PcdCpuFeaturesInitOnS3Resume to TRUE > UefiCpuPkg: Remove code to set register table 4) S3 ApHltLoopCode Operation: > UefiCpuPkg:Abstract some DxeMpLib code to function > UefiCpuPkg:Move some code in DxeMpLib to common place > UefiCpuPkg: Install gEdkiiEndOfS3ResumeGuid in S3Resume > UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib > UefiCpuPkg:Remove code to handle APIC setting and Interrupt > UefiCpuPkg:Rremove code to wakeup AP and relocate ap > UefiCpuPkg: Remove the duplicated mpservice locate > MdeModulePkg: remove MpService2Ppi field in SMM_S3_RESUME_STATE 5) Remove code to get AcpiCpuData: > UefiCpuPkg: Remove GetAcpiCpuData() in CpuS3.c With this patch set, CpuS3.c in smm CPU driver can be simplified. The whole patch set has been reviewed-by Ray. PR for review: https://github.com/tianocore/edk2/pull/5606 Cc: Liming Gao Cc: Jiaxin Wu Cc: Ray Ni Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Cc: Rahul Kumar Cc: Gerd Hoffmann Dun Tan (18): MdeModulePkg: Add gEdkiiS3MtrrSettingGuid OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe UefiCpuPkg: Add locbox lib instance in DSC UefiCpuPkg: Save MTRR by lockbox in CpuS3DataDxe UefiCpuPkg: LoadMtrrData for all cpu in S3Resume UefiCpuPkg: Remove code to load mtrr setting UefiCpuPkg:Set PcdCpuFeaturesInitOnS3Resume to TRUE UefiCpuPkg: Remove code to set register table UefiCpuPkg: Disable PG in IA32 ApLoopCode UefiCpuPkg:Abstract some DxeMpLib code to function UefiCpuPkg:Move some code in DxeMpLib to common place UefiCpuPkg: Install gEdkiiEndOfS3ResumeGuid in S3Resume UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib UefiCpuPkg:Remove code to handle APIC setting and Interrupt UefiCpuPkg:Remove code to wakeup AP and relocate ap UefiCpuPkg: Remove unneeded MpService2Ppi assignment MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE UefiCpuPkg: Remove GetAcpiCpuData() in CpuS3.c MdeModulePkg/Include/Guid/AcpiS3Context.h | 3 +-- MdeModulePkg/MdeModulePkg.dec | 5 ++++- OvmfPkg/CpuS3DataDxe/CpuS3Data.c | 13 ++++++++++++- OvmfPkg/CpuS3DataDxe/CpuS3DataDxe.inf | 4 +++- UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c | 13 ++++++++++++- UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf | 4 +++- UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 183 ++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------------------------------------- UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm | 6 +++++- UefiCpuPkg/Library/MpInitLib/MpLib.c | 144 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- UefiCpuPkg/Library/MpInitLib/MpLib.h | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++-- UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 6 +++++- UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 154 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 993 +++++++++---------------------------------------------------------------------------------------------------------------------------------------------------------------------- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.nasm | 153 ------------------------------------------------------------------------------------------------------------------------------------------------- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c | 29 +--------------------------- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 8 +++----- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 26 +------------------------ UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 5 +---- UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm | 189 ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c | 30 +---------------------------- UefiCpuPkg/UefiCpuPkg.dec | 4 ++-- UefiCpuPkg/UefiCpuPkg.dsc | 3 ++- UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------- UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf | 4 +++- 24 files changed, 531 insertions(+), 1582 deletions(-) delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.nasm delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm -- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118997): https://edk2.groups.io/g/devel/message/118997 Mute This Topic: https://groups.io/mt/106150757/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-