From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 21A72941AAC for ; Tue, 21 May 2024 14:14:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=BZNT7fOGO8QrsMCKOv395k8kRda0fV/W8EHmHE60xX4=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1716300853; v=1; b=vhu7D0DX18Im0eSGAvEmUnDNt2us9sqqHPsP+fD+9VEX3UoS9DmREO3QoVlk6HiPN6+Ylopx hTp5Q8AIAzMNoP4Nlcc7UDK4Z7sAJSN5FX7i3Hm2On9BxRUWSvTZGYEPFLlK4ebTLxqzqpYM8Jg /PnzKT0IuP5wFTLTlAtWxKz/o37EqHrqEE8w7tYg521FsxVo02ZFfzypSA8N/ahTQ+tNOE0sS6w BU2yu1cpAwdBKXDaFFnW/hW9r8o9YM4sM89ezI77xRW7/QPAjqpUHX/wMn9OEZNIAVT6OkS/wJr tap/D/qOH70mb/JeD6gt+705OXr3RwWDOKiIfWGkdUAJw== X-Received: by 127.0.0.2 with SMTP id 90QkYY7687511ximUNrxWhzM; Tue, 21 May 2024 07:14:13 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.112]) by mx.groups.io with SMTP id smtpd.web10.20726.1716300843437053037 for ; Tue, 21 May 2024 07:14:07 -0700 X-Received: from DS7PR10MB5375.namprd10.prod.outlook.com (2603:10b6:5:3ab::11) by IA0PR10MB7133.namprd10.prod.outlook.com (2603:10b6:208:400::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.36; Tue, 21 May 2024 14:13:57 +0000 X-Received: from DS7PR10MB5375.namprd10.prod.outlook.com ([fe80::8757:aab6:b828:4f4d]) by DS7PR10MB5375.namprd10.prod.outlook.com ([fe80::8757:aab6:b828:4f4d%6]) with mapi id 15.20.7587.035; Tue, 21 May 2024 14:13:54 +0000 From: "Santhosh Kumar V via groups.io" To: "devel@edk2.groups.io" , Santhosh Kumar V CC: Sivaraman Nainar , Raj V Akilan , Saloni Kasbekar , Zachary Clark-williams Subject: [edk2-devel] [PATCH] NetworkPkg:MnpDxe:CoverityIssues Thread-Topic: [PATCH] NetworkPkg:MnpDxe:CoverityIssues Thread-Index: AQHaq4kcBxAuVZ3FGEaED9FKJAxwbw== Date: Tue, 21 May 2024 14:13:54 +0000 Message-ID: <20240521141349.1213-1-santhoshkumarv@ami.com> Accept-Language: en-US, en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR10MB5375:EE_|IA0PR10MB7133:EE_ x-ms-office365-filtering-correlation-id: b1849b24-2a2e-4888-f9b4-08dc79a03f77 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?iso-8859-1?Q?jJOyjbg7XLJo1QxFaaiVJGKs+0TM2y+lAgvqAmWKj74G7cWBrnt/x6TxXm?= =?iso-8859-1?Q?5G/Yhi5ndBWlPg51KjJ1wq25XIDjRvmfv8w7FzxSa6YAedKgMilhGk2sQJ?= =?iso-8859-1?Q?UAE8Dd6wyEh4sKBdxcE7LEIA0S6eoWnvfDw5S8nBythQTgVHTvgZt617vl?= =?iso-8859-1?Q?u11sv71BjUpkQlwelzITEPGPY1Pc3tnKmm8VyoehqxbRD7hZQQgb/Pva1P?= =?iso-8859-1?Q?nUzMvHEh+lz4FQnyy+iXXazRAkAecuIlKS993IdRQWyh1gcXGbb2MJeaWA?= =?iso-8859-1?Q?bkdoRZgnFUrERJr2BD0j4Cgn3lWNQCRF+Q+XSrdRoUHxXiWoFPHkusK4VA?= =?iso-8859-1?Q?NEelwzJWny/cXYAjwRkhp/72zN8YrrBcJxZjGGl2IzwvYTpLHEK25mwXKl?= =?iso-8859-1?Q?/WJSO7BfniyRMow5psydYUIzAf4buQYXxn53DoQZ5l5pFqzMCM/8W9pIU2?= =?iso-8859-1?Q?Q3R0KyrYDpy1Y9FsYlLqLRdqFcfsWZMYiBPyPimvPPzjnM5t/k2vWAJqI6?= =?iso-8859-1?Q?Vpcx2DVku1GOCaQRbYIU/v+eGj+6hITuEemYWNq10MqeCggTO4sLeYoS+q?= =?iso-8859-1?Q?8oQIYo4kg+LFYdsCAfsbICMNEBdg12ZcCwCPjYLgtF3DpdUI6QsxhwiQcM?= =?iso-8859-1?Q?NiGRHcetTv3uCPVHaBBA2lShTFBft3G/HWC4keDOi6nEpUtY7L7RL1A/qP?= =?iso-8859-1?Q?PklpalzzdgERS9buscnBFsWokeY+r5SnD975tWWkJ5GUYreTLGVWS7OliB?= =?iso-8859-1?Q?PYPnjbc/wesTV2nyEo/GQyfI4lsWonZhM4aKV+zwggLkgy/OkLhCbGCQZ/?= =?iso-8859-1?Q?oNTL/n6yytRKzFg6YaudOeyX0UFc+8prxUdOzU6zYeXbv5pqDenew3Hejs?= =?iso-8859-1?Q?aDs17ZJ/caqXNJWPg6VypB1BNZlrmtFE/QXWKZ9LKfFwp8/FzsCY22vQJk?= =?iso-8859-1?Q?nBthETduNfuGueNG/32ZkfHfWOeCx0bCfdajDUMuVRvo279zQ6zeGMNWWz?= =?iso-8859-1?Q?FG2PTLrb4KSoNthB03cS0GUy1T3U+95HDM4NYwTkx/DFytWvzZo7/DwHIj?= =?iso-8859-1?Q?p7DVMpaJfhL65n2ftPNxk06J6Kv7mSuNPVXn1fOD+a76QFb3G5UIgr9c6G?= =?iso-8859-1?Q?/9RGPmbTNYBBP9npWtnoDnetAHH/oNJzkAjNfplrisTM94jy8nn6Kst/Gc?= =?iso-8859-1?Q?s0yX26jMFU9i7j0VIVNLo0MeDxclCSdJhWI+B/9pLeYMKr+pRM8BLkvNJ6?= =?iso-8859-1?Q?3XoCiu4+pM93Poyb7Inwo40QjGX+pcajkl39UIbbbUFMhNbdTenckG8vYb?= =?iso-8859-1?Q?xyyCwcplKHCuvmD1ZNMB6/4siRehQAubocY9hoZW2v8oxkiQn2waBTi+dQ?= =?iso-8859-1?Q?F5Ow0R3xrplIKY4ppB8uEW0EIcJg8NtQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?X+8Gub49WThDQm5lAkwQoGsU2u0q4g8us6OcfK9gkpir6qet0lA0v2oQAT?= =?iso-8859-1?Q?HgQsknZDvi5qUGmXy1TVTd8IYKVmrERenwpyDfcT8kIqHETiun9snIDS4z?= =?iso-8859-1?Q?HAyouySzcuW4iNHGq0R0eLBHFeB8TAoGCk7ug3CeZcrj2JZSgbR0VY7JPe?= =?iso-8859-1?Q?VriWKT8UX6Nar27hDocNQr7ekOG15LDBliG8k3ujPvHBTK71MnTzOe+E5W?= =?iso-8859-1?Q?buVsyp8ppcz0fkOfcjdh3Qs5Afh0zugYmPuFpODzGFlKocYxnUU90EnT0Q?= =?iso-8859-1?Q?nxwEzNRZ2ezs8EWnE83K6aZzI6xz7EGgqA1HZEMyGXg8HvvNVDLBiXeUWz?= =?iso-8859-1?Q?x9QYd6jknaoiPvcq1ToHyCTXV875kCBXd+EQVhxIaDQUHIb89fOVfbhKta?= =?iso-8859-1?Q?aVVNRP9rhkYSRD7gL5tZNIg7WHfCk5pL1Ee1A1fW9wRWZKSeKrYA/j9joY?= =?iso-8859-1?Q?74bCKuVZCstTUEaImmr4pJIddevYGaAdymqNxK96xEO+OouaIxGrSLp3ws?= =?iso-8859-1?Q?96wtZS9vgqcYT0I7tAdhwMNwXSoKpUNVSb0o7ZGtv1zeCFRHGxyQTObH80?= =?iso-8859-1?Q?dTn9GweakEnpzO1I2yqfzRutKbT+3mixVLLe8/q8SZUaeVnHCqwoxXSvPo?= =?iso-8859-1?Q?oTT2NagQNe6xsEFT6YRtnCtqC/O3QukZx1zREEVSyV3uj0xcYP57cGgFnV?= =?iso-8859-1?Q?UJk18gH7OsD7Qz75vkxykNa6RuLdgO0koABMjqpiTcZ2CBMotsQh/L6pS5?= =?iso-8859-1?Q?A611jZ4j3e9dLPdsi5ZmK0MsNL7UcX6prpE1pLVx3o4T6g8y01zDf8ik6S?= =?iso-8859-1?Q?Q91g/pHmNMwN+X4r32/rjUKZkuzu047NDJWa7lhKuyakMzYwwuWKZgaY3c?= =?iso-8859-1?Q?iHpSocIh8YxDpYauv6P2qV2Y77eU68XObs7vrrw1J6hmZ/S4SmmUI/fdTz?= =?iso-8859-1?Q?M3GPreJiJ1dNUkmY+djkJGeeUFsFWH0RtLueNyCIXYxkJ6JLRd6JSt3bjE?= =?iso-8859-1?Q?cRx2rlOqQv08ewM8HF+mtgYuxQFRMjnAvZQbeQ1gTjqS0qd2SKOXwmeLnP?= =?iso-8859-1?Q?uF++Pb96pjqHbUVx4v/c8u5aotmtEsJD4frZOpAep47nuasdhco5QRRtgz?= =?iso-8859-1?Q?4CgmhRbDeEr0J+Hs5uYA09MKwb+E956/ehhXIjX18CJ1xGpjC5UkN/WtRc?= =?iso-8859-1?Q?6FRdBu+xIEuGbyG40okZ/8mce2PKCyiS19PVUJM2iMa0dC6Dc/8UJyAQPk?= =?iso-8859-1?Q?76gf/zMK4CIzmAmVsXV4o/wvEm4syG4JFshz/VGrEQSyGYGcu87nhYCOZr?= =?iso-8859-1?Q?nN8QP6ENpbn/TpEYlaa90uZn1KaT+EYRL3PWKWDe49JCLv/b7glTcTKsxL?= =?iso-8859-1?Q?a+CJL4Hjx11QBi9qrRmUdALDsJxWypIPUR7cjP5CcQ7dVsmlISCGZdoSJl?= =?iso-8859-1?Q?FSXJH4khCnt1zTFYpCf5ifGn3ROOMmWHWAfZPbbrrWDXM1nbCHpnglw7XE?= =?iso-8859-1?Q?mwzMf9Uey4tCtIqiWtqytUzbCt2GcNLP+Xw4rUc/uxoqXnB5UKWRz/X8/s?= =?iso-8859-1?Q?9EZiGKXUv5ARctJw3jhszNM4/ERqcyKQbPY2HKkkv5Rw/dG4q+6UvZ+lz/?= =?iso-8859-1?Q?1t4tz4tM4bWpGGbK3Uml76ToM+agBEfsMF1IXYlxNLaYdiEEWkPnHlUA?= =?iso-8859-1?Q?=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5375.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1849b24-2a2e-4888-f9b4-08dc79a03f77 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2024 14:13:54.6282 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NBZg32Jd/HC8XiAcwZVk7DlsSkC5kEs9YF3ub4UmgFodIqRSUOJ7YlVsHkv5rzLLgYoJ7onxKgWeodQHdKA52g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7133 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 21 May 2024 07:14:07 -0700 Resent-From: santhoshkumarv@ami.com Reply-To: devel@edk2.groups.io,santhoshkumarv@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ADixUzU12NVoUB4jfoc4m9BQx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=vhu7D0DX; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Both the cases have ASSERTs checking that the value is greater than 0. Move= the checks to the same location as the ASSERT. I'd also prefer if we retur= n with a failure instead of forcing continuation of the function with an in= valid value. Thanks, Saloni Addressed above comments and made changes, please review the latest changes= below and kindly review coverity changes for other modules too. Cc: Saloni Kasbekar Cc: Zachary Clark-williams Signed-off-by: SanthoshKumarV --- NetworkPkg/MnpDxe/MnpConfig.c | 3 +++ NetworkPkg/MnpDxe/MnpIo.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/NetworkPkg/MnpDxe/MnpConfig.c b/NetworkPkg/MnpDxe/MnpConfig.c index 93587d53aa..12fc80ad0c 100644 --- a/NetworkPkg/MnpDxe/MnpConfig.c +++ b/NetworkPkg/MnpDxe/MnpConfig.c @@ -1304,6 +1304,9 @@ MnpStop ( NET_CHECK_SIGNATURE (MnpServiceData, MNP_SERVICE_DATA_SIGNATURE); MnpDeviceData =3D MnpServiceData->MnpDeviceData; ASSERT (MnpDeviceData->ConfiguredChildrenNumber > 0); + + if (MnpDeviceData->ConfiguredChildrenNumber <=3D 0) + return EFI_OUT_OF_RESOURCES; // // Configure the receive filters. diff --git a/NetworkPkg/MnpDxe/MnpIo.c b/NetworkPkg/MnpDxe/MnpIo.c index 087c879c46..24dfad10fa 100644 --- a/NetworkPkg/MnpDxe/MnpIo.c +++ b/NetworkPkg/MnpDxe/MnpIo.c @@ -326,6 +326,9 @@ MnpInstanceDeliverPacket ( ASSERT (Instance->RcvdPacketQueueSize !=3D 0); + if (Instance->RcvdPacketQueueSize =3D=3D 0) + return EFI_OUT_OF_RESOURCES; + RxDataWrap =3D NET_LIST_HEAD (&Instance->RcvdPacketQueue, MNP_RXDATA_WRA= P, WrapEntry); if (RxDataWrap->Nbuf->RefCnt > 2) { // -- 2.42.0.windows.2 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119104): https://edk2.groups.io/g/devel/message/119104 Mute This Topic: https://groups.io/mt/106223813/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-