From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0A1CA94141A for ; Wed, 29 May 2024 08:55:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=zHAbODEF8uwi+9By/2aGSdi8OAdtosyKBC77XarZ2E8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1716972946; v=1; b=ABfGTOPR7KSxQeEgz8z95ZuNvNnpTOmNwnm43Hdd0Nh8+8uvo/Amm4WNrtKoRyEu4gwjc8HT WhwXk/iP/UdoZE2IPRy3rxkjm7snvUUZ0qdxPFgYrnTCnD98cTy3Lnr/MmeIQjqgqiWEJzPDvBc tm9lTWxX9ytPDIcLtrPBsleyJKPct/T6cpS9yiVcRcdzpkmctRr5NTQQV53O7uT4Vy8OcPWg4/P rTIETxi+NsGGjxhywTwmE3r+556jiMBrgeLMmcyOuxV/liAu7khEgeTd7qafWAqBIW732BDcYyR gPGVGVXIb60xrK94EKmSs2AUbI80Dr3hVUDHOSdqyBrXA== X-Received: by 127.0.0.2 with SMTP id 6oIdYY7687511x5lwlGlJLWA; Wed, 29 May 2024 01:55:45 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.9245.1716972940203089909 for ; Wed, 29 May 2024 01:55:40 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 278632F4; Wed, 29 May 2024 01:56:04 -0700 (PDT) X-Received: from usa.arm.com (a077434.arm.com [10.162.46.143]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 42BAD3F762; Wed, 29 May 2024 01:55:38 -0700 (PDT) From: "Sahil Kaushal" To: devel@edk2.groups.io Cc: Ard Biesheuvel , =?UTF-8?q?Leif=20Lindholm=20=C2=A0?= , Sami Mujawar , =?UTF-8?q?sahil=20=C2=A0?= Subject: [edk2-devel] [edk2-platforms][PATCH V4 06/17] Platform/ARM/NorFlashDxe: Make local functions STATIC Date: Wed, 29 May 2024 14:25:06 +0530 Message-Id: <20240529085517.1074417-7-Sahil.Kaushal@arm.com> In-Reply-To: <20240529085517.1074417-1-Sahil.Kaushal@arm.com> References: <20240529085517.1074417-1-Sahil.Kaushal@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 29 May 2024 01:55:40 -0700 Resent-From: sahil.kaushal@arm.com Reply-To: devel@edk2.groups.io,sahil.kaushal@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1eTxv3x1BfyRfZCalwEqxHWox7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ABfGTOPR; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io From: sahil This patch makes local functions not being used outside NorFlash.c STATIC. Also, NorFlashWriteBuffer() is specific to a particular flash implementation and need not be implemented by other NOR flash device IPs. Signed-off-by: sahil --- Platform/ARM/Drivers/NorFlashDxe/NorFlash.h | 21 -------------------- Platform/ARM/Drivers/NorFlashDxe/NorFlash.c | 3 +++ 2 files changed, 3 insertions(+), 21 deletions(-) diff --git a/Platform/ARM/Drivers/NorFlashDxe/NorFlash.h b/Platform/ARM/D= rivers/NorFlashDxe/NorFlash.h index 3102c5e13bad..f30d499042ed 100644 --- a/Platform/ARM/Drivers/NorFlashDxe/NorFlash.h +++ b/Platform/ARM/Drivers/NorFlashDxe/NorFlash.h @@ -134,14 +134,6 @@ struct _NOR_FLASH_INSTANCE { NOR_FLASH_DEVICE_PATH DevicePath; }; =20 -EFI_STATUS -NorFlashWriteBuffer ( - IN NOR_FLASH_INSTANCE *Instance, - IN UINTN TargetAddress, - IN UINTN BufferSizeInBytes, - IN UINT32 *Buffer - ); - // // NorFlash.c // @@ -190,19 +182,6 @@ NorFlashEraseSingleBlock ( IN UINTN BlockAddress ); =20 -EFI_STATUS -NorFlashUnlockSingleBlockIfNecessary ( - IN NOR_FLASH_INSTANCE *Instance, - IN UINTN BlockAddress - ); - -EFI_STATUS -NorFlashWriteSingleWord ( - IN NOR_FLASH_INSTANCE *Instance, - IN UINTN WordAddress, - IN UINT32 WriteData - ); - EFI_STATUS NorFlashWriteFullBlock ( IN NOR_FLASH_INSTANCE *Instance, diff --git a/Platform/ARM/Drivers/NorFlashDxe/NorFlash.c b/Platform/ARM/D= rivers/NorFlashDxe/NorFlash.c index 15000a692b02..254b8937e210 100644 --- a/Platform/ARM/Drivers/NorFlashDxe/NorFlash.c +++ b/Platform/ARM/Drivers/NorFlashDxe/NorFlash.c @@ -103,6 +103,7 @@ NorFlashUnlockSingleBlock ( return EFI_SUCCESS; } =20 +STATIC EFI_STATUS NorFlashUnlockSingleBlockIfNecessary ( IN NOR_FLASH_INSTANCE *Instance, @@ -175,6 +176,7 @@ NorFlashEraseSingleBlock ( return Status; } =20 +STATIC EFI_STATUS NorFlashWriteSingleWord ( IN NOR_FLASH_INSTANCE *Instance, @@ -245,6 +247,7 @@ NorFlashWriteSingleWord ( * Therefore, it is a requirement to align buffer writes to 32-bit word = boundaries. * i.e. the last 4 bits of the target start address must be zero: 0x....= ..00 */ +STATIC EFI_STATUS NorFlashWriteBuffer ( IN NOR_FLASH_INSTANCE *Instance, --=20 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119321): https://edk2.groups.io/g/devel/message/119321 Mute This Topic: https://groups.io/mt/106365456/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-