[edk2-devel] [PATCH edk2-platforms 0/6] JadePkg and common Ampere code fixes

[edk2-devel] [PATCH edk2-platforms 0/6] JadePkg and common Ampere code fixes

[Rebecca Cran]

These are a set of bug fixes I made to the Mt Jade and common Ampere
code while working on updating and improving ADLINK's edk2_aadp
project.

Rebecca Cran (6):
  Silicon/Ampere: Fix capitalization of Cache strings in PlatformInfoDxe
  Silicon/Ampere: Reduce DEBUG_INFO spam in PciSegmentLibPci
  Silicon/Ampere: Add TimerLib to DwGpioLib.inf for MicroSecondDelay
  Platform/Ampere: Don't try and close the ACPI table if OpenSdt fails
  Silicon/Ampere: Set default SMBIOS fw major/minor version to 0xFF
  Silicon/Ampere: Remove bogus ASSERT that *PpiList is non-NULL

 Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec                          |  4 ++--
 Silicon/Ampere/AmpereAltraPkg/Library/DwGpioLib/DwGpioLib.inf                 |  1 +
 Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c                    |  1 -
 Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.c         |  1 -
 Silicon/Ampere/AmpereAltraPkg/Library/PciSegmentLibPci/PciSegmentLib.c        | 24 ++++++++++----------
 Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoStrings.uni |  6 ++---
 6 files changed, 18 insertions(+), 19 deletions(-)

-- 
2.45.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119495): https://edk2.groups.io/g/devel/message/119495
Mute This Topic: https://groups.io/mt/106517021/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 1/6] Silicon/Ampere: Fix capitalization of Cache strings in PlatformInfoDxe

[Rebecca Cran]

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoStrings.uni | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoStrings.uni b/Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoStrings.uni
index 235d104c217f..c3b25a29f713 100644
--- a/Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoStrings.uni
+++ b/Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoStrings.uni
@@ -32,13 +32,13 @@
 #string STR_PLATFORM_INFO_PCPCLK                    #language en-US "PCP Clock"
 #string STR_PLATFORM_INFO_PCPCLK_VALUE              #language en-US "0MHz"
 
-#string STR_PLATFORM_INFO_L1ICACHE                  #language en-US "L1I CACHE"
+#string STR_PLATFORM_INFO_L1ICACHE                  #language en-US "L1I Cache"
 #string STR_PLATFORM_INFO_L1ICACHE_VALUE            #language en-US "0KB"
 
-#string STR_PLATFORM_INFO_L1DCACHE                  #language en-US "L1D CACHE"
+#string STR_PLATFORM_INFO_L1DCACHE                  #language en-US "L1D Cache"
 #string STR_PLATFORM_INFO_L1DCACHE_VALUE            #language en-US "0KB"
 
-#string STR_PLATFORM_INFO_L2CACHE                   #language en-US "L2 CACHE"
+#string STR_PLATFORM_INFO_L2CACHE                   #language en-US "L2 Cache"
 #string STR_PLATFORM_INFO_L2CACHE_VALUE             #language en-US "0KB"
 
 #string STR_PLATFORM_INFO_SOCCLK                    #language en-US "SOC Clock"
-- 
2.45.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119496): https://edk2.groups.io/g/devel/message/119496
Mute This Topic: https://groups.io/mt/106517022/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 2/6] Silicon/Ampere: Reduce DEBUG_INFO spam in PciSegmentLibPci

[Rebecca Cran]

Reduce the spam when DEBUG_INFO is enabled by switching DEBUG prints in
PciSegmentLibPci from DEBUG_INFO to DEBUG_VERBOSE.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 Silicon/Ampere/AmpereAltraPkg/Library/PciSegmentLibPci/PciSegmentLib.c | 24 ++++++++++----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/PciSegmentLibPci/PciSegmentLib.c b/Silicon/Ampere/AmpereAltraPkg/Library/PciSegmentLibPci/PciSegmentLib.c
index 898558db8d3b..483da44d131c 100644
--- a/Silicon/Ampere/AmpereAltraPkg/Library/PciSegmentLibPci/PciSegmentLib.c
+++ b/Silicon/Ampere/AmpereAltraPkg/Library/PciSegmentLibPci/PciSegmentLib.c
@@ -143,7 +143,7 @@ PciSegmentRead8 (
   Value = WORD_GET_BYTE (Val32, CfgBase & WORD_ALIGN_MASK);
 
   DEBUG ((
-    DEBUG_INFO,
+    DEBUG_VERBOSE,
     "PCIe CFG RD8: 0x%p value: 0x%02X (0x%08llX 0x%08X)\n",
     CfgBase,
     Value,
@@ -190,7 +190,7 @@ PciSegmentWrite8 (
   MmioWrite32 (AlignedAddr, Val32);
 
   DEBUG ((
-    DEBUG_INFO,
+    DEBUG_VERBOSE,
     "PCIe CFG WR8: 0x%p value: 0x%02X (0x%08llX 0x%08X)\n",
     CfgBase,
     Value,
@@ -522,7 +522,7 @@ PciSegmentRead16 (
   if ((GET_BUS_NUM (CfgBase) > 0) && (GET_DEV_NUM (CfgBase) > 0) && (GET_REG_NUM (CfgBase) == 0)) {
     Value = MmioRead32 (CfgBase);
     DEBUG ((
-      DEBUG_INFO,
+      DEBUG_VERBOSE,
       "PCIe CFG RD16: B%X|D%X 0x%p value: 0x%08X\n",
       GET_BUS_NUM (CfgBase),
       GET_DEV_NUM (CfgBase),
@@ -534,7 +534,7 @@ PciSegmentRead16 (
       Val32 = MmioRead32 (CfgBase + HEADER_TYPE_REG);
 
       HeaderType = GET_HEADER_TYPE (Val32);
-      DEBUG ((DEBUG_INFO, "  Peek RD: HeaderType=0x%02X\n", HeaderType));
+      DEBUG ((DEBUG_VERBOSE, "  Peek RD: HeaderType=0x%02X\n", HeaderType));
 
       // Type 1 Configuration Space Header
       if (HeaderType != 0) {
@@ -545,7 +545,7 @@ PciSegmentRead16 (
       if ((HeaderType == 0) || (PrimaryBus != 0)) {
         Value = 0xFFFF;
         DEBUG ((
-          DEBUG_INFO,
+          DEBUG_VERBOSE,
           "  Skip RD16 B%X|D%X PCIe CFG RD: 0x%p return 0xFFFF\n",
           GET_BUS_NUM (CfgBase),
           GET_DEV_NUM (CfgBase),
@@ -560,7 +560,7 @@ PciSegmentRead16 (
   Value = WORD_GET_HALF_WORD (Val32, CfgBase & WORD_ALIGN_MASK);
 
   DEBUG ((
-    DEBUG_INFO,
+    DEBUG_VERBOSE,
     "PCIe CFG RD16: 0x%p value: 0x%04X (0x%08llX 0x%08X)\n",
     CfgBase,
     Value,
@@ -614,7 +614,7 @@ PciSegmentWrite16 (
   MmioWrite32 (AlignedAddr, Val32);
 
   DEBUG ((
-    DEBUG_INFO,
+    DEBUG_VERBOSE,
     "PCIe CFG WR16: 0x%p value: 0x%04X (0x%08llX 0x%08X)\n",
     CfgBase,
     Value,
@@ -955,7 +955,7 @@ PciSegmentRead32 (
   if ((GET_BUS_NUM (CfgBase) > 0) && (GET_DEV_NUM (CfgBase) > 0) && (GET_REG_NUM (CfgBase) == 0)) {
     Value = MmioRead32 (CfgBase);
     DEBUG ((
-      DEBUG_INFO,
+      DEBUG_VERBOSE,
       "PCIe CFG RD32: B%X|D%X 0x%p value: 0x%08X\n",
       GET_BUS_NUM (CfgBase),
       GET_DEV_NUM (CfgBase),
@@ -967,7 +967,7 @@ PciSegmentRead32 (
       Val32 = MmioRead32 (CfgBase + HEADER_TYPE_REG);
 
       HeaderType = GET_HEADER_TYPE (Val32);
-      DEBUG ((DEBUG_INFO, "  Peek RD: HeaderType=0x%02X\n", HeaderType));
+      DEBUG ((DEBUG_VERBOSE, "  Peek RD: HeaderType=0x%02X\n", HeaderType));
 
       // Type 1 Configuration Space Header
       if (HeaderType != 0) {
@@ -978,7 +978,7 @@ PciSegmentRead32 (
       if ((HeaderType == 0) || (PrimaryBus != 0)) {
         Value = 0xFFFFFFFF;
         DEBUG ((
-          DEBUG_INFO,
+          DEBUG_VERBOSE,
           "  Skip RD32 B%X|D%X PCIe CFG RD: 0x%p return 0xFFFFFFFF\n",
           GET_BUS_NUM (CfgBase),
           GET_DEV_NUM (CfgBase),
@@ -991,7 +991,7 @@ PciSegmentRead32 (
     Value = MmioRead32 (CfgBase);
   }
 
-  DEBUG ((DEBUG_INFO, "PCIe CFG RD32: 0x%p value: 0x%08X\n", CfgBase, Value));
+  DEBUG ((DEBUG_VERBOSE, "PCIe CFG RD32: 0x%p value: 0x%08X\n", CfgBase, Value));
 
   return Value;
 }
@@ -1025,7 +1025,7 @@ PciSegmentWrite32 (
   CfgBase = GetMmcfgBase (GET_SEG_NUM (Address)) + (Address & 0x0FFFFFFC);
   MmioWrite32 (CfgBase, Value);
   DEBUG ((
-    DEBUG_INFO,
+    DEBUG_VERBOSE,
     "PCIe CFG WR32: 0x%p value: 0x%08X (0x%08X)\n",
     CfgBase,
     Value,
-- 
2.45.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119497): https://edk2.groups.io/g/devel/message/119497
Mute This Topic: https://groups.io/mt/106517024/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 3/6] Silicon/Ampere: Add TimerLib to DwGpioLib.inf for MicroSecondDelay

[Rebecca Cran]

The NOOPT build was failing because MicroSecondDelay is called but
TimerLib wasn't included in DwGpioLib.inf

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 Silicon/Ampere/AmpereAltraPkg/Library/DwGpioLib/DwGpioLib.inf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/DwGpioLib/DwGpioLib.inf b/Silicon/Ampere/AmpereAltraPkg/Library/DwGpioLib/DwGpioLib.inf
index 36ce0c3be2c8..d94bec7ac455 100644
--- a/Silicon/Ampere/AmpereAltraPkg/Library/DwGpioLib/DwGpioLib.inf
+++ b/Silicon/Ampere/AmpereAltraPkg/Library/DwGpioLib/DwGpioLib.inf
@@ -28,6 +28,7 @@ [LibraryClasses]
   BaseLib
   BaseMemoryLib
   IoLib
+  TimerLib
 
 [Guids]
   gEfiEventVirtualAddressChangeGuid
-- 
2.45.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119498): https://edk2.groups.io/g/devel/message/119498
Mute This Topic: https://groups.io/mt/106517026/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 4/6] Platform/Ampere: Don't try and close the ACPI table if OpenSdt fails

[Rebecca Cran]

In AcpiPatchDsdtTable if the call to OpenSdt fails, don't try and
close the TableHandle since it causes a crash.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c
index 885ad8fc3511..da7b50fd6d5e 100644
--- a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c
+++ b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c
@@ -671,7 +671,6 @@ AcpiPatchDsdtTable (
   Status = AcpiSdtProtocol->OpenSdt (TableKey, &TableHandle);
   if (EFI_ERROR (Status)) {
     ASSERT_EFI_ERROR (Status);
-    AcpiSdtProtocol->Close (TableHandle);
     return Status;
   }
 
-- 
2.45.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119499): https://edk2.groups.io/g/devel/message/119499
Mute This Topic: https://groups.io/mt/106517027/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 5/6] Silicon/Ampere: Set default SMBIOS fw major/minor version to 0xFF

[Rebecca Cran]

According to the SMBIOS specification, the firmware version major/minor
values should be set to 0xFF if they're not applicable.

Update AmpereSiliconPkg.dec to default to 0xFF instead of 0.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec b/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec
index 821f36e62b59..f87bb516bd4f 100644
--- a/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec
+++ b/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec
@@ -66,8 +66,8 @@ [PcdsFixedAtBuild]
   #
   # SMBIOS Type 0 Pcd
   #
-  gAmpereTokenSpaceGuid.PcdSmbiosTables0MajorVersion|0|UINT8|0x00000005
-  gAmpereTokenSpaceGuid.PcdSmbiosTables0MinorVersion|0|UINT8|0x00000006
+  gAmpereTokenSpaceGuid.PcdSmbiosTables0MajorVersion|0xFF|UINT8|0x00000005
+  gAmpereTokenSpaceGuid.PcdSmbiosTables0MinorVersion|0xFF|UINT8|0x00000006
 
 [PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx]
   #
-- 
2.45.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119500): https://edk2.groups.io/g/devel/message/119500
Mute This Topic: https://groups.io/mt/106517029/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 6/6] Silicon/Ampere: Remove bogus ASSERT that *PpiList is non-NULL

[Rebecca Cran]

On entry into ArmPlatformGetPlatformPpiList, *PpiList _can_ be NULL
since it's set within the function. So remove the bogus ASSERT.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.c b/Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.c
index f2ec923d6f8d..a5d15cda63f3 100644
--- a/Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.c
+++ b/Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.c
@@ -155,7 +155,6 @@ ArmPlatformGetPlatformPpiList (
 {
   ASSERT (PpiListSize != NULL);
   ASSERT (PpiList != NULL);
-  ASSERT (*PpiList != NULL);
 
   if (ArmIsMpCore ()) {
     *PpiListSize = sizeof (gPlatformPpiTable);
-- 
2.45.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119501): https://edk2.groups.io/g/devel/message/119501
Mute This Topic: https://groups.io/mt/106517030/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 0/6] JadePkg and common Ampere code fixes

[Nhi Pham via groups.io]

For this series,

Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>

Thanks,
Nhi

On 6/6/2024 10:04 AM, Rebecca Cran wrote:
> These are a set of bug fixes I made to the Mt Jade and common Ampere
> code while working on updating and improving ADLINK's edk2_aadp
> project.
> 
> Rebecca Cran (6):
>    Silicon/Ampere: Fix capitalization of Cache strings in PlatformInfoDxe
>    Silicon/Ampere: Reduce DEBUG_INFO spam in PciSegmentLibPci
>    Silicon/Ampere: Add TimerLib to DwGpioLib.inf for MicroSecondDelay
>    Platform/Ampere: Don't try and close the ACPI table if OpenSdt fails
>    Silicon/Ampere: Set default SMBIOS fw major/minor version to 0xFF
>    Silicon/Ampere: Remove bogus ASSERT that *PpiList is non-NULL
> 
>   Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec                          |  4 ++--
>   Silicon/Ampere/AmpereAltraPkg/Library/DwGpioLib/DwGpioLib.inf                 |  1 +
>   Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c                    |  1 -
>   Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.c         |  1 -
>   Silicon/Ampere/AmpereAltraPkg/Library/PciSegmentLibPci/PciSegmentLib.c        | 24 ++++++++++----------
>   Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoStrings.uni |  6 ++---
>   6 files changed, 18 insertions(+), 19 deletions(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119513): https://edk2.groups.io/g/devel/message/119513
Mute This Topic: https://groups.io/mt/106517021/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 0/6] JadePkg and common Ampere code fixes

[Nhi Pham via groups.io]

Pushed as 8975c5d45ea9..6c78047349e2

Thanks,
Nhi

On 6/7/2024 11:49 AM, Nhi Pham wrote:
> For this series,
> 
> Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>
> 
> Thanks,
> Nhi
> 
> On 6/6/2024 10:04 AM, Rebecca Cran wrote:
>> These are a set of bug fixes I made to the Mt Jade and common Ampere
>> code while working on updating and improving ADLINK's edk2_aadp
>> project.
>>
>> Rebecca Cran (6):
>>    Silicon/Ampere: Fix capitalization of Cache strings in PlatformInfoDxe
>>    Silicon/Ampere: Reduce DEBUG_INFO spam in PciSegmentLibPci
>>    Silicon/Ampere: Add TimerLib to DwGpioLib.inf for MicroSecondDelay
>>    Platform/Ampere: Don't try and close the ACPI table if OpenSdt fails
>>    Silicon/Ampere: Set default SMBIOS fw major/minor version to 0xFF
>>    Silicon/Ampere: Remove bogus ASSERT that *PpiList is non-NULL
>>
>>   
>> Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec                          |  4 ++--
>>   
>> Silicon/Ampere/AmpereAltraPkg/Library/DwGpioLib/DwGpioLib.inf                 |  1 +
>>   
>> Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c                    |  1 -
>>   
>> Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.c         |  1 -
>>   
>> Silicon/Ampere/AmpereAltraPkg/Library/PciSegmentLibPci/PciSegmentLib.c        | 24 ++++++++++----------
>>   
>> Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoStrings.uni |  6 ++---
>>   6 files changed, 18 insertions(+), 19 deletions(-)
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120135): https://edk2.groups.io/g/devel/message/120135
Mute This Topic: https://groups.io/mt/106517021/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-