From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io, nhi@os.amperecomputing.com
Cc: Rebecca Cran <rebecca@bsdio.com>,
Chuong Tran <chuong@os.amperecomputing.com>,
Leif Lindholm <quic_llindhol@quicinc.com>
Subject: [edk2-devel] [PATCH edk2-platforms 4/6] Platform/Ampere: Don't try and close the ACPI table if OpenSdt fails
Date: Wed, 5 Jun 2024 21:04:37 -0600 [thread overview]
Message-ID: <20240606030439.46610-5-rebecca@bsdio.com> (raw)
In-Reply-To: <20240606030439.46610-1-rebecca@bsdio.com>
In AcpiPatchDsdtTable if the call to OpenSdt fails, don't try and
close the TableHandle since it causes a crash.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c
index 885ad8fc3511..da7b50fd6d5e 100644
--- a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c
+++ b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c
@@ -671,7 +671,6 @@ AcpiPatchDsdtTable (
Status = AcpiSdtProtocol->OpenSdt (TableKey, &TableHandle);
if (EFI_ERROR (Status)) {
ASSERT_EFI_ERROR (Status);
- AcpiSdtProtocol->Close (TableHandle);
return Status;
}
--
2.45.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119499): https://edk2.groups.io/g/devel/message/119499
Mute This Topic: https://groups.io/mt/106517027/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-06-06 3:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 3:04 [edk2-devel] [PATCH edk2-platforms 0/6] JadePkg and common Ampere code fixes Rebecca Cran
2024-06-06 3:04 ` [edk2-devel] [PATCH edk2-platforms 1/6] Silicon/Ampere: Fix capitalization of Cache strings in PlatformInfoDxe Rebecca Cran
2024-06-06 3:04 ` [edk2-devel] [PATCH edk2-platforms 2/6] Silicon/Ampere: Reduce DEBUG_INFO spam in PciSegmentLibPci Rebecca Cran
2024-06-06 3:04 ` [edk2-devel] [PATCH edk2-platforms 3/6] Silicon/Ampere: Add TimerLib to DwGpioLib.inf for MicroSecondDelay Rebecca Cran
2024-06-06 3:04 ` Rebecca Cran [this message]
2024-06-06 3:04 ` [edk2-devel] [PATCH edk2-platforms 5/6] Silicon/Ampere: Set default SMBIOS fw major/minor version to 0xFF Rebecca Cran
2024-06-06 3:04 ` [edk2-devel] [PATCH edk2-platforms 6/6] Silicon/Ampere: Remove bogus ASSERT that *PpiList is non-NULL Rebecca Cran
2024-06-07 4:49 ` [edk2-devel] [PATCH edk2-platforms 0/6] JadePkg and common Ampere code fixes Nhi Pham via groups.io
2024-07-31 8:00 ` Nhi Pham via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606030439.46610-5-rebecca@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox