From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id D948B740038 for ; Thu, 6 Jun 2024 03:04:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=41AQg64fWujjKe0EHoT1EoJ0LPAg/bJ57rYyKOSpHHI=; c=relaxed/simple; d=groups.io; h=Feedback-ID:From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1717643096; v=1; b=lN0Fa9aPJDEhn/JHv/68Berb72rtQ4vpPvRSdo8/BDowCVuSRhRSFts1KzZJfrEWQbkdQgqu NSiSZqb6zqMnWS7tPRUmRu2Mr1O17yTHL4QcN/umA8L6B+yXe/PImDqlcm2kdIoec8BktKb76MH cMaZUbnRZYZQwhyqHvKRa3S3goa0U0WjNIMlzad/gRcgfpNKGsWWzNEUl0FAEJklEqVjtfCfAts EthHYDHoGr7lARh3BAvlpKnKzfNM+UyOpZPj70tVTZCvp4cyam2xbka2Uh7PUETDk/RWKh1ZKds 4zAi8e0kJYqHEz56S3QecSRXAL+mZu3i0Ev2F5KCN+acQ== X-Received: by 127.0.0.2 with SMTP id JifCYY7687511xupBZhkOb3t; Wed, 05 Jun 2024 20:04:55 -0700 X-Received: from fout1-smtp.messagingengine.com (fout1-smtp.messagingengine.com [103.168.172.144]) by mx.groups.io with SMTP id smtpd.web11.5170.1717643094907530896 for ; Wed, 05 Jun 2024 20:04:55 -0700 X-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id 4D1D9138011C; Wed, 5 Jun 2024 23:04:54 -0400 (EDT) X-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 05 Jun 2024 23:04:54 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeljedgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnhepgeffueeuledvgefgvddvgfetvdduhfefkedukeeikedtudekfeetteeifedv leefnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomheprh gvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Jun 2024 23:04:53 -0400 (EDT) From: "Rebecca Cran" To: devel@edk2.groups.io, nhi@os.amperecomputing.com Cc: Rebecca Cran , Chuong Tran , Leif Lindholm Subject: [edk2-devel] [PATCH edk2-platforms 4/6] Platform/Ampere: Don't try and close the ACPI table if OpenSdt fails Date: Wed, 5 Jun 2024 21:04:37 -0600 Message-ID: <20240606030439.46610-5-rebecca@bsdio.com> In-Reply-To: <20240606030439.46610-1-rebecca@bsdio.com> References: <20240606030439.46610-1-rebecca@bsdio.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 05 Jun 2024 20:04:55 -0700 Resent-From: rebecca@bsdio.com Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: J3CxOSp0y54cJHbSuYsWGHgox7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=lN0Fa9aP; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io In AcpiPatchDsdtTable if the call to OpenSdt fails, don't try and close the TableHandle since it causes a crash. Signed-off-by: Rebecca Cran --- Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c index 885ad8fc3511..da7b50fd6d5e 100644 --- a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c +++ b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c @@ -671,7 +671,6 @@ AcpiPatchDsdtTable ( Status = AcpiSdtProtocol->OpenSdt (TableKey, &TableHandle); if (EFI_ERROR (Status)) { ASSERT_EFI_ERROR (Status); - AcpiSdtProtocol->Close (TableHandle); return Status; } -- 2.45.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119499): https://edk2.groups.io/g/devel/message/119499 Mute This Topic: https://groups.io/mt/106517027/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-