From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id D277BD806B5 for ; Thu, 6 Jun 2024 03:04:57 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YAOrbe/dBwCqbs9Ea91VTi4vnVkbvMAifso2QeCMogA=; c=relaxed/simple; d=groups.io; h=Feedback-ID:From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1717643097; v=1; b=hNCA+zahimknMZotaVcjvGqRJzz29RtfFrdPV2+GSyn0UOytey8DlQNBF5Lrs9IPeuAM3JDq 9CxJ2jyWuuU89oSRD0UgjIYZpkGiTwID7VGkfu44HkMJTVI2PLYEoF37u7XVnYBlZHcc3ioCAqD M/yKFEMDU7MGOqpfHC/BpbhKdQ0Nkq+ie/6JGWefX59EFiBnfuspeaiMYfvlmO9oGRGZclKV9Cm YKwXfBsiuj40Sdd4k3K4+GbVYOr2zqaUzJ/n0R62BPoUP91hVn9SNtF4IJAWQwVj1EZIddyLcbg 5lBSXu69xaWOGHqn5blw3K0dqnlzDQT72js+CRXuy8vDw== X-Received: by 127.0.0.2 with SMTP id mrYBYY7687511xPIZhPNC1Vo; Wed, 05 Jun 2024 20:04:56 -0700 X-Received: from fout1-smtp.messagingengine.com (fout1-smtp.messagingengine.com [103.168.172.144]) by mx.groups.io with SMTP id smtpd.web11.5173.1717643095873946196 for ; Wed, 05 Jun 2024 20:04:56 -0700 X-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id 3B66F138011A; Wed, 5 Jun 2024 23:04:55 -0400 (EDT) X-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 05 Jun 2024 23:04:55 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeljedgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnhepgeffueeuledvgefgvddvgfetvdduhfefkedukeeikedtudekfeetteeifedv leefnecuvehluhhsthgvrhfuihiivgepvdenucfrrghrrghmpehmrghilhhfrhhomheprh gvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Jun 2024 23:04:54 -0400 (EDT) From: "Rebecca Cran" To: devel@edk2.groups.io, nhi@os.amperecomputing.com Cc: Rebecca Cran , Chuong Tran , Leif Lindholm Subject: [edk2-devel] [PATCH edk2-platforms 5/6] Silicon/Ampere: Set default SMBIOS fw major/minor version to 0xFF Date: Wed, 5 Jun 2024 21:04:38 -0600 Message-ID: <20240606030439.46610-6-rebecca@bsdio.com> In-Reply-To: <20240606030439.46610-1-rebecca@bsdio.com> References: <20240606030439.46610-1-rebecca@bsdio.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 05 Jun 2024 20:04:56 -0700 Resent-From: rebecca@bsdio.com Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: jXMd52nfKaPjDT36JQvUggkpx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=hNCA+zah; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none According to the SMBIOS specification, the firmware version major/minor values should be set to 0xFF if they're not applicable. Update AmpereSiliconPkg.dec to default to 0xFF instead of 0. Signed-off-by: Rebecca Cran --- Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec b/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec index 821f36e62b59..f87bb516bd4f 100644 --- a/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec +++ b/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec @@ -66,8 +66,8 @@ [PcdsFixedAtBuild] # # SMBIOS Type 0 Pcd # - gAmpereTokenSpaceGuid.PcdSmbiosTables0MajorVersion|0|UINT8|0x00000005 - gAmpereTokenSpaceGuid.PcdSmbiosTables0MinorVersion|0|UINT8|0x00000006 + gAmpereTokenSpaceGuid.PcdSmbiosTables0MajorVersion|0xFF|UINT8|0x00000005 + gAmpereTokenSpaceGuid.PcdSmbiosTables0MinorVersion|0xFF|UINT8|0x00000006 [PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx] # -- 2.45.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119500): https://edk2.groups.io/g/devel/message/119500 Mute This Topic: https://groups.io/mt/106517029/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-