From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 66D74D80225 for ; Tue, 18 Jun 2024 06:49:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hHA/fa2bSO0y2WrgnNv2xALkOCJ7RzLerNeDrFTu9Yk=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1718693345; v=1; b=pzozuRwOh48y1gtEEPRk3jWxgzjZKQCapQNB3nxUVEXU02ig6CPmasrVhUw5at/pc9pFxiq4 kbZGTR532Lt6C8Fo0mA5Hrku7PT/U3Hr+hP/l40ib56NmKKSsHY11d3HShMOIFZYvXTf7FWvQQL /zJWDyqJpa+Lp5uw8/UCxKieu1CF2XofVKfdDSnuc5YaSbnTEt6r5Omn+I9k90vENx/gECL4pKS C4xCseUIykljnFs7yh4Hal8rE2gq30Fg0gbyisntErF2FLHVPsiAsiZ2O2y9V/fd4oLetzdv6jx 7+LzeYACsEKwffI1mdKrXdN1O3TT1vX2mwaUc76ZCFShg== X-Received: by 127.0.0.2 with SMTP id FiEOYY7687511xUg1GsUYYIB; Mon, 17 Jun 2024 23:49:03 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mx.groups.io with SMTP id smtpd.web10.80496.1718693340815202911 for ; Mon, 17 Jun 2024 23:49:03 -0700 X-CSE-ConnectionGUID: RJaGQGImSNq/KneRhMEz+Q== X-CSE-MsgGUID: qjNB3WwTSpuqZLKWWrXKfA== X-IronPort-AV: E=McAfee;i="6700,10204,11106"; a="33020065" X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="33020065" X-Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2024 23:49:03 -0700 X-CSE-ConnectionGUID: kFkakBpFSRq+rLhtwrFHWw== X-CSE-MsgGUID: F1lmIFcPTIOvCp+CSRYN2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="41364557" X-Received: from njayapra-mobl.gar.corp.intel.com ([10.247.239.17]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2024 23:49:00 -0700 From: "Jayaprakash, N" To: devel@edk2.groups.io Cc: Jayaprakash N , Rebecca Cran , Michael D Kinney Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc : make python368.inf compile conditionally in AppPkg.dsc Date: Tue, 18 Jun 2024 12:16:10 +0530 Message-ID: <20240618064850.883-2-n.jayaprakash@intel.com> In-Reply-To: <20240618064850.883-1-n.jayaprakash@intel.com> References: <20240618064850.883-1-n.jayaprakash@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 17 Jun 2024 23:49:03 -0700 Resent-From: n.jayaprakash@intel.com Reply-To: devel@edk2.groups.io,n.jayaprakash@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: fQ4clymNAyyzbjU5H8dAJqipx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=pzozuRwO; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4789 This commit adds necessary changes to AppPkg.dsc file for conditional compilation of python368.inf. To enable compilation of python368.inf users need to pass an additional parameter to the build command as -D BUILD_PYTHON368. Also updated the Py368ReadMe.txt and the GCCCompilationBKMs.rst to include this additional information for building python368.inf. Cc: Rebecca Cran Cc: Michael D Kinney Cc: Jayaprakash N Signed-off-by: Jayaprakash N --- AppPkg/AppPkg.dsc | 9 ++++++--- .../Python/Python-3.6.8/GCCCompilationBKMs.rst | 6 ++---- AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt | 9 +++------ 3 files changed, 11 insertions(+), 13 deletions(-) diff --git a/AppPkg/AppPkg.dsc b/AppPkg/AppPkg.dsc index e5a6c5e..89f9f1d 100644 --- a/AppPkg/AppPkg.dsc +++ b/AppPkg/AppPkg.dsc @@ -7,7 +7,7 @@ # for important information about configuring this package for your # environment. # -# Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.
+# Copyright (c) 2010 - 2024, Intel Corporation. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent ## @@ -120,8 +120,11 @@ gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80400040 } -#### Un-comment the following line to build Python 3.6.8. -# AppPkg/Applications/Python/Python-3.6.8/Python368.inf +#### Conditional compilation of python368.inf by passing -D BUILD_PYTHON368 +#### through build command + !if $(BUILD_PYTHON368) + AppPkg/Applications/Python/Python-3.6.8/Python368.inf + !endif #### Un-comment the following line to build Lua. # AppPkg/Applications/Lua/Lua.inf diff --git a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst b/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst index 525bef8..0574977 100644 --- a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst +++ b/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst @@ -150,17 +150,15 @@ Copy the contents of edk2-libc to edk2 folder:: 2.5. Build Python Interpreter using GCC ---------------------------------------- -Uncomment the line containing following inf file name in AppPkg/AppPkg.dsc file -AppPkg/Applications/Python/Python-3.6.8/Python368.inf Execute the below command to build the X64 version of the Python 3.6.8 interpreter using GCC tool chain:: bash$ cd AppPkg/Applications/Python/Python-3.6.8/ bash$ python srcprep.py bash$ cd ~/src/edk2 - bash$ build -a X64 -b RELEASE -p AppPkg/AppPkg.dsc -m AppPkg/Applications/Python/Python-3.6.8/Python368.inf + bash$ build -a X64 -b RELEASE -p AppPkg/AppPkg.dsc -m AppPkg/Applications/Python/Python-3.6.8/Python368.inf -D BUILD_PYTHON368 or - bash$ build -a X64 -b RELEASE -p AppPkg/AppPkg.dsc + bash$ build -a X64 -b RELEASE -p AppPkg/AppPkg.dsc -D BUILD_PYTHON368 2.5 Create Python UEFI package with all dependencies diff --git a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt index a6e65fe..5753443 100644 --- a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt +++ b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt @@ -68,12 +68,9 @@ and that you can successfully build packages within that distribution. gc itertools math _operator time - C. Edit AppPkg/AppPkg.dsc to enable (uncomment) the Python368.inf line - within the [Components] section. - - D. Build AppPkg using the standard "build" command: + C. Build AppPkg using the standard "build" command: For example, to build Python for an X64 CPU architecture: - build -a X64 -p AppPkg\AppPkg.dsc + build -a X64 -p AppPkg\AppPkg.dsc -D BUILD_PYTHON368 4. Python-related paths and files ================================= @@ -133,7 +130,7 @@ system as follows: 2. Uncomment BsdSocketLib and EfiSocketLib LibraryClasses in Python368.inf 3. Uncomment the statement #Modules/socketmodule.c in Python368.inf 4. Build Python interpreter application using below command - build -a X64 -p AppPkg\AppPkg.dsc + build -a X64 -p AppPkg\AppPkg.dsc -D BUILD_PYTHON368 5. Copy Build\AppPkg\RELEASE_VS2017\X64\Python.efi to \Efi\Tools on your target system. Replace "RELEASE_VS2017", in the source path, with values appropriate for your tool chain. -- 2.45.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119604): https://edk2.groups.io/g/devel/message/119604 Mute This Topic: https://groups.io/mt/106736573/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-