public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Mike Maslenkin" <mike.maslenkin@gmail.com>
To: devel@edk2.groups.io, nathaniel.l.desimone@intel.com,
	gaoliming@byosoft.com.cn
Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
Subject: [edk2-devel] [edk2-platforms][PATCH 2/2] IpmiFeaturePkg/GenericIpmi: add EFIAPI for driver entrypoints
Date: Wed, 19 Jun 2024 01:32:07 +0300	[thread overview]
Message-ID: <20240618223207.12778-3-mike.maslenkin@gmail.com> (raw)
In-Reply-To: <20240618223207.12778-1-mike.maslenkin@gmail.com>

Fix gcc build failure:
IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c:414:1:
  error: conflicting types for 'InitializeSmmGenericIpmi'
  414 | InitializeSmmGenericIpmi (
      | ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from <command-line>:
IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi/DEBUG/AutoGen.h:138:1:
  note: previous declaration of 'InitializeSmmGenericIpmi' was here
  138 | InitializeSmmGenericIpmi (
      | ^~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
---
 .../OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/BmcElog.c     | 1 +
 .../IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c              | 1 +
 .../GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c           | 1 +
 3 files changed, 3 insertions(+)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/BmcElog.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/BmcElog.c
index 0b1e2f5b1355..cd627ea799a2 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/BmcElog.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/BmcElog.c
@@ -258,6 +258,7 @@ SetElogRedirInstall (
 
 **/
 EFI_STATUS
+EFIAPI
 InitializeBmcElogLayer (
   IN EFI_HANDLE        ImageHandle,
   IN EFI_SYSTEM_TABLE  *SystemTable
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c
index 23493733178a..976bb69c956b 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c
@@ -410,6 +410,7 @@ Returns:
 }
 
 EFI_STATUS
+EFIAPI
 InitializeSmmGenericIpmi (
   IN EFI_HANDLE        ImageHandle,
   IN EFI_SYSTEM_TABLE  *SystemTable
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
index edc9eec9395a..a7faa0e1f37f 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
@@ -330,6 +330,7 @@ Returns:
 
 **/
 EFI_STATUS
+EFIAPI
 InitializeGenericIpmiStandaloneMm (
   IN EFI_HANDLE           ImageHandle,
   IN EFI_MM_SYSTEM_TABLE  *SystemTable
-- 
2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119620): https://edk2.groups.io/g/devel/message/119620
Mute This Topic: https://groups.io/mt/106750822/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2024-06-18 22:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 22:32 [edk2-devel] [edk2-platforms][PATCH 0/2] IpmiFeaturePkg: compilation fix Mike Maslenkin
2024-06-18 22:32 ` [edk2-devel] [edk2-platforms][PATCH 1/2] IpmiFeaturePkg/GenericIpmi: add IpmiFeaturePkg.dec to packages list Mike Maslenkin
2024-06-18 22:32 ` Mike Maslenkin [this message]
2024-06-21 21:07 ` [edk2-devel] [edk2-platforms][PATCH 0/2] IpmiFeaturePkg: compilation fix Nate DeSimone
2024-06-21 21:08 ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240618223207.12778-3-mike.maslenkin@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox