From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id E1057941E33 for ; Tue, 18 Jun 2024 22:32:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=OhgIP74+KQXr+6wNetUMJSzKi0M0JrRBip96KBzNxlw=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1718749938; v=1; b=t3h2lU5IfAa2y7iBbrvKWjLZLPwJ5Yntr89yONKc//nuL7AOTA2TLw31xGVlz/II7MeTJmZ2 kfP1HR7LT882qJBvuiVRAa/lDnjkjQYbr+QBnxhWmeSxV9HcZy4IzSND7M9U3yai4e2VD1J8Ixy UTH9bQ9Wx/BuZARhM9fhhX1lknw3HpFg+dF18vAPW5VJz/0MFINt/l2SVk96gXIboInXOjq+SHR zClBI72FUl+Mw8dx/oHtlMPpP5q0+DrdHd3Isc6bR/uT+Q8q/0apBOhEyiLsr60C+LU7VhwJSk6 19UpMLfmNQlu9Tcu8ZtTgqtSuYMCaN7cdDQLfUk+M4skw== X-Received: by 127.0.0.2 with SMTP id 1x5HYY7687511xIsYsayD8tR; Tue, 18 Jun 2024 15:32:17 -0700 X-Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by mx.groups.io with SMTP id smtpd.web11.7463.1718749935374051046 for ; Tue, 18 Jun 2024 15:32:15 -0700 X-Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2ebd421a931so55520901fa.1 for ; Tue, 18 Jun 2024 15:32:15 -0700 (PDT) X-Gm-Message-State: wSZEgbEkKwMTE37XdLpSmTd7x7686176AA= X-Google-Smtp-Source: AGHT+IGZc6q+UnsCNjNaStXnPUMnZyhpGSYaVUex0iIbqDI/BSnnxohzER1U+O4LOaQ5hpsBpGSrXg== X-Received: by 2002:a2e:3c18:0:b0:2ec:3c55:3056 with SMTP id 38308e7fff4ca-2ec3cfe174dmr5004681fa.44.1718749933371; Tue, 18 Jun 2024 15:32:13 -0700 (PDT) X-Received: from localhost.localdomain ([185.20.45.7]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ec05c05fbfsm19254321fa.33.2024.06.18.15.32.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Jun 2024 15:32:13 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io, nathaniel.l.desimone@intel.com, gaoliming@byosoft.com.cn Cc: Mike Maslenkin Subject: [edk2-devel] [edk2-platforms][PATCH 2/2] IpmiFeaturePkg/GenericIpmi: add EFIAPI for driver entrypoints Date: Wed, 19 Jun 2024 01:32:07 +0300 Message-Id: <20240618223207.12778-3-mike.maslenkin@gmail.com> In-Reply-To: <20240618223207.12778-1-mike.maslenkin@gmail.com> References: <20240618223207.12778-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 18 Jun 2024 15:32:15 -0700 Resent-From: mike.maslenkin@gmail.com Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=t3h2lU5I; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Fix gcc build failure: IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c:414:1: error: conflicting types for 'InitializeSmmGenericIpmi' 414 | InitializeSmmGenericIpmi ( | ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from : IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi/DEBUG/AutoGen.h:138:1: note: previous declaration of 'InitializeSmmGenericIpmi' was here 138 | InitializeSmmGenericIpmi ( | ^~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Mike Maslenkin Cc: Nate DeSimone Cc: Liming Gao --- .../OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/BmcElog.c | 1 + .../IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c | 1 + .../GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c | 1 + 3 files changed, 3 insertions(+) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/= BmcElog.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/B= mcElog.c index 0b1e2f5b1355..cd627ea799a2 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/BmcElog= .c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/BmcElog= .c @@ -258,6 +258,7 @@ SetElogRedirInstall ( =0D **/=0D EFI_STATUS=0D +EFIAPI=0D InitializeBmcElogLayer (=0D IN EFI_HANDLE ImageHandle,=0D IN EFI_SYSTEM_TABLE *SystemTable=0D diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Smm/SmmGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Ge= nericIpmi/Smm/SmmGenericIpmi.c index 23493733178a..976bb69c956b 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/Smm= GenericIpmi.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/Smm= GenericIpmi.c @@ -410,6 +410,7 @@ Returns: }=0D =0D EFI_STATUS=0D +EFIAPI=0D InitializeSmmGenericIpmi (=0D IN EFI_HANDLE ImageHandle,=0D IN EFI_SYSTEM_TABLE *SystemTable=0D diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= StandaloneMm/StandaloneMmGenericIpmi.c b/Features/Intel/OutOfBandManagement= /IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c index edc9eec9395a..a7faa0e1f37f 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standal= oneMm/StandaloneMmGenericIpmi.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standal= oneMm/StandaloneMmGenericIpmi.c @@ -330,6 +330,7 @@ Returns: =0D **/=0D EFI_STATUS=0D +EFIAPI=0D InitializeGenericIpmiStandaloneMm (=0D IN EFI_HANDLE ImageHandle,=0D IN EFI_MM_SYSTEM_TABLE *SystemTable=0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119620): https://edk2.groups.io/g/devel/message/119620 Mute This Topic: https://groups.io/mt/106750822/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-