public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Chuong Tran <chuong@os.amperecomputing.com>,
	Graeme Gregory <graeme@xora.org.uk>,
	Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
	Marcin Wojtas <marcin.s.wojtas@gmail.com>,
	Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
	Narinder Dhillon <ndhillon@marvell.com>,
	Nhi Pham <nhi@os.amperecomputing.com>,
	Rebecca Cran <rebecca@os.amperecomputing.com>,
	Sami Mujawar <sami.mujawar@arm.com>,
	Thomas Abraham <thomas.abraham@arm.com>,
	Wenyi Xie <xiewenyi2@huawei.com>
Subject: [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz
Date: Thu, 20 Jun 2024 15:32:38 +0100	[thread overview]
Message-ID: <20240620143243.460947-1-quic_llindhol@quicinc.com> (raw)

Related to https://github.com/tianocore/edk2/pull/5797

PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete.
Its functionality has been partially broken, and mostly ignored, for
all AArch64 platforms since December 2020.

This set cleans up some broken line endings in .dsc* files, then
drops all non-invasive references to the Pcd:
- .dsc* files setting it to 0 (which is the default in the definition,
  and means "just read it from the system register instead")
- .inf files declaring a dependency that is in fact not there in
  current code.

Finally, it drops the setting of the Pcd for platforms that set it to
non-0. This has *never* done the right thing on these platforms since
they are all AArch64, but it may affect timer timeout, so deserves
deeper testing.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Chuong Tran <chuong@os.amperecomputing.com>
Cc: Graeme Gregory <graeme@xora.org.uk>
Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Cc: Marcin Wojtas <marcin.s.wojtas@gmail.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Cc: Narinder Dhillon <ndhillon@marvell.com>
Cc: Nhi Pham <nhi@os.amperecomputing.com>
Cc: Rebecca Cran <rebecca@os.amperecomputing.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Cc: Wenyi Xie <xiewenyi2@huawei.com>

Leif Lindholm (5):
  Platform/SbsaQemu: fix .dsc line endings
  Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz
  Platform/ARM: drop use of PcdArmArchTimerFreqInHz
  Platform/Hisilicon: drop D05 use of PcdArmArchTimerFreqInHz
  Silicon/Marvell: drop use of PcdArmArchTimerFreqInHz

 Platform/ARM/Morello/MorelloPlatform.dsc.inc                                   | 4 +---
 Platform/ARM/SgiPkg/SgiPlatform.dsc.inc                                        | 2 --
 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                           | 7 +------
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc                                  | 4 +---
 Silicon/NXP/NxpQoriqLs.dsc.inc                                                 | 5 +----
 Platform/ARM/JunoPkg/ArmJuno.dsc                                               | 6 ------
 Platform/ARM/N1Sdp/N1SdpPlatform.dsc                                           | 2 --
 Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc                           | 6 ------
 Platform/Hisilicon/D03/D03.dsc                                                 | 8 --------
 Platform/Hisilicon/D05/D05.dsc                                                 | 6 ------
 Platform/Hisilicon/D06/D06.dsc                                                 | 8 --------
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc                                            | 7 +------
 Platform/Hisilicon/D03/Library/HisiOemMiscLib2P/HisiOemMiscLib2PHi1610.inf     | 1 -
 Platform/Hisilicon/D05/Library/HisiOemMiscLibD05/HisiOemMiscLibD05.inf         | 1 -
 Platform/Hisilicon/D06/Library/HisiOemMiscLibD06/HisiOemMiscLibD06.inf         | 1 -
 Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf               | 1 -
 Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf | 1 -
 17 files changed, 5 insertions(+), 65 deletions(-)

-- 
2.39.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119653): https://edk2.groups.io/g/devel/message/119653
Mute This Topic: https://groups.io/mt/106780872/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



             reply	other threads:[~2024-06-20 14:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 14:32 Leif Lindholm [this message]
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings Leif Lindholm
2024-06-20 14:45   ` Marcin Juszkiewicz
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 2/5] Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz Leif Lindholm
2024-06-21  2:06   ` Nhi Pham via groups.io
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 3/5] Platform/ARM: drop use " Leif Lindholm
2024-06-23  4:53   ` Sami Mujawar
2024-06-24 10:26     ` Leif Lindholm
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 4/5] Platform/Hisilicon: drop D05 " Leif Lindholm
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 5/5] Silicon/Marvell: drop " Leif Lindholm
     [not found] ` <17DABCF836337F28.28936@groups.io>
2024-06-20 14:41   ` [edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings Leif Lindholm
2024-06-20 14:43 ` [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz Ard Biesheuvel
2024-06-21 11:37   ` Leif Lindholm
2024-06-23  5:31     ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240620143243.460947-1-quic_llindhol@quicinc.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox