From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Chuong Tran <chuong@os.amperecomputing.com>,
Graeme Gregory <graeme@xora.org.uk>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
Nhi Pham <nhi@os.amperecomputing.com>,
Rebecca Cran <rebecca@os.amperecomputing.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Thomas Abraham <thomas.abraham@arm.com>,
Wenyi Xie <xiewenyi2@huawei.com>
Subject: [edk2-devel] [PATCH edk2-platforms 2/5] Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz
Date: Thu, 20 Jun 2024 15:32:40 +0100 [thread overview]
Message-ID: <20240620143243.460947-3-quic_llindhol@quicinc.com> (raw)
In-Reply-To: <20240620143243.460947-1-quic_llindhol@quicinc.com>
PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete.
Some platforms already explicitly set it to 0, which is the default.
And some modules reference it in their .inf without actually ever
using it.
Drop these redundant uses first.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Chuong Tran <chuong@os.amperecomputing.com>
Cc: Graeme Gregory <graeme@xora.org.uk>
Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Cc: Nhi Pham <nhi@os.amperecomputing.com>
Cc: Rebecca Cran <rebecca@os.amperecomputing.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Cc: Wenyi Xie <xiewenyi2@huawei.com>
Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
---
Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 5 -----
Silicon/NXP/NxpQoriqLs.dsc.inc | 3 ---
Platform/ARM/JunoPkg/ArmJuno.dsc | 6 ------
Platform/Hisilicon/D03/D03.dsc | 8 --------
Platform/Hisilicon/D06/D06.dsc | 8 --------
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 5 -----
Platform/Hisilicon/D03/Library/HisiOemMiscLib2P/HisiOemMiscLib2PHi1610.inf | 1 -
Platform/Hisilicon/D05/Library/HisiOemMiscLibD05/HisiOemMiscLibD05.inf | 1 -
Platform/Hisilicon/D06/Library/HisiOemMiscLibD06/HisiOemMiscLibD06.inf | 1 -
Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf | 1 -
Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf | 1 -
11 files changed, 40 deletions(-)
diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
index eb6caf37a3c5..1f705c68579a 100644
--- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
+++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
@@ -458,11 +458,6 @@ [PcdsFixedAtBuild.common]
gArmTokenSpaceGuid.PcdGicDistributorBase|0x100100000000
gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x100100140000
- #
- # ARM Architectural Timer Frequency
- #
- # Set it to 0 so that the code will read frequence from register
- gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0
gEmbeddedTokenSpaceGuid.PcdMetronomeTickPeriod|1000
#
diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Silicon/NXP/NxpQoriqLs.dsc.inc
index 920d2f6c4ddf..21549dc20aa7 100644
--- a/Silicon/NXP/NxpQoriqLs.dsc.inc
+++ b/Silicon/NXP/NxpQoriqLs.dsc.inc
@@ -290,9 +290,6 @@ [PcdsFixedAtBuild.common]
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200
gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4
- # Timer
- gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0
-
# We want to use the Shell Libraries but don't want it to initialise
# automatically. We initialise the libraries when the command is called by the
# Shell.
diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc
index 1ca43b9e7dba..93ec9f129972 100644
--- a/Platform/ARM/JunoPkg/ArmJuno.dsc
+++ b/Platform/ARM/JunoPkg/ArmJuno.dsc
@@ -191,12 +191,6 @@ [PcdsFixedAtBuild.common]
# List of Device Paths that support BootMonFs
gArmBootMonFsTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths|L"VenHw(DE6AE758-D662-4E17-A97C-4C5964DA4C41,00)"
- #
- # ARM Architectural Timer Frequency
- #
- # Set to 0 so ArmArchTimerLib will read its value from CNTFRQ_EL0
- gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0
-
gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
#
diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
index 66c2bb31a5ef..e70dc97ee894 100644
--- a/Platform/Hisilicon/D03/D03.dsc
+++ b/Platform/Hisilicon/D03/D03.dsc
@@ -191,14 +191,6 @@ [PcdsFixedAtBuild.common]
gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0xFE000000
gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x4D100000
- #
- # ARM Architectual Timer Frequency
- #
- # Set it to 0 so that the code will read frequence from register and be
- # adapted to 66M and 50M boards
- gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0
-
-
gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc
index f8a8dad01a0e..6e0fcf633404 100644
--- a/Platform/Hisilicon/D06/D06.dsc
+++ b/Platform/Hisilicon/D06/D06.dsc
@@ -167,14 +167,6 @@ [PcdsFixedAtBuild.common]
gArmTokenSpaceGuid.PcdGicRedistributorsBase|0xAE100000
gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x9B000000
-
-
- #
- # ARM Architectual Timer Frequency
- #
- # Set it to 0 so that the code will read frequency from register and be
- # adapted to 100M and 50M boards
- gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0
gEmbeddedTokenSpaceGuid.PcdTimerPeriod|10000
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index 4fea9a0d6380..9306986bf7c0 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -415,11 +415,6 @@ [PcdsFixedAtBuild.common]
## 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8, 4-TTYTERM
gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4
- #
- # ARM Virtual Architectural Timer -- fetch frequency from QEMU (TCG) or KVM
- #
- gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0
-
gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
diff --git a/Platform/Hisilicon/D03/Library/HisiOemMiscLib2P/HisiOemMiscLib2PHi1610.inf b/Platform/Hisilicon/D03/Library/HisiOemMiscLib2P/HisiOemMiscLib2PHi1610.inf
index a91444c71dcb..59887f2b1029 100644
--- a/Platform/Hisilicon/D03/Library/HisiOemMiscLib2P/HisiOemMiscLib2PHi1610.inf
+++ b/Platform/Hisilicon/D03/Library/HisiOemMiscLib2P/HisiOemMiscLib2PHi1610.inf
@@ -39,7 +39,6 @@ [Ppis]
[Pcd]
gHisiTokenSpaceGuid.PcdTrustedFirmwareEnable
- gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz
[FixedPcd.common]
diff --git a/Platform/Hisilicon/D05/Library/HisiOemMiscLibD05/HisiOemMiscLibD05.inf b/Platform/Hisilicon/D05/Library/HisiOemMiscLibD05/HisiOemMiscLibD05.inf
index f223097ba8d4..b635dde51f7d 100644
--- a/Platform/Hisilicon/D05/Library/HisiOemMiscLibD05/HisiOemMiscLibD05.inf
+++ b/Platform/Hisilicon/D05/Library/HisiOemMiscLibD05/HisiOemMiscLibD05.inf
@@ -38,7 +38,6 @@ [Ppis]
gEfiPeiReadOnlyVariable2PpiGuid ## SOMETIMES_CONSUMES
[Pcd]
- gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz
gHisiTokenSpaceGuid.PcdIsMPBoot
gHisiTokenSpaceGuid.PcdSocketMask
gHisiTokenSpaceGuid.PcdTrustedFirmwareEnable
diff --git a/Platform/Hisilicon/D06/Library/HisiOemMiscLibD06/HisiOemMiscLibD06.inf b/Platform/Hisilicon/D06/Library/HisiOemMiscLibD06/HisiOemMiscLibD06.inf
index 0d030950ee54..01ff51feb9f2 100644
--- a/Platform/Hisilicon/D06/Library/HisiOemMiscLibD06/HisiOemMiscLibD06.inf
+++ b/Platform/Hisilicon/D06/Library/HisiOemMiscLibD06/HisiOemMiscLibD06.inf
@@ -39,7 +39,6 @@ [Ppis]
gEfiPeiReadOnlyVariable2PpiGuid ## SOMETIMES_CONSUMES
[Pcd]
- gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz
gHisiTokenSpaceGuid.PcdIsMPBoot
gHisiTokenSpaceGuid.PcdSocketMask
gHisiTokenSpaceGuid.PcdTrustedFirmwareEnable
diff --git a/Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf b/Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf
index 4b6609a66f50..43c596169fdd 100644
--- a/Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf
+++ b/Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf
@@ -45,7 +45,6 @@ [Guids]
[FixedPcd]
gArmPlatformTokenSpaceGuid.PcdCoreCount
- gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz
[Depex]
gEfiSmbiosProtocolGuid AND
diff --git a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf
index 895d72fc040f..433720f12900 100644
--- a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf
+++ b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf
@@ -47,7 +47,6 @@ [Protocols]
[Pcd]
gHisiTokenSpaceGuid.PcdCPUInfo
- gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz
[Guids]
--
2.39.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119656): https://edk2.groups.io/g/devel/message/119656
Mute This Topic: https://groups.io/mt/106780877/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-06-20 14:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 14:32 [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz Leif Lindholm
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings Leif Lindholm
2024-06-20 14:45 ` Marcin Juszkiewicz
2024-06-20 14:32 ` Leif Lindholm [this message]
2024-06-21 2:06 ` [edk2-devel] [PATCH edk2-platforms 2/5] Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz Nhi Pham via groups.io
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 3/5] Platform/ARM: drop use " Leif Lindholm
2024-06-23 4:53 ` Sami Mujawar
2024-06-24 10:26 ` Leif Lindholm
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 4/5] Platform/Hisilicon: drop D05 " Leif Lindholm
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 5/5] Silicon/Marvell: drop " Leif Lindholm
[not found] ` <17DABCF836337F28.28936@groups.io>
2024-06-20 14:41 ` [edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings Leif Lindholm
2024-06-20 14:43 ` [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz Ard Biesheuvel
2024-06-21 11:37 ` Leif Lindholm
2024-06-23 5:31 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620143243.460947-3-quic_llindhol@quicinc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox