From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: <devel@edk2.groups.io>
Cc: Sami Mujawar <sami.mujawar@arm.com>,
Thomas Abraham <thomas.abraham@arm.com>
Subject: [edk2-devel] [PATCH edk2-platforms 3/5] Platform/ARM: drop use of PcdArmArchTimerFreqInHz
Date: Thu, 20 Jun 2024 15:32:41 +0100 [thread overview]
Message-ID: <20240620143243.460947-4-quic_llindhol@quicinc.com> (raw)
In-Reply-To: <20240620143243.460947-1-quic_llindhol@quicinc.com>
Some Arm ltd. platforms explicitly set PcdArmArchTimerFreqInHz, however
the intended effect of that is not possible from AArch64 EL2/1, and has
never been performed unless built for ARM.
The Pcd is now being deleted, so drop the setting.
This has however affected timer timout calculations, so could lead to a
change in platform behaviour.
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
---
Platform/ARM/Morello/MorelloPlatform.dsc.inc | 2 --
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 --
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 2 --
Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 6 ------
4 files changed, 12 deletions(-)
diff --git a/Platform/ARM/Morello/MorelloPlatform.dsc.inc b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
index e7f4b6d0dde8..d2f885d1c10f 100644
--- a/Platform/ARM/Morello/MorelloPlatform.dsc.inc
+++ b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
@@ -110,8 +110,6 @@ [PcdsFixedAtBuild.common]
# PL031 RealTimeClock
gArmPlatformTokenSpaceGuid.PcdPL031RtcBase|0x1C100000
- # ARM Architectural Timer Frequency
- gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|50000000
gEmbeddedTokenSpaceGuid.PcdMetronomeTickPeriod|1000
gEmbeddedTokenSpaceGuid.PcdTimerPeriod|1000
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
index 107a5311b666..1090fbe2a1fc 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
+++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
@@ -178,8 +178,6 @@ [PcdsFixedAtBuild.common]
# ARM OS Loader
gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3
- # ARM Architectural Timer Frequency
- gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|100000000
gEmbeddedTokenSpaceGuid.PcdMetronomeTickPeriod|1000
gEmbeddedTokenSpaceGuid.PcdTimerPeriod|1000
diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
index 743c2e647b76..b14ece1b8f61 100644
--- a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
+++ b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
@@ -149,8 +149,6 @@ [PcdsFixedAtBuild.common]
# ARM OS Loader
gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|0
- # ARM Architectural Timer Frequency
- gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|100000000
gEmbeddedTokenSpaceGuid.PcdMetronomeTickPeriod|1000
gEmbeddedTokenSpaceGuid.PcdTimerPeriod|1000
diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
index c5fcf74b4e0a..60556f6661c4 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
@@ -213,12 +213,6 @@ [PcdsFixedAtBuild.common]
gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0x40000000
gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0x10000000
- #
- # ARM Architectural Timer Frequency
- #
- # Set tick frequency value to 100Mhz
- gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|100000000
-
#
# ACPI Table Version
#
--
2.39.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119657): https://edk2.groups.io/g/devel/message/119657
Mute This Topic: https://groups.io/mt/106780878/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-06-20 14:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 14:32 [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz Leif Lindholm
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings Leif Lindholm
2024-06-20 14:45 ` Marcin Juszkiewicz
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 2/5] Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz Leif Lindholm
2024-06-21 2:06 ` Nhi Pham via groups.io
2024-06-20 14:32 ` Leif Lindholm [this message]
2024-06-23 4:53 ` [edk2-devel] [PATCH edk2-platforms 3/5] Platform/ARM: drop use " Sami Mujawar
2024-06-24 10:26 ` Leif Lindholm
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 4/5] Platform/Hisilicon: drop D05 " Leif Lindholm
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 5/5] Silicon/Marvell: drop " Leif Lindholm
[not found] ` <17DABCF836337F28.28936@groups.io>
2024-06-20 14:41 ` [edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings Leif Lindholm
2024-06-20 14:43 ` [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz Ard Biesheuvel
2024-06-21 11:37 ` Leif Lindholm
2024-06-23 5:31 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620143243.460947-4-quic_llindhol@quicinc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox