public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Wenyi Xie <xiewenyi2@huawei.com>
Subject: [edk2-devel] [PATCH edk2-platforms 4/5] Platform/Hisilicon: drop D05 use of PcdArmArchTimerFreqInHz
Date: Thu, 20 Jun 2024 15:32:42 +0100	[thread overview]
Message-ID: <20240620143243.460947-5-quic_llindhol@quicinc.com> (raw)
In-Reply-To: <20240620143243.460947-1-quic_llindhol@quicinc.com>

The D05 platform explicitly sets PcdArmArchTimerFreqInHz, however the
intended effect of that is not possible from AArch64 EL2/1, and has
never been performed unless built for ARM.

The Pcd is now being deleted, so drop the setting.

This has however affected timer timout calculations, so could lead to a
change in platform behaviour.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Wenyi Xie <xiewenyi2@huawei.com>
Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
---
 Platform/Hisilicon/D05/D05.dsc | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc
index d247e67e92fc..0cd98d54ddb3 100644
--- a/Platform/Hisilicon/D05/D05.dsc
+++ b/Platform/Hisilicon/D05/D05.dsc
@@ -198,12 +198,6 @@ [PcdsFixedAtBuild.common]
   gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0xFE000000
 
 
-  #
-  # ARM Architectual Timer Frequency
-  #
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|50000000
-
-
   gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
 
   gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
-- 
2.39.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119655): https://edk2.groups.io/g/devel/message/119655
Mute This Topic: https://groups.io/mt/106780876/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2024-06-20 14:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 14:32 [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz Leif Lindholm
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings Leif Lindholm
2024-06-20 14:45   ` Marcin Juszkiewicz
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 2/5] Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz Leif Lindholm
2024-06-21  2:06   ` Nhi Pham via groups.io
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 3/5] Platform/ARM: drop use " Leif Lindholm
2024-06-23  4:53   ` Sami Mujawar
2024-06-24 10:26     ` Leif Lindholm
2024-06-20 14:32 ` Leif Lindholm [this message]
2024-06-20 14:32 ` [edk2-devel] [PATCH edk2-platforms 5/5] Silicon/Marvell: " Leif Lindholm
     [not found] ` <17DABCF836337F28.28936@groups.io>
2024-06-20 14:41   ` [edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings Leif Lindholm
2024-06-20 14:43 ` [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz Ard Biesheuvel
2024-06-21 11:37   ` Leif Lindholm
2024-06-23  5:31     ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240620143243.460947-5-quic_llindhol@quicinc.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox